Skip to content

refactor(profiling)!: use reqwest instead of hyper for exporter #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 6 commits into from
Jan 14, 2026
Merged

refactor(profiling)!: use reqwest instead of hyper for exporter #1444

dd-mergequeue merged 6 commits into from
Jan 14, 2026

Conversation

@danielsn
Copy link
Contributor

@danielsn danielsn commented Jan 13, 2026 •
edited
Loading

What does this PR do?

Uses reqwest instead of hyper for the profiler exporter.

Motivation

Using a high-level library rather than low-level networking makes the code clearer.

Additional Notes

Technically a breaking change since we change Rust APIs but we don't affect the FFI at all.

How to test the change?

Existing tests, plus a new end to end set of tests for the different endpoint types

@danielsn danielsn requested review from a team as code owners January 13, 2026 04:15
@danielsn danielsn force-pushed the dsn/profiler-reqwest branch from 6743cb4 to ec85a33 Compare January 13, 2026 04:15
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-01-14 21:18:34

Comparing candidate commit 8358888 in PR branch dsn/profiler-reqwest with baseline commit 65a5d9a in branch main.

Found 16 performance improvements and 2 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

scenario:benching serializing traces from their internal representation to msgpack

  • 🟩 execution_time [-805.666µs; -793.270µs] or [-5.432%; -5.348%]

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟩 execution_time [-4.413µs; -4.189µs] or [-5.389%; -5.115%]
  • 🟩 throughput [+659178.838op/s; +693718.614op/s] or [+5.397%; +5.680%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-3.899µs; -3.811µs] or [-5.205%; -5.088%]
  • 🟩 throughput [+716057.869op/s; +733091.346op/s] or [+5.363%; +5.491%]

scenario:credit_card/is_card_number/378282246310005

  • 🟩 execution_time [-4.327µs; -4.249µs] or [-6.008%; -5.899%]
  • 🟩 throughput [+870922.916op/s; +887437.154op/s] or [+6.272%; +6.391%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟩 execution_time [-7.023µs; -6.980µs] or [-13.456%; -13.374%]
  • 🟩 throughput [+2958599.047op/s; +2979340.245op/s] or [+15.441%; +15.549%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟩 execution_time [-4.511µs; -4.482µs] or [-7.843%; -7.792%]
  • 🟩 throughput [+1470001.635op/s; +1479007.480op/s] or [+8.454%; +8.506%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟩 execution_time [-4.968µs; -4.924µs] or [-9.074%; -8.994%]
  • 🟩 throughput [+1806276.998op/s; +1820976.475op/s] or [+9.890%; +9.970%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟩 execution_time [-7.149µs; -7.105µs] or [-13.696%; -13.611%]
  • 🟩 throughput [+3018530.655op/s; +3040101.285op/s] or [+15.757%; +15.870%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+575.053ns; +599.584ns] or [+5.765%; +6.011%]
  • 🟥 throughput [-5703565.260op/s; -5459621.550op/s] or [-5.689%; -5.445%]

scenario:sdk_test_data/rules-based

  • 🟩 execution_time [-33.944µs; -33.334µs] or [-18.796%; -18.458%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.912µs ± 0.003µs 3.911µs ± 0.001µs 3.913µs 3.916µs 3.918µs 3.918µs 0.17% -0.811 6.575 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255216772.563op/s 255655677.465op/s ± 171083.143op/s 255658366.036op/s ± 94338.876op/s 255756528.587op/s 255906260.446op/s 255958708.224op/s 256722190.747op/s 0.42% 0.827 6.672 0.07% 12097.405op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.018µs 77.587µs ± 0.414µs 77.485µs ± 0.247µs 77.765µs 78.223µs 78.991µs 79.476µs 2.57% 1.461 3.637 0.53% 0.029µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12582341.182op/s 12889129.553op/s ± 68322.377op/s 12905787.044op/s ± 41121.831op/s 12933896.189op/s 12969258.695op/s 12975774.905op/s 12984027.432op/s 0.61% -1.407 3.367 0.53% 4831.122op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.623µs 71.048µs ± 0.286µs 70.998µs ± 0.226µs 71.229µs 71.537µs 71.734µs 71.947µs 1.34% 0.628 -0.035 0.40% 0.020µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13899144.848op/s 14075228.954op/s ± 56605.049op/s 14084808.839op/s ± 44737.982op/s 14122738.013op/s 14152977.497op/s 14158249.972op/s 14159606.279op/s 0.53% -0.609 -0.074 0.40% 4002.581op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.898µs 3.913µs ± 0.009µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.921µs 3.998µs 2.21% 8.489 78.358 0.22% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 250107709.727op/s 255577420.762op/s ± 552896.081op/s 255632580.387op/s ± 118309.222op/s 255743747.237op/s 255868794.010op/s 255907334.837op/s 256571224.714op/s 0.37% -8.435 77.673 0.22% 39095.657op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.404µs 67.729µs ± 0.240µs 67.715µs ± 0.210µs 67.871µs 68.212µs 68.328µs 68.392µs 1.00% 0.719 -0.306 0.35% 0.017µs 1 200
credit_card/is_card_number/378282246310005 throughput 14621525.276op/s 14765000.492op/s ± 52176.513op/s 14767857.763op/s ± 45845.655op/s 14814395.901op/s 14825050.711op/s 14832166.522op/s 14835932.629op/s 0.46% -0.706 -0.331 0.35% 3689.437op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.822µs 45.188µs ± 0.151µs 45.197µs ± 0.105µs 45.303µs 45.413µs 45.500µs 45.520µs 0.71% -0.174 -0.523 0.33% 0.011µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21968576.425op/s 22129897.322op/s ± 74010.952op/s 22125505.675op/s ± 51568.775op/s 22176329.548op/s 22260613.343op/s 22291694.050op/s 22310306.618op/s 0.84% 0.188 -0.517 0.33% 5233.365op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.038µs ± 0.019µs 6.034µs ± 0.003µs 6.037µs 6.049µs 6.109µs 6.211µs 2.92% 5.585 38.174 0.31% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 161008877.546op/s 165613348.994op/s ± 511156.326op/s 165717847.813op/s ± 70492.507op/s 165777604.645op/s 165879666.757op/s 165894329.782op/s 165906902.498op/s 0.11% -5.503 36.911 0.31% 36144.210op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.923µs 0.30% -0.856 10.253 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254913261.202op/s 255662437.497op/s ± 168932.810op/s 255667862.565op/s ± 102165.009op/s 255761433.902op/s 255884377.517op/s 255933760.940op/s 256790770.154op/s 0.44% 0.879 10.369 0.07% 11945.354op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.226µs 65.727µs ± 0.086µs 65.733µs ± 0.052µs 65.780µs 65.855µs 65.911µs 65.954µs 0.34% -0.991 5.029 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15162099.192op/s 15214431.454op/s ± 19976.484op/s 15213105.028op/s ± 11980.787op/s 15225489.121op/s 15246327.743op/s 15266966.652op/s 15331285.020op/s 0.78% 1.014 5.161 0.13% 1412.551op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.937µs 53.017µs ± 0.036µs 53.013µs ± 0.019µs 53.033µs 53.094µs 53.133µs 53.147µs 0.25% 0.969 1.664 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18815570.771op/s 18861866.422op/s ± 12628.435op/s 18863285.444op/s ± 6818.090op/s 18869787.583op/s 18879518.556op/s 18883814.852op/s 18890367.801op/s 0.14% -0.964 1.650 0.07% 892.965op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.898µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.913µs 3.918µs 3.920µs 3.923µs 0.29% 0.261 1.902 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254888435.222op/s 255622144.763op/s ± 206622.281op/s 255634071.974op/s ± 117622.216op/s 255768379.692op/s 255895972.815op/s 255965759.267op/s 256533554.479op/s 0.35% -0.252 1.915 0.08% 14610.402op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.733µs 49.807µs ± 0.037µs 49.800µs ± 0.021µs 49.825µs 49.887µs 49.914µs 49.929µs 0.26% 0.907 0.998 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20028554.142op/s 20077625.686op/s ± 14935.247op/s 20080206.940op/s ± 8446.988op/s 20087141.719op/s 20097780.909op/s 20103875.329op/s 20107218.491op/s 0.13% -0.902 0.988 0.07% 1056.081op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.671µs 45.074µs ± 0.156µs 45.084µs ± 0.108µs 45.173µs 45.332µs 45.377µs 45.427µs 0.76% -0.064 -0.487 0.34% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 22013525.626op/s 22186011.783op/s ± 76584.700op/s 22180918.867op/s ± 53170.043op/s 22238278.798op/s 22308345.054op/s 22357950.574op/s 22386012.090op/s 0.92% 0.079 -0.483 0.34% 5415.356op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.044µs ± 0.035µs 6.035µs ± 0.003µs 6.039µs 6.106µs 6.254µs 6.315µs 4.63% 5.280 31.506 0.57% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 158356070.474op/s 165463308.464op/s ± 920214.108op/s 165686696.192op/s ± 84464.647op/s 165754872.811op/s 165857149.028op/s 165892498.519op/s 165928087.590op/s 0.15% -5.186 30.380 0.55% 65068.964op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255631966.986op/s; 255679387.943op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.530µs; 77.644µs] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12879660.729op/s; 12898598.377op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.008µs; 71.088µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14067384.039op/s; 14083073.870op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.914µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631 throughput [255500794.683op/s; 255654046.841op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.695µs; 67.762µs] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/378282246310005 throughput [14757769.329op/s; 14772231.654op/s] or [-0.049%; +0.049%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.167µs; 45.209µs] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22119640.116op/s; 22140154.528op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.041µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/x371413321323331 throughput [165542507.643op/s; 165684190.344op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255639025.035op/s; 255685849.960op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.715µs; 65.739µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15211662.906op/s; 15217200.003op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.012µs; 53.022µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18860116.242op/s; 18863616.601op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255593508.902op/s; 255650780.624op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.802µs; 49.812µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20075555.804op/s; 20079695.568op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.052µs; 45.096µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22175397.880op/s; 22196625.686op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.039µs; 6.049µs] or [-0.079%; +0.079%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165335775.639op/s; 165590841.289op/s] or [-0.077%; +0.077%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.355µs 2.397µs ± 0.017µs 2.394µs ± 0.004µs 2.399µs 2.444µs 2.452µs 2.464µs 2.92% 1.758 4.193 0.71% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.394µs; 2.399µs] or [-0.098%; +0.098%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.214µs 3.158µs ± 1.433µs 2.984µs ± 0.026µs 3.006µs 3.351µs 13.726µs 15.224µs 410.25% 7.503 56.957 45.27% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.959µs; 3.356µs] or [-6.290%; +6.290%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.993ms 3.998ms ± 0.008ms 3.997ms ± 0.001ms 3.998ms 4.002ms 4.006ms 4.099ms 2.56% 12.227 161.277 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.997ms; 3.999ms] or [-0.026%; +0.026%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 145.108µs 146.957µs ± 1.672µs 146.698µs ± 0.401µs 147.182µs 148.658µs 151.983µs 163.312µs 11.33% 6.337 52.987 1.13% 0.118µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.726µs; 147.189µs] or [-0.158%; +0.158%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.806µs 90.037µs ± 0.174µs 90.014µs ± 0.048µs 90.064µs 90.200µs 90.439µs 91.975µs 2.18% 7.573 77.797 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.013µs; 90.062µs] or [-0.027%; +0.027%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.253µs 26.024µs ± 9.534µs 18.759µs ± 0.415µs 34.515µs 43.369µs 47.038µs 69.392µs 269.91% 0.988 0.727 36.54% 0.674µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.703µs; 27.346µs] or [-5.077%; +5.077%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.968µs 5.046µs ± 0.044µs 5.052µs ± 0.045µs 5.089µs 5.100µs 5.102µs 5.123µs 1.41% -0.071 -1.656 0.87% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.039µs; 5.052µs] or [-0.121%; +0.121%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.614ms 10.643ms ± 0.015ms 10.643ms ± 0.009ms 10.651ms 10.670ms 10.681ms 10.722ms 0.74% 1.189 4.059 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.641ms; 10.645ms] or [-0.020%; +0.020%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 494.538µs 495.829µs ± 0.817µs 495.795µs ± 0.330µs 496.097µs 496.586µs 498.847µs 503.494µs 1.55% 4.856 40.072 0.16% 0.058µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1986120.987op/s 2016828.469op/s ± 3295.603op/s 2016961.639op/s ± 1343.008op/s 2018521.563op/s 2020567.185op/s 2021666.170op/s 2022090.212op/s 0.25% -4.765 38.971 0.16% 233.034op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 370.876µs 371.517µs ± 0.302µs 371.515µs ± 0.179µs 371.666µs 371.963µs 372.259µs 373.225µs 0.46% 1.139 4.787 0.08% 0.021µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2679348.918op/s 2691669.007op/s ± 2187.811op/s 2691678.681op/s ± 1298.292op/s 2693093.722op/s 2694994.370op/s 2695681.261op/s 2696316.140op/s 0.17% -1.126 4.712 0.08% 154.702op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 167.347µs 167.640µs ± 0.149µs 167.616µs ± 0.104µs 167.734µs 167.910µs 167.983µs 168.082µs 0.28% 0.488 -0.165 0.09% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5949464.693op/s 5965165.109op/s ± 5309.706op/s 5966030.808op/s ± 3684.786op/s 5968930.814op/s 5972881.230op/s 5975236.596op/s 5975611.722op/s 0.16% -0.484 -0.170 0.09% 375.453op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.061µs 37.247µs ± 0.070µs 37.235µs ± 0.045µs 37.287µs 37.384µs 37.409µs 37.446µs 0.57% 0.463 0.006 0.19% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26704980.245op/s 26847702.718op/s ± 50191.617op/s 26856161.228op/s ± 32169.653op/s 26881274.609op/s 26917926.504op/s 26943209.979op/s 26982882.911op/s 0.47% -0.453 -0.001 0.19% 3549.083op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.638µs 45.772µs ± 0.109µs 45.764µs ± 0.043µs 45.809µs 45.853µs 45.871µs 47.106µs 2.93% 9.268 111.801 0.24% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21228532.941op/s 21847526.208op/s ± 50784.864op/s 21851064.360op/s ± 20332.556op/s 21869346.824op/s 21892842.276op/s 21909346.797op/s 21911666.282op/s 0.28% -9.070 108.623 0.23% 3591.032op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [495.716µs; 495.942µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2016371.730op/s; 2017285.208op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [371.475µs; 371.559µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2691365.797op/s; 2691972.216op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [167.619µs; 167.661µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5964429.235op/s; 5965900.983op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.238µs; 37.257µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26840746.643op/s; 26854658.793op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.757µs; 45.787µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21840487.915op/s; 21854564.502op/s] or [-0.032%; +0.032%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 238.966ns 248.707ns ± 11.839ns 242.729ns ± 2.771ns 251.708ns 277.112ns 287.373ns 290.212ns 19.56% 1.742 2.421 4.75% 0.837ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [247.066ns; 250.348ns] or [-0.660%; +0.660%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.485ms 60.932ms ± 2.466ms 60.604ms ± 0.039ms 60.658ms 60.830ms 79.798ms 82.292ms 35.79% 7.993 62.208 4.04% 0.174ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.590ms; 61.274ms] or [-0.561%; +0.561%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.037µs 33.501µs ± 0.776µs 33.148µs ± 0.051µs 33.281µs 35.107µs 35.180µs 37.092µs 11.90% 1.884 2.389 2.31% 0.055µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.393µs; 33.609µs] or [-0.321%; +0.321%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 527.988µs 528.669µs ± 0.420µs 528.630µs ± 0.199µs 528.845µs 529.229µs 529.725µs 532.420µs 0.72% 3.760 30.362 0.08% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [528.610µs; 528.727µs] or [-0.011%; +0.011%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.459µs 161.192µs ± 0.280µs 161.179µs ± 0.131µs 161.306µs 161.718µs 161.919µs 162.696µs 0.94% 0.935 4.341 0.17% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.153µs; 161.231µs] or [-0.024%; +0.024%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.162µs 185.641µs ± 0.208µs 185.613µs ± 0.146µs 185.784µs 186.021µs 186.163µs 186.331µs 0.39% 0.467 -0.067 0.11% 0.015µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5366789.902op/s 5386760.595op/s ± 6032.912op/s 5387548.231op/s ± 4229.754op/s 5390948.375op/s 5395447.160op/s 5398398.817op/s 5400676.894op/s 0.24% -0.461 -0.074 0.11% 426.591op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.809µs 17.881µs ± 0.037µs 17.873µs ± 0.017µs 17.899µs 17.942µs 18.024µs 18.107µs 1.31% 2.045 7.633 0.21% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 55226491.266op/s 55924772.710op/s ± 116162.892op/s 55950592.336op/s ± 53400.422op/s 55996462.342op/s 56045054.954op/s 56090534.082op/s 56151728.577op/s 0.36% -2.011 7.395 0.21% 8213.957op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.500µs 10.562µs ± 0.025µs 10.560µs ± 0.014µs 10.577µs 10.608µs 10.626µs 10.645µs 0.81% 0.495 0.480 0.23% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 93939335.268op/s 94680443.259op/s ± 222331.992op/s 94696832.789op/s ± 126741.075op/s 94812404.434op/s 95027008.163op/s 95079851.622op/s 95237956.761op/s 0.57% -0.480 0.456 0.23% 15721.246op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.612µs; 185.669µs] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5385924.491op/s; 5387596.698op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.876µs; 17.886µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55908673.650op/s; 55940871.770op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.558µs; 10.565µs] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/good throughput [94649630.183op/s; 94711256.335op/s] or [-0.033%; +0.033%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.996ms 14.033ms ± 0.026ms 14.029ms ± 0.012ms 14.042ms 14.062ms 14.137ms 14.189ms 1.14% 2.667 11.067 0.19% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.029ms; 14.036ms] or [-0.026%; +0.026%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 186.582ns 189.623ns ± 2.109ns 189.358ns ± 1.506ns 190.694ns 193.502ns 195.192ns 196.876ns 3.97% 0.841 0.313 1.11% 0.149ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [189.331ns; 189.915ns] or [-0.154%; +0.154%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8358888 1768424524 dsn/profiler-reqwest
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.537ms 9.800ms ± 0.075ms 9.814ms ± 0.030ms 9.840ms 9.884ms 9.989ms 10.023ms 2.14% -1.049 2.458 0.76% 0.005ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.790ms; 9.811ms] or [-0.106%; +0.106%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.56164% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.28%. Comparing base (de271ed) to head (8358888).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
- Coverage   71.30%   71.28%   -0.02%     
==========================================
  Files         413      416       +3     
  Lines       66157    66757     +600     
==========================================
+ Hits        47172    47591     +419     
- Misses      18985    19166     +181
Components Coverage Δ
libdd-crashtracker 61.39% <ø> (+2.72%) ⬆️
libdd-crashtracker-ffi 16.38% <ø> (+2.01%) ⬆️
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 85.89% <ø> (-0.15%) ⬇️
libdd-data-pipeline-ffi 76.90% <ø> (-0.11%) ⬇️
libdd-common 80.84% <100.00%> (-0.27%) ⬇️
libdd-common-ffi 74.19% <ø> (ø)
libdd-telemetry 60.22% <ø> (ø)
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.71% <ø> (+0.10%) ⬆️
libdd-profiling 80.65% <83.44%> (-0.40%) ⬇️
libdd-profiling-ffi 62.46% <85.71%> (+0.03%) ⬆️
datadog-sidecar 35.91% <ø> (-0.09%) ⬇️
datdog-sidecar-ffi 11.04% <ø> (-0.42%) ⬇️
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 89.89% <ø> (+0.14%) ⬆️
datadog-tracer-flare 62.06% <ø> (+1.00%) ⬆️
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielsn danielsn changed the title refactor(profiling): Use reqwest instead of hyper for exporter refactor(profiling): use reqwest instead of hyper for exporter Jan 13, 2026
@danielsn danielsn force-pushed the dsn/profiler-reqwest branch from ec85a33 to 5b427a1 Compare January 13, 2026 17:27
@danielsn danielsn force-pushed the dsn/profiler-reqwest branch from 5b427a1 to 779821f Compare January 13, 2026 17:29
@danielsn danielsn changed the title refactor(profiling): use reqwest instead of hyper for exporter refactor!(profiling): use reqwest instead of hyper for exporter Jan 13, 2026
@danielsn danielsn changed the title refactor!(profiling): use reqwest instead of hyper for exporter refactor(profiling)!: use reqwest instead of hyper for exporter Jan 13, 2026
@dd-octo-sts
Copy link

dd-octo-sts bot commented Jan 13, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 87.80 MB 91.77 MB +4.52% (+3.96 MB) ⚠️
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.57 MB 8.00 MB +5.77% (+447.96 KB) 🚨
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 59.43 MB 62.98 MB +5.96% (+3.54 MB) 🚨
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.58 MB 9.18 MB +7.07% (+621.60 KB) 🚨
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.71 MB 10.37 MB +6.77% (+673.95 KB) 🚨
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 101.52 MB 106.10 MB +4.51% (+4.58 MB) ⚠️
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 20.43 MB 24.03 MB +17.61% (+3.59 MB) 🚨
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 73.49 KB 76.33 KB +3.86% (+2.83 KB) ⚠️
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 151.28 MB 162.69 MB +7.53% (+11.40 MB) 🚨
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 817.84 MB 811.98 MB --.71% (-5.86 MB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.51 MB 8.83 MB +35.60% (+2.32 MB) 🚨
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 73.49 KB 76.33 KB +3.86% (+2.83 KB) ⚠️
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 20.14 MB 22.01 MB +9.30% (+1.87 MB) 🚨
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 39.52 MB 47.54 MB +20.31% (+8.02 MB) 🚨
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 17.43 MB 20.23 MB +16.05% (+2.79 MB) 🚨
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 74.62 KB 77.50 KB +3.86% (+2.88 KB) ⚠️
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 154.16 MB 166.44 MB +7.97% (+12.28 MB) 🚨
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 805.63 MB 797.25 MB --1.04% (-8.38 MB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 5.01 MB 6.86 MB +36.95% (+1.85 MB) 🚨
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 74.62 KB 77.50 KB +3.86% (+2.88 KB) ⚠️
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 21.47 MB 23.66 MB +10.22% (+2.19 MB) 🚨
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 37.29 MB 43.27 MB +16.02% (+5.97 MB) 🚨
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.05 MB 79.87 MB +5.01% (+3.81 MB) 🚨
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.00 MB 9.50 MB +5.64% (+519.96 KB) 🚨
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 60.76 MB 64.35 MB +5.90% (+3.58 MB) 🚨
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.63 MB 10.22 MB +6.22% (+613.48 KB) 🚨
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.61 MB 99.80 MB +4.38% (+4.19 MB) ⚠️
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.45 MB 11.08 MB +6.05% (+648.15 KB) 🚨

taegyunkim
taegyunkim approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, though my knowledge on Rust/async/tokio is somewhat limited.

libdd-profiling/src/exporter/profile_exporter.rs
/// [`send`]: ProfileExporter::send
#[allow(clippy::too_many_arguments)]
pub fn send_blocking(
&mut self,
Copy link
Contributor

@taegyunkim taegyunkim Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question I had in mind was why would this need to take self as mutable.
It's modifying self.runtime, and consulting with claude suggested using OnceLock but turns out that it won't be thread-safe given that we use new_current_thread().

Correct me, if my understanding is wrong.

morrisonlevi
morrisonlevi reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to review in depth still but I noticed the artifacts came up in size a fair bit. Maybe there's something we can do to trim it back down? Maybe features we can disable?

@danielsn danielsn force-pushed the dsn/profiler-reqwest branch 2 times, most recently from 99bfb90 to bec5c87 Compare January 14, 2026 04:28
morrisonlevi
morrisonlevi reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it out with PHP yet, but I did notice something was lost from main.

@danielsn danielsn force-pushed the dsn/profiler-reqwest branch 2 times, most recently from 38b8ad9 to c8719cb Compare January 14, 2026 18:28
@danielsn
Copy link
Contributor Author

danielsn commented Jan 14, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 14, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-14 18:29:36 UTC ℹ️ Start processing command /merge

2026-01-14 18:29:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-14 21:29:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 30m (p90).

2026-01-14 21:57:52 UTC ℹ️ MergeQueue: This merge request was merged

@danielsn
Copy link
Contributor Author

danielsn commented Jan 14, 2026

This change fixes a customer affecting fork-safety issue on python, so going ahead and will look at binary size later.

@danielsn danielsn force-pushed the dsn/profiler-reqwest branch from c8719cb to d3050db Compare January 14, 2026 20:06
@dd-mergequeue dd-mergequeue bot merged commit 39c7829 into main Jan 14, 2026
42 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dsn/profiler-reqwest branch January 14, 2026 21:57
This was referenced Jan 20, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrisonlevi morrisonlevi morrisonlevi left review comments

@taegyunkim taegyunkim taegyunkim approved these changes

Assignees

No one assigned

Labels

common mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielsn @codecov-commenter @morrisonlevi @taegyunkim