Skip to content

[Crashtracker][bug]Add is_crash field to Log message #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Crashtracker][bug]Add is_crash field to Log message #1093

wants to merge 1 commit into from

Conversation

gleocadie
Copy link
Contributor

What does this PR do?

Add is_crash to Log message

Motivation

In this PR we do not fill the Stacktrace field of the log message to reduce the size of the message.
Except that in the backend, we use that field to recognize crash log and symbolize them.

In the backend code, I saw that the Log struct has a IsCrash/is_crash field.https://github.com/DataDog/dd-go/blob/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/logs.go#L65

@gleocadie gleocadie requested review from a team as code owners June 6, 2025 07:23
@gleocadie gleocadie requested a review from paullegranddc June 6, 2025 07:23
@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-06-06 17:03:09

Comparing candidate commit daaeb37 in PR branch gleocadie/help-backend-to-differentiate-crashlog-from-other-logs with baseline commit 3b3f734 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.682ns 254.606ns ± 14.434ns 247.405ns ± 2.683ns 260.957ns 286.023ns 302.289ns 305.157ns 23.34% 1.608 1.672 5.66% 1.021ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.606ns; 256.607ns] or [-0.786%; +0.786%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.912µs 3.914µs 3.915µs 3.918µs 0.19% -1.436 11.321 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255216868.437op/s 255704266.584op/s ± 152917.829op/s 255709737.835op/s ± 88461.826op/s 255790602.372op/s 255900682.031op/s 255971421.701op/s 256786559.333op/s 0.42% 1.456 11.475 0.06% 10812.923op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.878µs 78.538µs ± 0.869µs 78.500µs ± 0.604µs 79.105µs 79.929µs 80.861µs 81.510µs 3.83% 0.535 0.416 1.10% 0.061µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12268433.321op/s 12734234.481op/s ± 140110.247op/s 12738881.474op/s ± 98472.328op/s 12837558.204op/s 12951223.086op/s 12999733.401op/s 13007566.949op/s 2.11% -0.466 0.274 1.10% 9907.291op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 69.959µs 71.225µs ± 0.634µs 71.152µs ± 0.444µs 71.693µs 72.276µs 72.827µs 73.032µs 2.64% 0.288 -0.313 0.89% 0.045µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13692719.639op/s 14041152.356op/s ± 124660.115op/s 14054427.831op/s ± 87225.156op/s 14131494.939op/s 14236833.597op/s 14277484.234op/s 14294187.973op/s 1.71% -0.245 -0.355 0.89% 8814.801op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.919µs 0.21% -0.635 5.896 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255145899.650op/s 255649889.557op/s ± 181432.460op/s 255671697.144op/s ± 108998.201op/s 255763224.703op/s 255885346.726op/s 255931576.367op/s 256754903.195op/s 0.42% 0.651 5.988 0.07% 12829.212op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 66.880µs 68.239µs ± 0.665µs 68.193µs ± 0.390µs 68.576µs 69.483µs 69.800µs 69.962µs 2.59% 0.353 -0.110 0.97% 0.047µs 1 200
credit_card/is_card_number/378282246310005 throughput 14293506.956op/s 14655672.155op/s ± 142380.841op/s 14664172.570op/s ± 84407.790op/s 14748376.157op/s 14896317.636op/s 14929891.787op/s 14952218.507op/s 1.96% -0.301 -0.147 0.97% 10067.846op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.147µs 52.214µs ± 0.037µs 52.209µs ± 0.026µs 52.240µs 52.279µs 52.302µs 52.341µs 0.25% 0.540 -0.184 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19105340.679op/s 19151859.241op/s ± 13635.043op/s 19153615.690op/s ± 9567.043op/s 19162424.880op/s 19170296.968op/s 19174810.416op/s 19176478.132op/s 0.12% -0.537 -0.191 0.07% 964.143op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.034µs ± 0.006µs 6.033µs ± 0.003µs 6.037µs 6.042µs 6.058µs 6.072µs 0.64% 3.075 15.794 0.09% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 164697416.674op/s 165717067.846op/s ± 152485.267op/s 165747342.070op/s ± 70533.097op/s 165812701.253op/s 165881963.107op/s 165909244.436op/s 165921902.822op/s 0.11% -3.052 15.602 0.09% 10782.337op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.919µs 3.924µs 0.29% -1.033 12.188 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254870269.837op/s 255598303.587op/s ± 180323.703op/s 255610804.616op/s ± 104074.221op/s 255707939.737op/s 255806226.094op/s 255848143.712op/s 256871875.182op/s 0.49% 1.061 12.366 0.07% 12750.811op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.973µs 64.390µs ± 0.220µs 64.356µs ± 0.096µs 64.472µs 64.631µs 64.938µs 65.973µs 2.51% 3.755 24.419 0.34% 0.016µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15157618.831op/s 15530537.039op/s ± 52466.152op/s 15538448.323op/s ± 23285.045op/s 15559097.079op/s 15589077.284op/s 15608533.271op/s 15631571.084op/s 0.60% -3.631 23.283 0.34% 3709.917op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.836µs 58.052µs ± 0.139µs 58.012µs ± 0.062µs 58.093µs 58.330µs 58.574µs 58.653µs 1.10% 1.788 3.882 0.24% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17049545.585op/s 17225955.827op/s ± 41037.384op/s 17237918.504op/s ± 18380.781op/s 17251656.546op/s 17268066.769op/s 17282486.965op/s 17290227.563op/s 0.30% -1.769 3.794 0.24% 2901.781op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.891µs 3.912µs ± 0.004µs 3.911µs ± 0.002µs 3.914µs 3.918µs 3.923µs 3.936µs 0.63% 1.121 10.504 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254054813.221op/s 255606881.566op/s ± 265037.102op/s 255657113.800op/s ± 136885.132op/s 255767758.073op/s 255868794.008op/s 255908494.520op/s 257020914.423op/s 0.53% -1.086 10.461 0.10% 18740.953op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.577µs 54.865µs ± 0.205µs 54.807µs ± 0.107µs 54.949µs 55.312µs 55.447µs 55.592µs 1.43% 1.275 1.243 0.37% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17988139.623op/s 18226921.736op/s ± 67693.927op/s 18245773.594op/s ± 35529.992op/s 18274195.017op/s 18301092.851op/s 18316293.022op/s 18322668.806op/s 0.42% -1.257 1.185 0.37% 4786.683op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.142µs 52.208µs ± 0.035µs 52.204µs ± 0.024µs 52.228µs 52.269µs 52.285µs 52.466µs 0.50% 2.170 12.624 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19059958.858op/s 19154242.885op/s ± 12981.803op/s 19155539.036op/s ± 8643.907op/s 19163790.976op/s 19169235.390op/s 19174219.349op/s 19178307.416op/s 0.12% -2.150 12.439 0.07% 917.952op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.034µs ± 0.007µs 6.033µs ± 0.002µs 6.036µs 6.043µs 6.055µs 6.108µs 1.24% 6.015 53.285 0.12% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163727197.309op/s 165716269.927op/s ± 198277.218op/s 165751095.139op/s ± 68244.478op/s 165814666.313op/s 165886715.622op/s 165909860.536op/s 165925041.111op/s 0.10% -5.947 52.325 0.12% 14020.317op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.910µs; 3.911µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [255683073.644op/s; 255725459.524op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.418µs; 78.658µs] or [-0.153%; +0.153%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12714816.549op/s; 12753652.414op/s] or [-0.152%; +0.152%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.137µs; 71.313µs] or [-0.123%; +0.123%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14023875.663op/s; 14058429.049op/s] or [-0.123%; +0.123%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255624744.763op/s; 255675034.351op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.147µs; 68.332µs] or [-0.135%; +0.135%] None None None
credit_card/is_card_number/378282246310005 throughput [14635939.539op/s; 14675404.770op/s] or [-0.135%; +0.135%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.209µs; 52.219µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19149969.555op/s; 19153748.927op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.034µs; 6.035µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/x371413321323331 throughput [165695934.854op/s; 165738200.837op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255573312.456op/s; 255623294.718op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.359µs; 64.421µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15523265.735op/s; 15537808.343op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.033µs; 58.072µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17220268.441op/s; 17231643.214op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255570149.973op/s; 255643613.160op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.836µs; 54.893µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18217540.009op/s; 18236303.463op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.203µs; 52.213µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19152443.732op/s; 19156042.038op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.033µs; 6.035µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165688790.612op/s; 165743749.243op/s] or [-0.017%; +0.017%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 35.049µs 35.472µs ± 0.633µs 35.158µs ± 0.063µs 35.418µs 36.714µs 36.781µs 39.034µs 11.03% 2.046 4.551 1.78% 0.045µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [35.384µs; 35.560µs] or [-0.247%; +0.247%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.430µs 28.046µs ± 9.655µs 20.469µs ± 1.626µs 35.837µs 44.751µs 46.105µs 68.185µs 233.11% 0.878 0.741 34.34% 0.683µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.708µs; 29.384µs] or [-4.771%; +4.771%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 532.222µs 533.035µs ± 0.525µs 532.990µs ± 0.225µs 533.201µs 533.646µs 533.916µs 538.636µs 1.06% 6.142 63.033 0.10% 0.037µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1856541.338op/s 1876049.935op/s ± 1836.298op/s 1876208.534op/s ± 791.941op/s 1877029.815op/s 1878038.667op/s 1878582.395op/s 1878916.643op/s 0.14% -6.062 61.908 0.10% 129.846op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 384.549µs 386.005µs ± 0.601µs 386.152µs ± 0.248µs 386.377µs 386.706µs 386.970µs 387.190µs 0.27% -0.954 0.058 0.16% 0.043µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2582708.905op/s 2590646.783op/s ± 4041.323op/s 2589652.901op/s ± 1663.906op/s 2591367.114op/s 2598959.736op/s 2600232.301op/s 2600447.301op/s 0.42% 0.959 0.064 0.16% 285.765op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.172µs 189.849µs ± 0.440µs 189.782µs ± 0.175µs 190.001µs 190.270µs 190.718µs 193.288µs 1.85% 4.726 34.364 0.23% 0.031µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5173617.997op/s 5267358.176op/s ± 12086.987op/s 5269205.040op/s ± 4842.238op/s 5273388.874op/s 5279867.178op/s 5283823.676op/s 5286208.188op/s 0.32% -4.629 33.388 0.23% 854.679op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.558µs 37.678µs ± 0.044µs 37.675µs ± 0.030µs 37.708µs 37.753µs 37.788µs 37.855µs 0.48% 0.438 0.713 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26416787.822op/s 26540934.557op/s ± 31250.627op/s 26542841.954op/s ± 21349.851op/s 26562151.152op/s 26586569.672op/s 26603487.742op/s 26625171.311op/s 0.31% -0.429 0.695 0.12% 2209.753op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.930µs 45.161µs ± 0.245µs 45.145µs ± 0.148µs 45.281µs 45.416µs 45.539µs 47.737µs 5.74% 5.905 59.316 0.54% 0.017µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20947984.757op/s 22143401.697op/s ± 116426.160op/s 22150765.502op/s ± 72738.431op/s 22228009.866op/s 22248887.377op/s 22252971.763op/s 22257091.666op/s 0.48% -5.491 53.545 0.52% 8232.573op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [532.963µs; 533.108µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1875795.441op/s; 1876304.428op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [385.922µs; 386.088µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2590086.694op/s; 2591206.871op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.788µs; 189.911µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5265683.036op/s; 5269033.316op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.672µs; 37.684µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26536603.520op/s; 26545265.593op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.128µs; 45.195µs] or [-0.075%; +0.075%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22127266.151op/s; 22159537.243op/s] or [-0.073%; +0.073%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.146ms 8.166ms ± 0.009ms 8.165ms ± 0.007ms 8.172ms 8.184ms 8.192ms 8.201ms 0.45% 0.722 0.644 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.165ms; 8.167ms] or [-0.016%; +0.016%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.238µs 3.280µs ± 1.454µs 3.049µs ± 0.030µs 3.087µs 3.706µs 14.387µs 15.086µs 394.82% 7.314 54.779 44.22% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.079µs; 3.482µs] or [-6.144%; +6.144%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 88.871µs 89.163µs ± 0.211µs 89.111µs ± 0.093µs 89.267µs 89.387µs 89.510µs 91.261µs 2.41% 5.406 48.714 0.24% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.134µs; 89.193µs] or [-0.033%; +0.033%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.007ms 72.258ms ± 0.122ms 72.243ms ± 0.066ms 72.313ms 72.437ms 72.615ms 73.009ms 1.06% 1.914 8.424 0.17% 0.009ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.241ms; 72.275ms] or [-0.023%; +0.023%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 150.144µs 150.872µs ± 0.341µs 150.840µs ± 0.143µs 150.980µs 151.359µs 151.997µs 153.941µs 2.06% 4.193 32.583 0.23% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.825µs; 150.920µs] or [-0.031%; +0.031%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.353µs 204.994µs ± 0.350µs 204.942µs ± 0.215µs 205.165µs 205.627µs 205.932µs 206.245µs 0.64% 0.859 0.581 0.17% 0.025µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4848599.849op/s 4878207.710op/s ± 8321.046op/s 4879421.902op/s ± 5106.455op/s 4884360.617op/s 4888945.524op/s 4891130.647op/s 4893502.830op/s 0.29% -0.849 0.558 0.17% 588.387op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.607µs 18.741µs ± 0.065µs 18.744µs ± 0.042µs 18.782µs 18.853µs 18.881µs 18.958µs 1.14% 0.284 0.021 0.34% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52749312.024op/s 53359164.894op/s ± 183799.975op/s 53351068.813op/s ± 120764.889op/s 53478765.960op/s 53648761.380op/s 53702874.892op/s 53741942.124op/s 0.73% -0.265 -0.009 0.34% 12996.621op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.834µs 10.907µs ± 0.028µs 10.904µs ± 0.017µs 10.924µs 10.950µs 10.985µs 11.001µs 0.89% 0.545 0.740 0.26% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90901653.501op/s 91684786.727op/s ± 234328.583op/s 91707070.686op/s ± 145956.253op/s 91840874.418op/s 92045319.575op/s 92147200.086op/s 92301356.830op/s 0.65% -0.526 0.709 0.25% 16569.533op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [204.945µs; 205.042µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4877054.493op/s; 4879360.927op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.732µs; 18.750µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53333691.985op/s; 53384637.803op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.903µs; 10.911µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [91652311.039op/s; 91717262.415op/s] or [-0.035%; +0.035%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.301µs 2.363µs ± 0.019µs 2.360µs ± 0.007µs 2.370µs 2.403µs 2.407µs 2.420µs 2.54% 0.066 1.633 0.80% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.360µs; 2.365µs] or [-0.111%; +0.111%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz daaeb37 1749228704 gleocadie/help-backend-to-differentiate-crashlog-from-other-logs
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.995µs 5.077µs ± 0.036µs 5.078µs ± 0.028µs 5.105µs 5.132µs 5.136µs 5.142µs 1.26% -0.092 -1.120 0.71% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.072µs; 5.082µs] or [-0.099%; +0.099%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.98%. Comparing base (3b3f734) to head (daaeb37).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
+ Coverage   70.95%   70.98%   +0.02%     
==========================================
  Files         334      334              
  Lines       50549    50553       +4     
==========================================
+ Hits        35869    35886      +17     
+ Misses      14680    14667      -13
Components Coverage Δ
datadog-crashtracker 44.42% <100.00%> (+0.01%) ⬆️
datadog-crashtracker-ffi 6.03% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.43% <ø> (ø)
data-pipeline-ffi 89.26% <ø> (ø)
ddcommon 79.07% <ø> (ø)
ddcommon-ffi 68.64% <ø> (ø)
ddtelemetry 60.58% <0.00%> (+0.01%) ⬆️
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.17% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 42.32% <ø> (ø)
datdog-sidecar-ffi 10.36% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.16% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.44% <ø> (ø)
datadog-log 66.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

r1viollet commented Jun 6, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 70.23 MB 70.24 MB +0% (+272 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.16 MB 9.16 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.17 MB 22.17 MB +0% (+32 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 81.89 MB 81.89 MB +0% (+264 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 26.03 MB 26.03 MB +0% (+72 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.08 MB 9.08 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 15.99 MB 15.99 MB +0% (+512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.65 KB 62.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 108.94 MB 108.94 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 577.71 MB 577.72 MB +0% (+3.01 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.00 MB 5.00 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.65 KB 62.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.53 MB 15.53 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 28.56 MB 28.56 MB +0% (+246 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 13.55 MB 13.55 MB +0% (+512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.60 KB 63.60 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 110.52 MB 110.53 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 568.91 MB 568.91 MB +0% (+2.86 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.78 MB 3.78 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.60 KB 63.60 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.51 MB 16.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 26.78 MB 26.78 MB +0% (+132 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 62.87 MB 62.87 MB +0% (+200 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.78 MB 9.78 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.98 MB 20.98 MB +0% (+24 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 76.88 MB 76.88 MB +0% (+168 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.68 MB 9.68 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.97 MB 23.97 MB +0% (+56 B) 👌

@gleocadie
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 6, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-06 11:47:22 UTC ℹ️ Start processing command /merge

2025-06-06 11:47:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-06 15:48:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@gleocadie
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Jun 6, 2025

View all feedbacks in Devflow UI.

2025-06-06 16:51:33 UTC ℹ️ Start processing command /merge -c
If you need support, contact us on Slack #devflow!

2025-06-06 16:51:35 UTC ❌ Devflow: /merge -c

This merge request was already processed and can't be unqueued anymore.

To get help about command usage, write /merge --help

If you need support, contact us on Slack #devflow with those details!

@gleocadie gleocadie force-pushed the gleocadie/help-backend-to-differentiate-crashlog-from-other-logs branch from de4c188 to daaeb37 Compare June 6, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullegranddc paullegranddc Awaiting requested review from paullegranddc paullegranddc is a code owner automatically assigned from DataDog/libdatadog-telemetry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
crashtracker mergequeue-status: removed telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gleocadie @codecov-commenter @r1viollet