-
Notifications
You must be signed in to change notification settings - Fork 13
[Crashtracker][bug]Add is_crash
field to Log message
#1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crashtracker][bug]Add is_crash
field to Log message
#1093
Conversation
BenchmarksComparisonBenchmark execution time: 2025-06-06 17:03:09 Comparing candidate commit daaeb37 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
+ Coverage 70.99% 71.00% +0.01%
==========================================
Files 335 335
Lines 51017 51021 +4
==========================================
+ Hits 36219 36230 +11
+ Misses 14798 14791 -7
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
/merge -c |
View all feedbacks in Devflow UI.
This merge request was already processed and can't be unqueued anymore. To get help about command usage, write If you need support, contact us on Slack #devflow with those details! |
de4c188
to
daaeb37
Compare
@@ -268,6 +269,7 @@ mod tests { | |||
assert_eq!(payload["application"]["service_version"], "bar"); | |||
assert_eq!(payload["request_type"], "logs"); | |||
assert_eq!(payload["tracer_time"], 1568898000); | |||
assert_eq!(payload["origin"], "Crashtracker"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit dae3fe4: What to do next?
|
/merge |
View all feedbacks in Devflow UI.
This PR is rejected because it was updated |
daaeb37
to
39885c2
Compare
What does this PR do?
Add
is_crash
to Log messageMotivation
In this PR we do not fill the
Stacktrace
field of the log message to reduce the size of the message.Except that in the backend, we use that field to recognize crash log and symbolize them.
In the backend code, I saw that the
Log
struct has aIsCrash/is_crash
field.https://github.com/DataDog/dd-go/blob/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/logs.go#L65