-
Notifications
You must be signed in to change notification settings - Fork 13
[Build] Remove unused build-<config/profiling/telemetry>.sh scripts #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2025-06-05 20:18:28 Comparing candidate commit 6de2323 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
+ Coverage 70.95% 70.98% +0.02%
==========================================
Files 334 334
Lines 50549 50549
==========================================
+ Hits 35868 35882 +14
+ Misses 14681 14667 -14
🚀 New features to boost your workflow:
|
|
the file is still used as noted by gregorie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok config and telemetry
What does this PR do?
Removes these scripts since we shouldn't use them anymore.
Motivation
We have a better way of building FFI now.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.