Skip to content

[Build] Remove unused build-<config/profiling/telemetry>.sh scripts #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Jun 5, 2025

What does this PR do?

Removes these scripts since we shouldn't use them anymore.

Motivation

We have a better way of building FFI now.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested review from a team as code owners June 5, 2025 20:06
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-06-05 20:18:28

Comparing candidate commit 6de2323 in PR branch dsn/remove-sh-builders with baseline commit de39cc6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.284µs 3.282µs ± 1.453µs 3.049µs ± 0.025µs 3.073µs 3.733µs 14.538µs 14.891µs 388.33% 7.303 54.620 44.15% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.081µs; 3.483µs] or [-6.134%; +6.134%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.315µs 2.369µs ± 0.016µs 2.368µs ± 0.005µs 2.375µs 2.399µs 2.408µs 2.410µs 1.81% -0.453 2.360 0.66% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.367µs; 2.371µs] or [-0.092%; +0.092%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.057ms 72.818ms ± 0.274ms 72.877ms ± 0.070ms 72.947ms 73.164ms 73.269ms 73.362ms 0.66% -1.394 1.491 0.38% 0.019ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.780ms; 72.856ms] or [-0.052%; +0.052%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.090µs 34.776µs ± 1.128µs 34.266µs ± 0.066µs 34.363µs 37.210µs 37.241µs 37.840µs 10.43% 1.695 0.927 3.23% 0.080µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.620µs; 34.932µs] or [-0.449%; +0.449%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 88.768µs 89.188µs ± 0.158µs 89.187µs ± 0.067µs 89.252µs 89.348µs 89.518µs 90.649µs 1.64% 4.078 36.014 0.18% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.166µs; 89.210µs] or [-0.025%; +0.025%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.989µs 5.068µs ± 0.045µs 5.080µs ± 0.029µs 5.100µs 5.138µs 5.142µs 5.144µs 1.27% -0.123 -1.225 0.88% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.062µs; 5.074µs] or [-0.122%; +0.122%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.136ms 8.157ms ± 0.011ms 8.155ms ± 0.006ms 8.162ms 8.175ms 8.187ms 8.233ms 0.96% 2.123 10.827 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.155ms; 8.158ms] or [-0.019%; +0.019%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.251ns 254.864ns ± 12.877ns 249.386ns ± 4.888ns 260.539ns 286.312ns 291.088ns 293.895ns 17.85% 1.516 1.396 5.04% 0.911ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.080ns; 256.649ns] or [-0.700%; +0.700%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 150.715µs 151.159µs ± 0.428µs 151.072µs ± 0.126µs 151.247µs 151.605µs 152.124µs 155.101µs 2.67% 6.260 50.474 0.28% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [151.099µs; 151.218µs] or [-0.039%; +0.039%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.661µs 25.469µs ± 9.638µs 17.902µs ± 0.131µs 33.773µs 42.103µs 43.778µs 68.928µs 285.04% 1.130 1.657 37.75% 0.682µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.133µs; 26.804µs] or [-5.245%; +5.245%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.912µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.918µs 3.919µs 3.920µs 0.22% -0.308 5.345 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255120010.169op/s 255646967.218op/s ± 201988.568op/s 255674739.340op/s ± 108485.452op/s 255767784.857op/s 255883079.243op/s 255970688.284op/s 256835624.397op/s 0.45% 0.325 5.434 0.08% 14282.749op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.681µs 78.458µs ± 0.722µs 78.390µs ± 0.460µs 78.880µs 79.631µs 80.633µs 80.774µs 3.04% 0.629 0.831 0.92% 0.051µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12380173.462op/s 12746775.450op/s ± 116698.862op/s 12756672.932op/s ± 75280.578op/s 12829237.638op/s 12924080.673op/s 12973989.292op/s 13041034.839op/s 2.23% -0.563 0.707 0.91% 8251.856op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 69.869µs 71.193µs ± 0.635µs 71.166µs ± 0.457µs 71.656µs 72.242µs 72.744µs 72.894µs 2.43% 0.267 -0.447 0.89% 0.045µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13718627.639op/s 14047528.952op/s ± 124960.009op/s 14051556.581op/s ± 89667.563op/s 14138565.461op/s 14239851.312op/s 14270998.131op/s 14312503.464op/s 1.86% -0.228 -0.486 0.89% 8836.007op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.918µs 3.919µs 3.921µs 0.23% -0.636 5.894 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255046596.125op/s 255616909.055op/s ± 208452.061op/s 255642914.939op/s ± 128636.799op/s 255750830.478op/s 255869438.027op/s 255929205.423op/s 256894404.846op/s 0.49% 0.654 6.005 0.08% 14739.787op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 66.897µs 68.287µs ± 0.726µs 68.251µs ± 0.514µs 68.726µs 69.409µs 69.846µs 71.877µs 5.31% 0.794 1.926 1.06% 0.051µs 1 200
credit_card/is_card_number/378282246310005 throughput 13912705.063op/s 14645690.218op/s ± 154587.541op/s 14651698.502op/s ± 110077.440op/s 14770951.172op/s 14869141.221op/s 14916052.688op/s 14948414.243op/s 2.03% -0.695 1.472 1.05% 10930.990op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.136µs 52.198µs ± 0.030µs 52.198µs ± 0.020µs 52.215µs 52.253µs 52.283µs 52.284µs 0.17% 0.491 0.158 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19126153.920op/s 19157933.486op/s ± 10941.473op/s 19157762.881op/s ± 7459.911op/s 19166838.016op/s 19174204.655op/s 19177176.936op/s 19180549.005op/s 0.12% -0.488 0.152 0.06% 773.679op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.033µs ± 0.003µs 6.033µs ± 0.002µs 6.035µs 6.039µs 6.040µs 6.042µs 0.15% 0.344 -0.461 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165508953.016op/s 165749558.091op/s ± 86953.970op/s 165758247.450op/s ± 60556.272op/s 165815382.634op/s 165881329.030op/s 165899600.448op/s 165931308.244op/s 0.10% -0.342 -0.463 0.05% 6148.574op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.918µs 0.17% -1.636 12.377 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255230146.823op/s 255670230.513op/s ± 170285.322op/s 255667031.736op/s ± 98252.831op/s 255768661.100op/s 255904007.955op/s 256007385.316op/s 256901915.612op/s 0.48% 1.659 12.565 0.07% 12040.991op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.063µs 64.424µs ± 0.152µs 64.402µs ± 0.087µs 64.488µs 64.709µs 64.875µs 64.945µs 0.84% 0.706 0.632 0.24% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15397603.126op/s 15522251.458op/s ± 36561.686op/s 15527354.496op/s ± 20921.056op/s 15548246.108op/s 15571979.637op/s 15589464.597op/s 15609748.288op/s 0.53% -0.691 0.605 0.23% 2585.302op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.792µs 58.054µs ± 0.142µs 58.023µs ± 0.080µs 58.130µs 58.368µs 58.428µs 58.583µs 0.97% 1.045 1.070 0.24% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17069771.457op/s 17225296.498op/s ± 42052.152op/s 17234532.052op/s ± 23745.023op/s 17252699.568op/s 17280958.028op/s 17288794.299op/s 17303545.496op/s 0.40% -1.031 1.032 0.24% 2973.536op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.918µs 0.18% -1.257 10.406 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255237968.230op/s 255687297.334op/s ± 163797.859op/s 255689273.843op/s ± 105692.163op/s 255796787.109op/s 255875469.175op/s 255946717.791op/s 256827317.829op/s 0.45% 1.278 10.562 0.06% 11582.258op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.582µs 54.840µs ± 0.198µs 54.787µs ± 0.112µs 54.937µs 55.216µs 55.420µs 55.814µs 1.88% 1.646 3.986 0.36% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17916611.391op/s 18235047.662op/s ± 65513.498op/s 18252656.265op/s ± 37162.096op/s 18281588.653op/s 18305056.589op/s 18320128.398op/s 18321113.251op/s 0.38% -1.611 3.789 0.36% 4632.504op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.146µs 52.209µs ± 0.036µs 52.203µs ± 0.023µs 52.227µs 52.276µs 52.306µs 52.408µs 0.39% 1.355 3.871 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19081039.261op/s 19153960.090op/s ± 13373.995op/s 19156087.544op/s ± 8308.125op/s 19163905.742op/s 19171014.002op/s 19173262.432op/s 19176918.661op/s 0.11% -1.347 3.821 0.07% 945.684op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.035µs ± 0.004µs 6.034µs ± 0.003µs 6.037µs 6.042µs 6.046µs 6.051µs 0.28% 0.815 0.605 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165265185.334op/s 165713392.220op/s ± 118751.859op/s 165734468.642op/s ± 77840.163op/s 165800895.328op/s 165864470.710op/s 165889417.053op/s 165938276.366op/s 0.12% -0.810 0.592 0.07% 8397.024op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255618973.545op/s; 255674960.891op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.358µs; 78.558µs] or [-0.128%; +0.128%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12730602.110op/s; 12762948.790op/s] or [-0.127%; +0.127%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.105µs; 71.280µs] or [-0.124%; +0.124%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14030210.696op/s; 14064847.207op/s] or [-0.123%; +0.123%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255588019.604op/s; 255645798.506op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.186µs; 68.388µs] or [-0.147%; +0.147%] None None None
credit_card/is_card_number/378282246310005 throughput [14624265.871op/s; 14667114.564op/s] or [-0.146%; +0.146%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.194µs; 52.202µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19156417.103op/s; 19159449.869op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.033µs; 6.034µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [165737507.107op/s; 165761609.075op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [255646630.605op/s; 255693830.421op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.403µs; 64.445µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15517184.360op/s; 15527318.556op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.035µs; 58.074µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17219468.474op/s; 17231124.522op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.911µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255664596.527op/s; 255709998.142op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.813µs; 54.868µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18225968.121op/s; 18244127.202op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.203µs; 52.214µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19152106.583op/s; 19155813.597op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.034µs; 6.035µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165696934.354op/s; 165729850.085op/s] or [-0.010%; +0.010%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 532.119µs 532.982µs ± 0.494µs 532.903µs ± 0.279µs 533.209µs 533.751µs 534.757µs 535.851µs 0.55% 2.035 8.045 0.09% 0.035µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1866188.776op/s 1876239.132op/s ± 1734.778op/s 1876513.180op/s ± 983.580op/s 1877422.790op/s 1878281.254op/s 1878600.771op/s 1879279.714op/s 0.15% -2.019 7.935 0.09% 122.667op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 381.223µs 381.824µs ± 0.258µs 381.803µs ± 0.157µs 381.957µs 382.337µs 382.551µs 382.766µs 0.25% 0.658 0.841 0.07% 0.018µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2612563.135op/s 2619008.484op/s ± 1766.112op/s 2619148.630op/s ± 1075.965op/s 2620243.770op/s 2621577.972op/s 2622601.393op/s 2623138.085op/s 0.15% -0.653 0.832 0.07% 124.883op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 188.752µs 189.334µs ± 0.241µs 189.315µs ± 0.167µs 189.495µs 189.786µs 189.855µs 190.072µs 0.40% 0.362 -0.165 0.13% 0.017µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5261162.061op/s 5281675.154op/s ± 6709.803op/s 5282199.476op/s ± 4647.463op/s 5286505.020op/s 5291278.111op/s 5294725.321op/s 5297959.987op/s 0.30% -0.355 -0.170 0.13% 474.455op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.566µs 37.659µs ± 0.047µs 37.651µs ± 0.032µs 37.690µs 37.740µs 37.778µs 37.811µs 0.43% 0.655 0.142 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26447127.341op/s 26554176.753op/s ± 32923.465op/s 26559665.267op/s ± 22594.598op/s 26579425.339op/s 26596869.766op/s 26613758.267op/s 26619819.984op/s 0.23% -0.648 0.129 0.12% 2328.041op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.914µs 45.093µs ± 0.196µs 45.024µs ± 0.106µs 45.255µs 45.345µs 45.410µs 46.543µs 3.37% 2.199 12.878 0.43% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21485333.634op/s 22176861.450op/s ± 95591.804op/s 22210390.391op/s ± 52294.949op/s 22260939.768op/s 22263406.501op/s 22264179.205op/s 22264535.835op/s 0.24% -2.074 11.638 0.43% 6759.361op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [532.913µs; 533.050µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1875998.708op/s; 1876479.555op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.788µs; 381.860µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2618763.718op/s; 2619253.250op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.301µs; 189.368µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5280745.240op/s; 5282605.068op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.652µs; 37.665µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26549613.877op/s; 26558739.628op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.066µs; 45.120µs] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22163613.346op/s; 22190109.555op/s] or [-0.060%; +0.060%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6de2323 1749154014 dsn/remove-sh-builders
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.364µs 204.983µs ± 0.424µs 204.906µs ± 0.312µs 205.286µs 205.756µs 206.077µs 206.137µs 0.60% 0.648 -0.347 0.21% 0.030µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4851152.227op/s 4878484.255op/s ± 10070.446op/s 4880292.369op/s ± 7422.266op/s 4886898.512op/s 4891783.342op/s 4892729.569op/s 4893220.020op/s 0.26% -0.640 -0.362 0.21% 712.088op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.654µs 18.834µs ± 0.092µs 18.835µs ± 0.062µs 18.895µs 18.977µs 19.061µs 19.168µs 1.77% 0.428 0.352 0.49% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52170468.332op/s 53095835.733op/s ± 258135.368op/s 53093733.683op/s ± 175035.913op/s 53295045.212op/s 53480428.325op/s 53588760.765op/s 53607780.942op/s 0.97% -0.397 0.282 0.48% 18252.927op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.749µs 10.827µs ± 0.025µs 10.824µs ± 0.016µs 10.844µs 10.870µs 10.891µs 10.925µs 0.93% 0.363 1.000 0.23% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 91535035.559op/s 92359610.144op/s ± 216350.085op/s 92384616.251op/s ± 139113.263op/s 92501532.720op/s 92672115.220op/s 92852739.747op/s 93030786.799op/s 0.70% -0.343 0.975 0.23% 15298.261op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [204.924µs; 205.041µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4877088.588op/s; 4879879.922op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.822µs; 18.847µs] or [-0.068%; +0.068%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53060060.654op/s; 53131610.813op/s] or [-0.067%; +0.067%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.824µs; 10.831µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good throughput [92329626.103op/s; 92389594.185op/s] or [-0.032%; +0.032%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.98%. Comparing base (de39cc6) to head (6de2323).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   70.95%   70.98%   +0.02%     
==========================================
  Files         334      334              
  Lines       50549    50549              
==========================================
+ Hits        35868    35882      +14     
+ Misses      14681    14667      -14     
Components Coverage Δ
datadog-crashtracker 44.38% <ø> (ø)
datadog-crashtracker-ffi 6.03% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.43% <ø> (ø)
data-pipeline-ffi 89.26% <ø> (ø)
ddcommon 79.07% <ø> (ø)
ddcommon-ffi 68.64% <ø> (ø)
ddtelemetry 60.56% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.17% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 42.32% <ø> (ø)
datdog-sidecar-ffi 10.36% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.16% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.44% <ø> (ø)
datadog-log 66.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gleocadie
Copy link
Contributor

build-profiling-ffi.sh is still used https://github.com/DataDog/libddprof-build/blob/main/.gitlab-ci.yml#L211

taegyunkim
taegyunkim previously approved these changes Jun 5, 2025
@taegyunkim taegyunkim dismissed their stale review June 5, 2025 21:58

the file is still used as noted by gregorie

Copy link
Contributor

@paullegranddc paullegranddc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok config and telemetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants