Skip to content

feat(logging): log file rotation #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2025
Merged

feat(logging): log file rotation #1088

merged 4 commits into from
Jun 9, 2025

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 3, 2025 •
edited
Loading

What does this PR do?

Fixes https://datadoghq.atlassian.net/browse/APMSP-1835

This pull request introduces support for log file rotation. Key changes include adding configuration options for log file size limits and maximum file retention, implementing a custom file appender for rotation, and adding tests to validate the new functionality.

Motivation

Tracers already have this feature and we want to respect the configs set.

Additional Notes

This builds on top of #1018

How to test the change?

Added test cases to cover different cases.

@r1viollet
Copy link
Contributor

r1viollet commented Jun 3, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.17 MB 21.99 MB --.79% (-179.68 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 70.23 MB 69.88 MB --.51% (-367.34 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.16 MB 9.14 MB --.11% (-11.20 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 81.89 MB 81.60 MB --.35% (-294.08 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 26.03 MB 25.88 MB --.57% (-154.21 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.08 MB 9.06 MB --.11% (-10.92 KB) 💪
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 15.99 MB 15.99 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.65 KB 62.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 108.94 MB 108.94 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 577.71 MB 577.71 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.00 MB 5.00 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.65 KB 62.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.53 MB 15.53 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 28.56 MB 28.56 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 13.55 MB 13.55 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.60 KB 63.60 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 110.53 MB 110.54 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 568.91 MB 568.91 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.78 MB 3.78 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.60 KB 63.60 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.51 MB 16.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 26.78 MB 26.78 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 62.87 MB 62.61 MB --.40% (-259.46 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.78 MB 9.76 MB --.24% (-24.67 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.98 MB 20.84 MB --.66% (-143.38 KB) 💪
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 76.88 MB 76.65 MB --.29% (-230.38 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.68 MB 9.66 MB --.25% (-24.85 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.97 MB 23.84 MB --.56% (-138.10 KB) 💪

@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-06-09 16:14:48

Comparing candidate commit 07fdfd6 in PR branch ganeshnj/feat/log-file-rotation with baseline commit d392660 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.890µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.920µs 3.920µs 0.25% -0.919 8.997 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255071198.482op/s 255677788.010op/s ± 210670.485op/s 255703822.777op/s ± 125746.298op/s 255807157.618op/s 255947406.445op/s 255979948.888op/s 257084968.140op/s 0.54% 0.945 9.163 0.08% 14896.653op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.755µs 78.695µs ± 0.850µs 78.617µs ± 0.644µs 79.259µs 80.141µs 80.710µs 81.005µs 3.04% 0.394 -0.435 1.08% 0.060µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12344896.740op/s 12708790.680op/s ± 136684.102op/s 12719910.989op/s ± 103931.291op/s 12824366.021op/s 12901714.150op/s 12954338.390op/s 13028484.440op/s 2.43% -0.349 -0.480 1.07% 9665.026op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 69.889µs 71.285µs ± 0.720µs 71.224µs ± 0.493µs 71.727µs 72.480µs 73.102µs 73.312µs 2.93% 0.413 -0.268 1.01% 0.051µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13640329.094op/s 14029564.780op/s ± 141210.401op/s 14040267.108op/s ± 97492.323op/s 14137396.595op/s 14246580.807op/s 14301621.918op/s 14308345.246op/s 1.91% -0.366 -0.315 1.00% 9985.083op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.919µs 3.921µs 0.25% -0.823 8.975 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255050106.823op/s 255674875.930op/s ± 193447.805op/s 255678113.957op/s ± 115621.667op/s 255799461.226op/s 255909228.827op/s 255980269.726op/s 256954425.811op/s 0.50% 0.847 9.119 0.08% 13678.825op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 66.886µs 68.379µs ± 0.673µs 68.313µs ± 0.439µs 68.754µs 69.640µs 69.941µs 70.158µs 2.70% 0.435 -0.276 0.98% 0.048µs 1 200
credit_card/is_card_number/378282246310005 throughput 14253622.165op/s 14625685.302op/s ± 143296.510op/s 14638492.742op/s ± 93993.177op/s 14731382.319op/s 14828903.897op/s 14888240.723op/s 14950792.061op/s 2.13% -0.390 -0.316 0.98% 10132.593op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.136µs 52.197µs ± 0.035µs 52.192µs ± 0.024µs 52.220µs 52.263µs 52.303µs 52.310µs 0.23% 0.678 0.273 0.07% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19116624.753op/s 19158150.897op/s ± 12752.488op/s 19159949.001op/s ± 8629.788op/s 19167846.897op/s 19175210.384op/s 19180240.037op/s 19180709.960op/s 0.11% -0.674 0.265 0.07% 901.737op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.026µs 6.034µs ± 0.005µs 6.034µs ± 0.002µs 6.036µs 6.039µs 6.047µs 6.073µs 0.65% 4.126 28.563 0.08% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 164671767.850op/s 165733642.755op/s ± 140720.861op/s 165740532.297op/s ± 60233.228op/s 165804514.028op/s 165895438.826op/s 165938730.255op/s 165940950.243op/s 0.12% -4.091 28.238 0.08% 9950.467op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.919µs 0.20% -1.011 8.317 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255163213.148op/s 255659696.269op/s ± 186114.137op/s 255670917.433op/s ± 117303.041op/s 255779828.888op/s 255898903.827op/s 255959374.395op/s 256889836.656op/s 0.48% 1.031 8.458 0.07% 13160.257op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.006µs 64.427µs ± 0.159µs 64.416µs ± 0.105µs 64.526µs 64.682µs 64.785µs 65.174µs 1.18% 0.813 2.158 0.25% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15343627.924op/s 15521521.842op/s ± 38194.871op/s 15524190.719op/s ± 25212.494op/s 15548447.183op/s 15574536.957op/s 15593556.935op/s 15623604.141op/s 0.64% -0.788 2.066 0.25% 2700.785op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.785µs 58.044µs ± 0.156µs 57.994µs ± 0.076µs 58.107µs 58.352µs 58.519µs 58.545µs 0.95% 1.232 1.143 0.27% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17080834.109op/s 17228560.899op/s ± 46028.516op/s 17243196.600op/s ± 22692.049op/s 17262227.657op/s 17277563.705op/s 17300675.384op/s 17305593.168op/s 0.36% -1.219 1.104 0.27% 3254.708op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.912µs 3.916µs 3.920µs 3.930µs 0.50% 1.152 10.541 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254456572.513op/s 255699158.135op/s ± 205154.714op/s 255721045.858op/s ± 112132.094op/s 255832054.111op/s 255917134.173op/s 255983113.741op/s 256755341.480op/s 0.40% -1.125 10.484 0.08% 14506.629op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.600µs 54.892µs ± 0.221µs 54.852µs ± 0.131µs 54.989µs 55.305µs 55.548µs 55.807µs 1.74% 1.136 1.233 0.40% 0.016µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17918781.507op/s 18218030.799op/s ± 72914.107op/s 18230815.877op/s ± 43526.947op/s 18274057.691op/s 18306201.592op/s 18312136.332op/s 18314906.502op/s 0.46% -1.113 1.145 0.40% 5155.806op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.134µs 52.216µs ± 0.053µs 52.210µs ± 0.029µs 52.239µs 52.298µs 52.386µs 52.559µs 0.67% 2.374 11.837 0.10% 0.004µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19026065.611op/s 19151359.467op/s ± 19505.046op/s 19153306.156op/s ± 10457.132op/s 19163276.456op/s 19175458.769op/s 19180347.088op/s 19181183.259op/s 0.15% -2.349 11.648 0.10% 1379.215op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.034µs ± 0.004µs 6.033µs ± 0.002µs 6.036µs 6.040µs 6.046µs 6.048µs 0.24% 0.799 1.147 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165344063.744op/s 165739121.144op/s ± 107330.977op/s 165748675.923op/s ± 64696.925op/s 165810906.224op/s 165897600.878op/s 165933392.527op/s 165935967.932op/s 0.11% -0.794 1.133 0.06% 7589.446op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255648591.107op/s; 255706984.913op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.577µs; 78.813µs] or [-0.150%; +0.150%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12689847.578op/s; 12727733.782op/s] or [-0.149%; +0.149%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.185µs; 71.385µs] or [-0.140%; +0.140%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14009994.377op/s; 14049135.184op/s] or [-0.139%; +0.139%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255648065.925op/s; 255701685.935op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.286µs; 68.473µs] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/378282246310005 throughput [14605825.784op/s; 14645544.821op/s] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.192µs; 52.202µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19156383.525op/s; 19159918.270op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.033µs; 6.034µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/x371413321323331 throughput [165714140.197op/s; 165753145.313op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255633902.640op/s; 255685489.899op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.405µs; 64.449µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15516228.401op/s; 15526815.284op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.022µs; 58.065µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17222181.789op/s; 17234940.008op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.910µs; 3.911µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255670725.665op/s; 255727590.605op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.861µs; 54.922µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18207925.605op/s; 18228135.993op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.208µs; 52.223µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19148656.255op/s; 19154062.679op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.033µs; 6.034µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165724246.103op/s; 165753996.185op/s] or [-0.009%; +0.009%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.988µs 5.063µs ± 0.047µs 5.047µs ± 0.033µs 5.107µs 5.139µs 5.142µs 5.146µs 1.96% 0.289 -1.388 0.92% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.057µs; 5.070µs] or [-0.127%; +0.127%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.470µs 35.028µs ± 0.910µs 34.611µs ± 0.088µs 34.749µs 36.899µs 36.936µs 39.224µs 13.33% 1.847 2.283 2.59% 0.064µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.902µs; 35.154µs] or [-0.360%; +0.360%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 532.150µs 532.955µs ± 0.386µs 532.961µs ± 0.285µs 533.231µs 533.599µs 533.927µs 534.069µs 0.21% 0.357 -0.319 0.07% 0.027µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1872418.678op/s 1876332.277op/s ± 1359.145op/s 1876309.588op/s ± 1002.854op/s 1877356.030op/s 1878314.272op/s 1878629.902op/s 1879169.615op/s 0.15% -0.354 -0.324 0.07% 96.106op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.561µs 380.202µs ± 0.275µs 380.168µs ± 0.167µs 380.352µs 380.713µs 380.902µs 381.145µs 0.26% 0.656 0.737 0.07% 0.019µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2623675.799op/s 2630179.589op/s ± 1898.102op/s 2630419.035op/s ± 1156.691op/s 2631395.141op/s 2632807.209op/s 2634045.674op/s 2634620.215op/s 0.16% -0.651 0.728 0.07% 134.216op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 188.834µs 189.592µs ± 0.262µs 189.610µs ± 0.174µs 189.747µs 190.017µs 190.159µs 190.340µs 0.39% -0.023 0.065 0.14% 0.019µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5253752.897op/s 5274492.418op/s ± 7282.019op/s 5273983.083op/s ± 4830.832op/s 5279342.892op/s 5285987.619op/s 5291694.409op/s 5295657.222op/s 0.41% 0.032 0.066 0.14% 514.916op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.452µs 37.687µs ± 0.062µs 37.689µs ± 0.032µs 37.719µs 37.788µs 37.839µs 37.887µs 0.53% -0.148 1.357 0.16% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26394384.899op/s 26534208.835op/s ± 43373.864op/s 26533176.010op/s ± 22335.039op/s 26556018.690op/s 26601765.287op/s 26630963.022op/s 26700839.528op/s 0.63% 0.164 1.373 0.16% 3066.995op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.980µs 45.116µs ± 0.118µs 45.099µs ± 0.047µs 45.151µs 45.223µs 45.300µs 46.306µs 2.68% 6.344 56.967 0.26% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21595704.266op/s 22165302.019op/s ± 56881.271op/s 22173477.661op/s ± 22904.123op/s 22193638.310op/s 22217033.736op/s 22224483.013op/s 22232156.304op/s 0.26% -6.200 55.019 0.26% 4022.113op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [532.901µs; 533.008µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1876143.912op/s; 1876520.641op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.164µs; 380.240µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2629916.530op/s; 2630442.648op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.556µs; 189.628µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5273483.200op/s; 5275501.636op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.679µs; 37.696µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26528197.634op/s; 26540220.035op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.100µs; 45.132µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22157418.822op/s; 22173185.216op/s] or [-0.036%; +0.036%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 252.488ns 261.720ns ± 12.387ns 255.024ns ± 1.614ns 266.303ns 290.590ns 294.291ns 297.215ns 16.54% 1.393 0.510 4.72% 0.876ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [260.003ns; 263.436ns] or [-0.656%; +0.656%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.265µs 204.826µs ± 0.325µs 204.736µs ± 0.184µs 205.019µs 205.494µs 205.696µs 205.907µs 0.57% 0.911 0.451 0.16% 0.023µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4856555.720op/s 4882209.252op/s ± 7738.693op/s 4884345.953op/s ± 4401.676op/s 4887748.400op/s 4891888.860op/s 4894853.973op/s 4895594.825op/s 0.23% -0.903 0.433 0.16% 547.208op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.604µs 18.738µs ± 0.069µs 18.731µs ± 0.046µs 18.780µs 18.849µs 18.907µs 19.018µs 1.54% 0.603 0.712 0.37% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52581014.867op/s 53368381.066op/s ± 196529.317op/s 53388821.557op/s ± 131779.515op/s 53496446.346op/s 53645160.276op/s 53716001.027op/s 53751807.860op/s 0.68% -0.577 0.639 0.37% 13896.721op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.838µs 10.905µs ± 0.027µs 10.902µs ± 0.016µs 10.920µs 10.954µs 10.973µs 10.989µs 0.80% 0.371 0.423 0.25% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90996235.118op/s 91705727.874op/s ± 230902.500op/s 91725357.478op/s ± 135136.651op/s 91853553.898op/s 92076530.169op/s 92225485.410op/s 92267686.166op/s 0.59% -0.353 0.410 0.25% 16327.272op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [204.781µs; 204.871µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4881136.743op/s; 4883281.760op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.728µs; 18.748µs] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53341143.992op/s; 53395618.139op/s] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.901µs; 10.908µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [91673727.008op/s; 91737728.739op/s] or [-0.035%; +0.035%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.146ms 8.165ms ± 0.009ms 8.164ms ± 0.006ms 8.171ms 8.181ms 8.195ms 8.196ms 0.39% 0.731 0.644 0.11% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.164ms; 8.167ms] or [-0.016%; +0.016%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.767µs 150.684µs ± 0.397µs 150.634µs ± 0.146µs 150.788µs 151.148µs 152.247µs 153.822µs 2.12% 3.430 21.679 0.26% 0.028µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.629µs; 150.739µs] or [-0.036%; +0.036%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.196µs 3.233µs ± 1.449µs 3.027µs ± 0.029µs 3.053µs 3.694µs 13.969µs 15.014µs 395.95% 7.400 55.744 44.71% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.032µs; 3.434µs] or [-6.212%; +6.212%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.817µs 25.319µs ± 9.722µs 18.054µs ± 0.179µs 34.342µs 43.677µs 52.689µs 71.205µs 294.39% 1.156 1.356 38.30% 0.687µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.972µs; 26.666µs] or [-5.321%; +5.321%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.108ms 72.542ms ± 0.115ms 72.537ms ± 0.048ms 72.583ms 72.718ms 72.906ms 73.047ms 0.70% 0.288 4.827 0.16% 0.008ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.526ms; 72.558ms] or [-0.022%; +0.022%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.302µs 2.371µs ± 0.025µs 2.366µs ± 0.006µs 2.375µs 2.432µs 2.436µs 2.450µs 3.51% 0.576 1.847 1.06% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.368µs; 2.375µs] or [-0.147%; +0.147%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 07fdfd6 1749485004 ganeshnj/feat/log-file-rotation
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 90.123µs 90.347µs ± 0.151µs 90.330µs ± 0.057µs 90.388µs 90.521µs 90.683µs 91.777µs 1.60% 5.073 42.349 0.17% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.326µs; 90.368µs] or [-0.023%; +0.023%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.09%. Comparing base (d392660) to head (07fdfd6).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
+ Coverage   70.94%   71.09%   +0.15%     
==========================================
  Files         334      334              
  Lines       50551    50842     +291     
==========================================
+ Hits        35862    36146     +284     
- Misses      14689    14696       +7
Components Coverage Δ
datadog-crashtracker 44.38% <ø> (+0.02%) ⬆️
datadog-crashtracker-ffi 6.03% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.43% <ø> (ø)
data-pipeline-ffi 89.26% <ø> (ø)
ddcommon 79.07% <ø> (ø)
ddcommon-ffi 68.64% <ø> (ø)
ddtelemetry 60.56% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.17% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 42.32% <ø> (ø)
datdog-sidecar-ffi 10.36% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.16% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.44% <ø> (ø)
datadog-log 76.41% <92.66%> (+10.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ganeshnj ganeshnj force-pushed the ganeshnj/feat/logging-ffi branch 2 times, most recently from af9b0d6 to 9c8bb42 Compare June 4, 2025 08:38
@ganeshnj ganeshnj force-pushed the ganeshnj/feat/log-file-rotation branch from 524dbd7 to 8eac3d6 Compare June 4, 2025 08:39
@ganeshnj ganeshnj force-pushed the ganeshnj/feat/logging-ffi branch 7 times, most recently from 1c04b9e to 997bcf2 Compare June 5, 2025 16:14
Base automatically changed from ganeshnj/feat/logging-ffi to main June 5, 2025 17:24
@ganeshnj ganeshnj force-pushed the ganeshnj/feat/log-file-rotation branch 2 times, most recently from 84200e7 to a8f0d20 Compare June 5, 2025 18:54
@ganeshnj ganeshnj marked this pull request as ready for review June 6, 2025 07:35
@ganeshnj ganeshnj requested review from a team as code owners June 6, 2025 07:35
@ganeshnj ganeshnj mentioned this pull request Jun 6, 2025
Draft
@ganeshnj ganeshnj force-pushed the ganeshnj/feat/log-file-rotation branch from c6dd890 to 4ae1f79 Compare June 8, 2025 20:53
ekump
ekump reviewed Jun 9, 2025
View reviewed changes
@ganeshnj ganeshnj merged commit 03a39ca into main Jun 9, 2025
36 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/feat/log-file-rotation branch June 9, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekump ekump ekump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganeshnj @r1viollet @codecov-commenter @ekump