-
Notifications
You must be signed in to change notification settings - Fork 13
feat(logging): log file rotation #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
BenchmarksComparisonBenchmark execution time: 2025-06-09 16:14:48 Comparing candidate commit 07fdfd6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
+ Coverage 70.94% 71.09% +0.15%
==========================================
Files 334 334
Lines 50551 50842 +291
==========================================
+ Hits 35862 36146 +284
- Misses 14689 14696 +7
🚀 New features to boost your workflow:
|
af9b0d6
to
9c8bb42
Compare
524dbd7
to
8eac3d6
Compare
1c04b9e
to
997bcf2
Compare
84200e7
to
a8f0d20
Compare
c6dd890
to
4ae1f79
Compare
What does this PR do?
Fixes https://datadoghq.atlassian.net/browse/APMSP-1835
This pull request introduces support for log file rotation. Key changes include adding configuration options for log file size limits and maximum file retention, implementing a custom file appender for rotation, and adding tests to validate the new functionality.
Motivation
Tracers already have this feature and we want to respect the configs set.
Additional Notes
This builds on top of #1018
How to test the change?
Added test cases to cover different cases.