Skip to content

[APMSP-1976] Add check of parsed config and return action needed for tracer flare #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 11, 2025

Conversation

anais-raison
Copy link
Contributor

@anais-raison anais-raison commented Jun 3, 2025

What does this PR do?

This PR add a function that check the config received by the listener of RemoteConfig. This way it returns, through an enum, which action have to be done by the tracer flare depending of the config.

Motivation

What inspired you to submit this pull request?

Additional Notes

Also I updated the CODEOWNER file because of the crate datadog-dynamic-configuration was remove in my previous PR.

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-06-11 16:06:32

Comparing candidate commit aad6494 in PR branch anais/check-config-tracer-flare with baseline commit c546b28 in branch main.

Found 0 performance improvements and 14 performance regressions! Performance is the same for 38 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+3.714µs; +3.856µs] or [+5.161%; +5.358%]
  • 🟥 throughput [-707463.205op/s; -681671.165op/s] or [-5.090%; -4.905%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+14.283µs; +14.432µs] or [+20.681%; +20.897%]
  • 🟥 throughput [-2505580.047op/s; -2478772.424op/s] or [-17.304%; -17.119%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+7.295µs; +7.333µs] or [+15.995%; +16.080%]
  • 🟥 throughput [-3039504.238op/s; -3021847.443op/s] or [-13.862%; -13.781%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+3.129µs; +3.321µs] or [+5.055%; +5.366%]
  • 🟥 throughput [-826951.016op/s; -776992.391op/s] or [-5.118%; -4.809%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟥 execution_time [+4.175µs; +4.209µs] or [+7.707%; +7.770%]
  • 🟥 throughput [-1331134.302op/s; -1320655.366op/s] or [-7.211%; -7.154%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+5.169µs; +5.235µs] or [+10.237%; +10.367%]
  • 🟥 throughput [-1860614.675op/s; -1838699.900op/s] or [-9.394%; -9.284%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+7.241µs; +7.291µs] or [+15.856%; +15.966%]
  • 🟥 throughput [-3017967.743op/s; -2994570.109op/s] or [-13.782%; -13.675%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.978µs 5.046µs ± 0.040µs 5.044µs ± 0.030µs 5.074µs 5.108µs 5.111µs 5.124µs 1.59% 0.306 -1.234 0.79% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.041µs; 5.052µs] or [-0.110%; +0.110%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.225µs 3.283µs ± 1.464µs 3.053µs ± 0.026µs 3.080µs 3.740µs 13.947µs 15.691µs 414.05% 7.348 55.466 44.49% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.080µs; 3.485µs] or [-6.182%; +6.182%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 532.238µs 532.980µs ± 0.551µs 532.884µs ± 0.286µs 533.205µs 533.716µs 533.904µs 538.485µs 1.05% 5.131 47.864 0.10% 0.039µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1857061.942op/s 1876245.619op/s ± 1930.620op/s 1876581.848op/s ± 1006.327op/s 1877320.216op/s 1878249.046op/s 1878527.069op/s 1878858.914op/s 0.12% -5.059 46.895 0.10% 136.515op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.819µs 380.432µs ± 0.326µs 380.415µs ± 0.263µs 380.689µs 381.020µs 381.191µs 381.323µs 0.24% 0.364 -0.598 0.09% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2622445.396op/s 2628590.731op/s ± 2253.130op/s 2628709.173op/s ± 1815.119op/s 2630466.191op/s 2631922.076op/s 2632260.712op/s 2632834.514op/s 0.16% -0.361 -0.602 0.09% 159.320op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 188.758µs 189.403µs ± 0.489µs 189.348µs ± 0.162µs 189.536µs 189.894µs 190.129µs 195.144µs 3.06% 8.181 93.560 0.26% 0.035µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5124427.674op/s 5279779.803op/s ± 13341.537op/s 5281273.519op/s ± 4531.705op/s 5285131.489op/s 5292080.939op/s 5296947.395op/s 5297776.469op/s 0.31% -7.962 90.144 0.25% 943.389op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.559µs 37.859µs ± 0.189µs 37.938µs ± 0.175µs 38.028µs 38.113µs 38.169µs 38.192µs 0.67% -0.028 -1.648 0.50% 0.013µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26183351.943op/s 26414224.963op/s ± 131623.158op/s 26359031.033op/s ± 121368.263op/s 26546860.219op/s 26589892.260op/s 26601418.875op/s 26624919.633op/s 1.01% 0.033 -1.651 0.50% 9307.163op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.083µs 45.227µs ± 0.071µs 45.219µs ± 0.029µs 45.254µs 45.313µs 45.349µs 45.931µs 1.58% 4.839 45.654 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21771846.052op/s 22110753.087op/s ± 34627.393op/s 22114790.754op/s ± 14286.041op/s 22127009.155op/s 22153819.979op/s 22169924.962op/s 22181135.092op/s 0.30% -4.726 44.213 0.16% 2448.526op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [532.903µs; 533.056µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1875978.054op/s; 1876513.185op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.387µs; 380.477µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2628278.469op/s; 2628902.993op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.335µs; 189.471µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5277930.795op/s; 5281628.812op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.833µs; 37.885µs] or [-0.069%; +0.069%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26395983.260op/s; 26432466.667op/s] or [-0.069%; +0.069%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.217µs; 45.237µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22105954.063op/s; 22115552.111op/s] or [-0.022%; +0.022%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 72.157ms 72.537ms ± 0.228ms 72.516ms ± 0.179ms 72.695ms 72.918ms 73.047ms 73.220ms 0.97% 0.507 -0.551 0.31% 0.016ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [72.506ms; 72.569ms] or [-0.044%; +0.044%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.919µs 3.940µs 0.71% 2.150 22.519 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 253815827.026op/s 255599750.489op/s ± 222712.855op/s 255626534.034op/s ± 106301.033op/s 255720968.819op/s 255847673.342op/s 255937900.992op/s 256742684.667op/s 0.44% -2.098 22.185 0.09% 15748.177op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 80.325µs 81.718µs ± 0.637µs 81.678µs ± 0.397µs 82.043µs 82.629µs 83.165µs 86.082µs 5.39% 1.753 9.918 0.78% 0.045µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11616831.561op/s 12237972.328op/s ± 94245.474op/s 12243148.939op/s ± 59705.856op/s 12303504.655op/s 12366107.057op/s 12417030.672op/s 12449472.097op/s 1.69% -1.558 8.409 0.77% 6664.161op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 75.055µs 75.740µs ± 0.343µs 75.699µs ± 0.106µs 75.833µs 76.027µs 76.236µs 79.784µs 5.40% 8.184 95.193 0.45% 0.024µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12533801.212op/s 13203303.190op/s ± 57688.218op/s 13210281.715op/s ± 18407.637op/s 13224667.343op/s 13246824.749op/s 13302265.525op/s 13323620.114op/s 0.86% -7.780 89.111 0.44% 4079.173op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.912µs ± 0.004µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.921µs 3.955µs 1.11% 4.774 47.012 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 252872631.112op/s 255648545.162op/s ± 282803.235op/s 255688736.920op/s ± 107818.466op/s 255787690.422op/s 255896337.745op/s 255947035.257op/s 256798300.652op/s 0.43% -4.687 46.018 0.11% 19997.209op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 82.276µs 83.422µs ± 0.375µs 83.422µs ± 0.255µs 83.682µs 84.012µs 84.138µs 84.267µs 1.01% -0.386 0.164 0.45% 0.027µs 1 200
credit_card/is_card_number/378282246310005 throughput 11866985.335op/s 11987433.060op/s ± 53963.432op/s 11987280.297op/s ± 36704.834op/s 12021674.508op/s 12078345.270op/s 12142278.319op/s 12154191.722op/s 1.39% 0.414 0.204 0.45% 3815.791op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.758µs 52.919µs ± 0.061µs 52.918µs ± 0.039µs 52.955µs 53.018µs 53.082µs 53.103µs 0.35% 0.158 0.271 0.12% 0.004µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18831449.115op/s 18896733.902op/s ± 21810.200op/s 18897161.646op/s ± 13992.804op/s 18911576.089op/s 18931657.379op/s 18950172.421op/s 18954480.814op/s 0.30% -0.150 0.267 0.12% 1542.214op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.427µs 6.440µs ± 0.006µs 6.440µs ± 0.005µs 6.445µs 6.452µs 6.454µs 6.463µs 0.37% 0.444 -0.156 0.10% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154714960.847op/s 155268102.836op/s ± 156397.140op/s 155284021.338op/s ± 109479.953op/s 155379771.977op/s 155487570.102op/s 155548353.407op/s 155598266.317op/s 0.20% -0.439 -0.164 0.10% 11058.948op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.918µs 3.921µs 3.922µs 0.26% -0.222 5.945 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254993345.332op/s 255611856.933op/s ± 204942.754op/s 255645044.663op/s ± 110096.407op/s 255747048.159op/s 255846934.507op/s 255892050.908op/s 256831687.725op/s 0.46% 0.241 6.039 0.08% 14491.641op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.915µs 65.121µs ± 0.136µs 65.079µs ± 0.068µs 65.185µs 65.429µs 65.528µs 65.733µs 1.00% 1.546 2.637 0.21% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15213067.907op/s 15356011.256op/s ± 31937.515op/s 15365824.870op/s ± 15980.762op/s 15378150.350op/s 15388554.916op/s 15394298.772op/s 15404806.300op/s 0.25% -1.532 2.574 0.21% 2258.323op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.208µs 58.363µs ± 0.097µs 58.347µs ± 0.047µs 58.401µs 58.542µs 58.727µs 58.792µs 0.76% 1.648 3.804 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17009061.380op/s 17134097.912op/s ± 28421.549op/s 17138968.135op/s ± 13875.956op/s 17152101.043op/s 17166746.484op/s 17176513.423op/s 17179815.435op/s 0.24% -1.633 3.739 0.17% 2009.707op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.918µs 3.920µs 3.921µs 0.24% -0.400 7.099 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255018964.791op/s 255614893.479op/s ± 189439.213op/s 255636760.568op/s ± 94921.890op/s 255726463.131op/s 255839184.054op/s 255896143.751op/s 256789061.750op/s 0.45% 0.420 7.205 0.07% 13395.375op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 55.335µs 55.692µs ± 0.218µs 55.637µs ± 0.138µs 55.822µs 56.075µs 56.294µs 56.367µs 1.31% 0.779 0.072 0.39% 0.015µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17740936.205op/s 17956013.408op/s ± 70132.767op/s 17973553.722op/s ± 44514.703op/s 18006033.850op/s 18051338.376op/s 18067286.804op/s 18071614.193op/s 0.55% -0.762 0.036 0.39% 4959.136op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.770µs 52.932µs ± 0.059µs 52.931µs ± 0.038µs 52.971µs 53.028µs 53.053µs 53.099µs 0.32% -0.172 0.097 0.11% 0.004µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18832656.778op/s 18892294.675op/s ± 21094.637op/s 18892542.994op/s ± 13708.469op/s 18906040.759op/s 18926417.878op/s 18945434.579op/s 18950334.962op/s 0.31% 0.179 0.100 0.11% 1491.616op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.432µs 6.443µs ± 0.006µs 6.443µs ± 0.004µs 6.447µs 6.454µs 6.457µs 6.461µs 0.29% 0.417 -0.070 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154768185.561op/s 155210686.842op/s ± 146536.137op/s 155218867.098op/s ± 99312.895op/s 155318075.141op/s 155438477.031op/s 155480258.370op/s 155484093.166op/s 0.17% -0.412 -0.078 0.09% 10361.670op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ throughput [255568884.629op/s; 255630616.349op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.629µs; 81.806µs] or [-0.108%; +0.108%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12224910.812op/s; 12251033.844op/s] or [-0.107%; +0.107%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [75.693µs; 75.788µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13195308.158op/s; 13211298.222op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [255609351.353op/s; 255687738.970op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [83.370µs; 83.474µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/378282246310005 throughput [11979954.247op/s; 11994911.872op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.911µs; 52.928µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18893711.218op/s; 18899756.586op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.440µs; 6.441µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/x371413321323331 throughput [155246427.696op/s; 155289777.975op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255583453.839op/s; 255640260.028op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.103µs; 65.140µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15351585.024op/s; 15360437.489op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.350µs; 58.377µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17130158.959op/s; 17138036.865op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255588639.026op/s; 255641147.932op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.662µs; 55.723µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17946293.681op/s; 17965733.135op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.924µs; 52.940µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18889371.162op/s; 18895218.189op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.442µs; 6.444µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155190378.343op/s; 155230995.342op/s] or [-0.013%; +0.013%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.832µs 205.399µs ± 0.333µs 205.361µs ± 0.229µs 205.589µs 205.991µs 206.349µs 206.756µs 0.68% 0.799 0.869 0.16% 0.024µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4836609.526op/s 4868582.601op/s ± 7880.376op/s 4869470.872op/s ± 5439.251op/s 4874906.924op/s 4879451.985op/s 4880645.013op/s 4882038.085op/s 0.26% -0.788 0.833 0.16% 557.227op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.628µs 18.706µs ± 0.048µs 18.700µs ± 0.038µs 18.738µs 18.779µs 18.828µs 18.920µs 1.18% 0.782 1.165 0.26% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52854809.183op/s 53459147.385op/s ± 138021.389op/s 53476420.525op/s ± 107544.374op/s 53583443.903op/s 53636891.473op/s 53669101.328op/s 53683067.905op/s 0.39% -0.763 1.087 0.26% 9759.586op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.865µs 10.950µs ± 0.041µs 10.943µs ± 0.025µs 10.974µs 11.022µs 11.074µs 11.106µs 1.49% 0.987 1.269 0.37% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90042842.522op/s 91322415.425op/s ± 337282.906op/s 91382746.920op/s ± 206142.370op/s 91548980.803op/s 91758924.370op/s 91884305.852op/s 92042600.969op/s 0.72% -0.961 1.196 0.37% 23849.503op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.353µs; 205.445µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4867490.457op/s; 4869674.745op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.699µs; 18.713µs] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53440018.948op/s; 53478275.822op/s] or [-0.036%; +0.036%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.945µs; 10.956µs] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/good throughput [91275671.259op/s; 91369159.592op/s] or [-0.051%; +0.051%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 150.263µs 151.420µs ± 1.245µs 151.321µs ± 0.137µs 151.481µs 151.889µs 152.061µs 168.506µs 11.36% 13.026 176.425 0.82% 0.088µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [151.247µs; 151.592µs] or [-0.114%; +0.114%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.326ms 8.347ms ± 0.011ms 8.345ms ± 0.007ms 8.353ms 8.362ms 8.382ms 8.398ms 0.63% 1.295 3.684 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.345ms; 8.348ms] or [-0.018%; +0.018%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.121µs 89.480µs ± 0.209µs 89.475µs ± 0.085µs 89.559µs 89.646µs 89.687µs 91.901µs 2.71% 7.705 88.302 0.23% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.451µs; 89.508µs] or [-0.032%; +0.032%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.035µs 26.160µs ± 9.790µs 18.319µs ± 0.216µs 34.622µs 44.465µs 44.924µs 71.253µs 288.95% 0.936 0.693 37.33% 0.692µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.803µs; 27.516µs] or [-5.187%; +5.187%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.716µs 33.501µs ± 0.967µs 32.920µs ± 0.092µs 34.587µs 35.362µs 35.859µs 36.287µs 10.23% 1.067 -0.484 2.88% 0.068µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.366µs; 33.635µs] or [-0.400%; +0.400%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.079ns 253.856ns ± 12.145ns 249.322ns ± 3.799ns 257.573ns 283.448ns 289.945ns 300.930ns 20.70% 1.846 2.902 4.77% 0.859ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.173ns; 255.540ns] or [-0.663%; +0.663%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz aad6494 1749657306 anais/check-config-tracer-flare
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.405µs 2.442µs ± 0.018µs 2.438µs ± 0.006µs 2.445µs 2.498µs 2.506µs 2.510µs 2.97% 2.251 5.283 0.75% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.439µs; 2.444µs] or [-0.105%; +0.105%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 91.24088% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (c546b28) to head (aad6494).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   70.98%   71.02%   +0.03%     
==========================================
  Files         335      335              
  Lines       51021    51170     +149     
==========================================
+ Hits        36218    36342     +124     
- Misses      14803    14828      +25     
Components Coverage Δ
datadog-crashtracker 44.42% <ø> (ø)
datadog-crashtracker-ffi 6.03% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 89.21% <ø> (-0.14%) ⬇️
data-pipeline-ffi 88.94% <ø> (ø)
ddcommon 78.91% <ø> (ø)
ddcommon-ffi 68.64% <ø> (ø)
ddtelemetry 60.15% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.17% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 41.02% <ø> (-1.08%) ⬇️
datdog-sidecar-ffi 2.04% <ø> (-8.33%) ⬇️
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.07% <ø> (-0.16%) ⬇️
datadog-tracer-flare 60.47% <91.24%> (+60.47%) ⬆️
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

r1viollet commented Jun 3, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.16 MB 9.16 MB -0% (-288 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 69.95 MB 69.93 MB --.02% (-17.45 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 21.99 MB 21.98 MB --.01% (-3.90 KB) 💪
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.08 MB 9.08 MB +.01% (+1.34 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 25.88 MB 26.03 MB +.56% (+149.46 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 81.67 MB 82.11 MB +.54% (+454.67 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.02 MB 16.02 MB -0% (-1.00 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 62.65 KB 62.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 109.12 MB 109.12 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 584.33 MB 584.35 MB +0% (+21.02 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.01 MB 5.01 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 62.65 KB 62.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 15.54 MB 15.54 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 28.58 MB 28.58 MB -0% (-1.10 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 13.58 MB 13.58 MB +0% (+1.00 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 63.60 KB 63.60 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 110.89 MB 110.90 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 575.07 MB 575.10 MB +0% (+27.19 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.78 MB 3.78 MB --.03% (-1.50 KB) 💪
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 63.60 KB 63.60 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.51 MB 16.51 MB --.04% (-8.00 KB) 💪
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 26.79 MB 26.78 MB --.03% (-8.99 KB) 💪
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 62.68 MB 62.69 MB +.01% (+9.91 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.80 MB 9.80 MB --.06% (-7.01 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.83 MB 20.84 MB +.02% (+4.52 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 76.72 MB 77.12 MB +.52% (+408.90 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.70 MB 9.70 MB --.02% (-2.63 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.84 MB 23.97 MB +.54% (+132.53 KB) 🔍

@anais-raison anais-raison marked this pull request as ready for review June 4, 2025 11:31
@anais-raison anais-raison requested a review from a team as a code owner June 4, 2025 11:31
Copy link
Contributor

@hoolioh hoolioh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the crate to the .codecov file so we can the code coverage report.

@anais-raison anais-raison requested review from a team as code owners June 10, 2025 13:28
@anais-raison anais-raison enabled auto-merge (squash) June 11, 2025 15:26
@anais-raison anais-raison force-pushed the anais/check-config-tracer-flare branch from deaf87d to aad6494 Compare June 11, 2025 15:55
@anais-raison anais-raison merged commit e8cd69c into main Jun 11, 2025
36 checks passed
@anais-raison anais-raison deleted the anais/check-config-tracer-flare branch June 11, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants