-
Notifications
You must be signed in to change notification settings - Fork 13
[APMSP-1976] Add check of parsed config and return action needed for tracer flare #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksComparisonBenchmark execution time: 2025-06-11 16:06:32 Comparing candidate commit aad6494 in PR branch Found 0 performance improvements and 14 performance regressions! Performance is the same for 38 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 70.98% 71.02% +0.03%
==========================================
Files 335 335
Lines 51021 51170 +149
==========================================
+ Hits 36218 36342 +124
- Misses 14803 14828 +25
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add the crate to the .codecov file so we can the code coverage report.
Co-authored-by: Edmund Kump <[email protected]>
deaf87d
to
aad6494
Compare
What does this PR do?
This PR add a function that check the config received by the listener of RemoteConfig. This way it returns, through an enum, which action have to be done by the tracer flare depending of the config.
Motivation
What inspired you to submit this pull request?
Additional Notes
Also I updated the CODEOWNER file because of the crate
datadog-dynamic-configuration
was remove in my previous PR.How to test the change?
Describe here in detail how the change can be validated.