[APMSP-1976] Add check of parsed config and return action needed for tracer flare #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-06-06 10:09:13 Comparing candidate commit 26e5ac3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 70.94% 70.95% +0.01%
==========================================
Files 334 334
Lines 50549 50584 +35
==========================================
+ Hits 35860 35893 +33
- Misses 14689 14691 +2
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
ekump
reviewed
Jun 4, 2025
| @@ -186,6 +219,7 @@ pub async fn run_remote_config_listener( | |||
| Change::Add(file) => { | |||
| println!("Added file: {} (version: {})", file.path(), file.version()); | |||
There was a problem hiding this comment.
Not sure if I asked this on a previous PR, but why are we printing to stdout here?
| /// * `Ok(ReturnAction::Stop)` - If AGENT_TASK with the right properties. | ||
| /// * `Ok(ReturnAction::None)` - Else. | ||
| /// * `FlareError(msg)` - If something fail. | ||
| pub fn check_remote_config_file(file: RemoteConfigFile) -> Result<ReturnAction, FlareError> { |
There was a problem hiding this comment.
Is this function covered by tests somewhere else? If not, anything preventing us from adding some?
ekump
reviewed
Jun 4, 2025
datadog-tracer-flare/src/lib.rs
Outdated
| "error" => ReturnAction::StartError, | ||
| "critical" => ReturnAction::StartCritical, | ||
| "off" => ReturnAction::StartOff, | ||
| _ => ReturnAction::None, |
There was a problem hiding this comment.
If we get an unknown log level is just setting it to None the appropriate action? Or should it be an error?
There was a problem hiding this comment.
I think an error would be the most appropriate. But it could be nice to launch the flare still with a default level.
Co-authored-by: Edmund Kump <[email protected]>
datadog-tracer-flare/src/lib.rs
Outdated
Comment on lines
44
to
50
| StartTrace = 0, | ||
| StartDebug = 1, | ||
| StartInfo = 2, | ||
| StartWarn = 3, | ||
| StartError = 4, | ||
| StartCritical = 5, | ||
| StartOff = 6, |
There was a problem hiding this comment.
Any reason to use explicit discriminants here ?
hoolioh
reviewed
Jun 6, 2025
| @@ -23,19 +23,22 @@ pub enum FlareError { | |||
| NoFlare(String), | |||
| /// Listening to the RemoteConfig failed. | |||
| ListeningError(String), | |||
| /// Parsing of config failed. | |||
| ParsingError(String), | |||
There was a problem hiding this comment.
It might be beneficial to implement Error trait for FlareError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add a function that check the config received by the listener of RemoteConfig. This way it returns, through an enum, which action have to be done by the tracer flare depending of the config.
Motivation
What inspired you to submit this pull request?
Additional Notes
Also I updated the CODEOWNER file because of the crate
datadog-dynamic-configurationwas remove in my previous PR.How to test the change?
Describe here in detail how the change can be validated.