SMPTNG-259: Improve block chunk generation by re-using block sizes freely #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottopell
changed the title
blt
approved these changes
Feb 29, 2024
Comment on lines
+788
to
+805
| // proptest todo - figure out how to express "block_byte_sizes members must be less than total_bytes" | ||
| // until then, the strategy is to set the max block size to the min total_bytes |
There was a problem hiding this comment.
You could write a strategy for this. https://proptest-rs.github.io/proptest/proptest/tutorial/higher-order.html. There's also https://docs.rs/proptest/latest/proptest/macro.prop_assume.html but that'll throw away a ton of cases, where if you build values that are less than total_bytes and glob them into a vec you're good.
scottopell
force-pushed
the
sopell/reuse-block-chunks-freely
branch
from
5866839 to
af06b2d
Compare
…to get closer to the requested total_bytes
…rate requested amount
scottopell
force-pushed
the
sopell/reuse-block-chunks-freely
branch
from
399ced4 to
29a6c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When generating the block chunks that will be filled with a payload, instead of attempting to maintain even weightings of the block sizes, freely re-use them as needed to provide more capacity in the block chunks.
This also provides useful warnings when the payload cannot be fulfilled as written, eg:
Motivation
User asked for a certain amount of data, lets try harder to fulfill their request.
Related issues
Additional Notes
Note currently based on #828