Signal shutdown, use runtime shutdown to stop #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the soft shutdown that we previously used in lading. We have known for some time that lading's shut down mechanism is faulty: singular tasks would hold the shutdown up for unknown reasons. We then used the runtime shutdown in addition to our soft mechanism. This commit removes the soft mechanism. We signal that all tasks _should_ shut down but no longer wait on them to do so, immediately moving to the runtime's shutdown mechanism. REF SMPTNG-94 Signed-off-by: Brian L. Troutwine <[email protected]>
GeorgeHahn
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes the soft shutdown that we previously used in lading. We have known for some time that lading's shut down mechanism is faulty: singular tasks would hold the shutdown up for unknown reasons. We then used the runtime shutdown in addition to our soft mechanism.
This commit removes the soft mechanism. We signal that all tasks should shut down but no longer wait on them to do so, immediately moving to the runtime's shutdown mechanism.
Related issues
REF SMPTNG-94