Ignore processes that exit mid poll #1175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At any point during the sampling loop, a process may no longer exist on the machine. If this is the case (assuming we dont want to calculate resource usage by these "dead processes") then we need to ensure that we "continue" and start reading from the next process we have in the list. It is vital that we continue before doing any operations on the dead process that could result in an uncaught error, crashing lading, and ruining the experiment run for the replicate.
Motivation
Initial investigation done in #1142
Related issues
Additional Notes
Any drawbacks from cleaning up the process_info map like this?
TODO: