-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: datadog csi driver check error #21930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+194
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Contributor
|
Thanks for fixing this. I tested it and it is working fine after the fix: Thank you |
adel121
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a configuration mismatch in the
datadog_csi_driverintegration's auto-discovery configuration that causes the check to fail when deployed via Kubernetes Autodiscovery.Problem
When the Datadog Agent attempts to auto-discover and configure the
datadog_csi_drivercheck in Kubernetes environments, it fails with the following error:Root Cause
The
datadog_csi_driverintegration usesOpenMetricsBaseCheckV2as its base class, which expects the configuration fieldopenmetrics_endpoint. However, theauto_conf.yamlfile was incorrectly configured with the legacy field nameprometheus_url:Before:
This mismatch occurred because:
check.py) correctly usesOpenMetricsBaseCheckV2spec.yaml) correctly usestemplate: instances/openmetricsopenmetrics_endpoint: str(required field)prometheus_urlfield nameSolution
Update
auto_conf.yamlto use the correct field nameopenmetrics_endpointto match the OpenMetrics V2 API:After:
Testing
The fix has been validated to ensure:
openmetrics_endpointReview checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged