Skip to content

Conversation

@jhoenzsch
Copy link

…discovery race condition

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 87.02290% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.02%. Comparing base (9201ff3) to head (26ae584).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jhoenzsch jhoenzsch force-pushed the jhoenzsch/spark-race-con branch 6 times, most recently from 019d77c to 90f535c Compare November 19, 2025 21:59
@jhoenzsch jhoenzsch force-pushed the jhoenzsch/spark-race-con branch from 90f535c to 26ae584 Compare November 19, 2025 22:02
if pod_phase is None:
return False

if pod_phase in ('failed', 'succeeded', 'unknown'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what happens if the pod is pending? Does autodiscovery pick up config from pending pods?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question - I have not seen an example of this, but I do not know for sure. I could do a bit of research to try to see.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more a of a nit more than anything feel free to timebox it and convert this into a PR.

@steveny91 steveny91 self-assigned this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants