Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Annotations v2 for control plane configuration #19344

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add Annotations v2 for control plane configuration #19344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions istio/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ Customize this file with any additional configurations. See the [sample istio.d/
##### Control plane configuration
To monitor the Istio control plane and report the `mixer`, `galley`, `pilot`, and `citadel` metrics, you must configure the Agent to monitor the `istiod` deployment. In Istio v1.5 or later, apply the following pod annotations for the deployment `istiod` in the `istio-system` namespace:

<!-- xxx tabs xxx -->
<!-- xxx tab "Annotations v1" xxx -->

```yaml
ad.datadoghq.com/discovery.checks: |
{
Expand All @@ -79,6 +82,26 @@ ad.datadoghq.com/discovery.checks: |
}
```

<!-- xxz tab xxx -->
<!-- xxx tab "Annotations v2" xxx -->

**Note**: Annotations v2 is supported for Agent v7.36+.

```yaml
ad.datadoghq.com/<CONTAINER_IDENTIFIER>.checks: |
{
"Istio": {
"istiod_endpoint": "http://%%host%%:15014/metrics",
"use_openmetrics": "true"
}
}
```

<!-- xxz tab xxx -->
<!-- xxz tabs xxx -->



This annotation specifies the container `discovery` to match the default container name of the Istio container in this pod. Replace this annotation `ad.datadoghq.com/<CONTAINER_NAME>.checks` with the name (`.spec.containers[i].name`) of your Istio container if yours differs.

The method for applying these annotations varies depending on the [Istio deployment strategy (Istioctl, Helm, Operator)][22] used. Consult the Istio documentation for the proper method to apply these pod annotations. See the [sample istio.d/conf.yaml][8] for all available configuration options.
Expand Down
Loading