[CONTP-60] New unscheduled config telemetry #19306
Conversation
gabedos
added
qa/skip-qa
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabedos
force-pushed
the
gabedos/add-cluster-check-telemetry
branch
from
25e13c5 to
895fb53
Compare
| datadog.cluster_agent.workloadmeta.notifications_sent,count,,,,Number of notifications sent by workloadmeta to its subscribers,0,datadog_cluster_agent,workloadmeta notifications sent, | ||
| datadog.cluster_agent.workloadmeta.stored_entities,gauge,,,,Number of entities stored in workloadmeta,0,datadog_cluster_agent,workloadmeta stored entities, | ||
| datadog.cluster_agent.workloadmeta.subscribers,gauge,,,,Number of workloadmeta subscribers,0,datadog_cluster_agent,workloadmeta subscribers, | ||
| metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric,sample_tags |
There was a problem hiding this comment.
question: which metrics are using sample_tags currently?
There was a problem hiding this comment.
My last commit complained for me to run ddev validate metadata datadog_cluster_agent --sync and it produced this sample tags field (I have no idea why). I can go an manually remove it.
There was a problem hiding this comment.
Ah just found this PR #17521; seems like--sync will automatically add the column, but for existing files it's fine with or without. Not sure if sample_tags should be added to all metadata.csv files going forward so can wait for agent-integrations to chime in before you make changes manually (I was mostly just curious how this column got added)!
What does this PR do?
Adds telemetry for cluster check configs that have been dangling longer than expected and are then classified as an unscheduled check.
This metric will follow the form
cluster_checks_unscheduled_check{config_name, config_source, join_leader}Motivation
Provide higher level of visibility into cluster check dispatching
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged