-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs for Quarkus #19293
base: master
Are you sure you want to change the base?
Add logs for Quarkus #19293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall things look good to me, I only had one minor request for the grok rule.
Note: do not be surprised, since we are under the EOY production freeze, approval won't happen before Thursday.
- "2024-12-13 11:05:38,618 INFO [org.acm.GreetingResource] (executor-thread-1) Custom log message" | ||
grok: | ||
matchRules: | | ||
quarkus %{date("yyyy-MM-dd HH:mm:ss,SSS"):timestamp}\s+%{word:level}\s+\[%{notSpace:logger}\]\s+\(%{data:thread}\)\s+%{data:message} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quarkus %{date("yyyy-MM-dd HH:mm:ss,SSS"):timestamp}\s+%{word:level}\s+\[%{notSpace:logger}\]\s+\(%{data:thread}\)\s+%{data:message} | |
quarkus %{date("yyyy-MM-dd HH:mm:ss,SSS"):timestamp}\s+%{word:level}\s+\[%{notSpace:logger}\]\s+\(%{regex("[^)]*"):thread}\)\s+%{data:message} |
Can I suggest this tweak to the thread parsing: since we know the delimiter, this will make things more efficient on the backend.
What does this PR do?
Here's the logs-core ticket: https://datadoghq.atlassian.net/browse/LOI-360
Note: I'll add documentation for how to enable logs when I write the Readme (later today). Keeping that separate to limit reviewer load.
Here's a screenshot of the pipeline in action:
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged