Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for Quarkus #19293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add logs for Quarkus #19293

wants to merge 2 commits into from

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Dec 20, 2024

What does this PR do?

Here's the logs-core ticket: https://datadoghq.atlassian.net/browse/LOI-360

Note: I'll add documentation for how to enable logs when I write the Readme (later today). Keeping that separate to limit reviewer load.

Here's a screenshot of the pipeline in action:
Screenshot 2024-12-19 at 03 08 34

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (926ba8e) to head (42ddce6).
Report is 19 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
quarkus 100.00% <ø> (ø)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@brunorenier brunorenier added the assets/deploy-logs-staging ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging label Dec 30, 2024
Copy link

@brunorenier brunorenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall things look good to me, I only had one minor request for the grok rule.

Note: do not be surprised, since we are under the EOY production freeze, approval won't happen before Thursday.

- "2024-12-13 11:05:38,618 INFO [org.acm.GreetingResource] (executor-thread-1) Custom log message"
grok:
matchRules: |
quarkus %{date("yyyy-MM-dd HH:mm:ss,SSS"):timestamp}\s+%{word:level}\s+\[%{notSpace:logger}\]\s+\(%{data:thread}\)\s+%{data:message}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
quarkus %{date("yyyy-MM-dd HH:mm:ss,SSS"):timestamp}\s+%{word:level}\s+\[%{notSpace:logger}\]\s+\(%{data:thread}\)\s+%{data:message}
quarkus %{date("yyyy-MM-dd HH:mm:ss,SSS"):timestamp}\s+%{word:level}\s+\[%{notSpace:logger}\]\s+\(%{regex("[^)]*"):thread}\)\s+%{data:message}

Can I suggest this tweak to the thread parsing: since we know the delimiter, this will make things more efficient on the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants