Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SAASINT-3470] DDSaaS: Okta Workflows: Crawler Integration Without Assets #19281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[SAASINT-3470] DDSaaS: Okta Workflows: Crawler Integration Without Assets #19281

wants to merge 3 commits into from
+96 −0

Conversation

DhruvaPatel-crest
Copy link
Contributor

What does this PR do?

PR includes skeleton of Okta Workflows integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

Additional Notes

Only crawler-based integration related changes are included in this PR

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@DhruvaPatel-crest DhruvaPatel-crest changed the title DDSaaS: Okta Workflows: Crawler Integration ithout Assets DDSaaS: Okta Workflows: Crawler Integration Without Assets Dec 18, 2024
@DhruvaPatel-crest DhruvaPatel-crest marked this pull request as ready for review December 18, 2024 12:06
@DhruvaPatel-crest DhruvaPatel-crest requested review from a team as code owners December 18, 2024 12:06
@DhruvaPatel-crest DhruvaPatel-crest changed the title DDSaaS: Okta Workflows: Crawler Integration Without Assets [SAASINT-3470] DDSaaS: Okta Workflows: Crawler Integration Without Assets Dec 18, 2024
rtrieu
rtrieu reviewed Dec 18, 2024
View reviewed changes
okta_workflows/README.md Outdated
## Overview
[Okta Workflows][1] is a no-code automation platform provided by Okta, designed to simplify and automate identity-related tasks and processes. It allows organizations to build custom workflows that integrate seamlessly with Okta's identity and access management capabilities and third-party applications, enhancing operational efficiency, security, and user experience.

The Okta Workflows integration collects okta workflow event logs and sends it into Datadog for comprehensive analysis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Okta Workflows integration collects okta workflow event logs and sends it into Datadog for comprehensive analysis.
The Okta Workflows integration collects Okta workflow event logs and sends it into Datadog for comprehensive analysis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changes as per suggestion.

@rtrieu
Copy link
Contributor

rtrieu commented Dec 18, 2024

Created DOCS-9776 for docs review.

@rtrieu rtrieu added the editorial review Waiting on a more in-depth review from a docs team editor label Dec 18, 2024
@drichards-87 drichards-87 requested a review from a team December 19, 2024 18:30
@drichards-87
Copy link
Contributor

Hi @DhruvaPatel-crest. I'll be handling the Docs Team review, so feel free to reach out when the PR is ready to reviewed. Thanks!

@rtrieu rtrieu removed their request for review December 23, 2024 17:08
@DhruvaPatel-crest
Copy link
Contributor Author

Hi @drichards-87 PR is ready for review.

1 similar comment
@DhruvaPatel-crest
Copy link
Contributor Author

Hi @drichards-87 PR is ready for review.

HadhemiDD
HadhemiDD previously approved these changes Dec 30, 2024
View reviewed changes
@drichards-87
Copy link
Contributor

Hi @DhruvaPatel-crest. The Setup, Configuration, and Validation sections still have placeholder content. Is that intentional?

drichards-87
drichards-87 requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions from Docs.

okta_workflows/README.md Outdated
## Overview
[Okta Workflows][1] is a no-code automation platform provided by Okta, designed to simplify and automate identity-related tasks and processes. It allows organizations to build custom workflows that integrate seamlessly with Okta's identity and access management capabilities and third-party applications, enhancing operational efficiency, security, and user experience.

The Okta Workflows integration collects Okta workflow event logs and sends it into Datadog for comprehensive analysis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Okta Workflows integration collects Okta workflow event logs and sends it into Datadog for comprehensive analysis.
The Okta Workflows integration collects Okta workflow event logs and sends them to Datadog for comprehensive analysis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changes as per suggestion.

okta_workflows/README.md Outdated

### Logs

The Okta Workflows integration collects and forwards okta workflow event logs to Datadog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Okta Workflows integration collects and forwards okta workflow event logs to Datadog.
The Okta Workflows integration collects and forwards Okta workflow event logs to Datadog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changes as per suggestion.

@DhruvaPatel-crest
Copy link
Contributor Author

Hi @DhruvaPatel-crest. The Setup, Configuration, and Validation sections still have placeholder content. Is that intentional?

Yes, this is intentional. Without assets PR, it contains the initial structure for crawler based integration. Once this PR is merged, we will raise a separate PR with the full assets.

@drichards-87
Copy link
Contributor

Hi @DhruvaPatel-crest. The Setup, Configuration, and Validation sections still have placeholder content. Is that intentional?

Yes, this is intentional. Without assets PR, it contains the initial structure for crawler based integration. Once this PR is merged, we will raise a separate PR with the full assets.

Understood. Thanks for the clarification.

@codecov Codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (724567b) to head (361179e).
Report is 53 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtrieu rtrieu rtrieu left review comments

@drichards-87 drichards-87 drichards-87 approved these changes

@HadhemiDD HadhemiDD HadhemiDD left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
agent/approved docs/approved ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DhruvaPatel-crest @rtrieu @drichards-87 @HadhemiDD