[PLINT-469] Add Octopus Deploy integration #18488

sarah-witt · 2024-09-03T16:38:23Z

What does this PR do?

Adds an integration for octopus deploy

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Changelog entries must be created for modifications to shipped code
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

github-actions · 2024-09-03T16:39:29Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

codecov · 2024-09-03T16:42:56Z

Codecov Report

Attention: Patch coverage is 99.16512% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.38%. Comparing base (bef0a2f) to head (20be232).
Report is 7 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
activemq	`?`
aerospike	`?`
airflow	`?`
appgate_sdp	`?`
cassandra	`?`
cassandra_nodetool	`?`
ceph	`?`
cilium	`?`
clickhouse	`?`
couchbase	`?`
dotnetclr	`?`
duckdb	`?`
elastic	`?`
exchange_server	`?`
gearmand	`?`
gitlab	`?`
glusterfs	`?`
haproxy	`?`
ibm_ace	`?`
ibm_was	`?`
iis	`?`
jboss_wildfly	`?`
kafka	`?`
kafka_consumer	`?`
keda	`?`
kubeflow	`?`
kubevirt_api	`?`
kubevirt_controller	`?`
kubevirt_handler	`?`
marklogic	`?`
milvus	`?`
mongo	`?`
mysql	`?`
nvidia_nim	`?`
octopus_deploy	`99.16% <99.16%> (?)`
openstack_controller	`?`
pdh_check	`?`
postgres	`?`
presto	`?`
quarkus	`?`
sap_hana	`?`
scylla	`?`
slurm	`?`
snmp	`?`
sonarqube	`?`
sqlserver	`?`
supabase	`?`
vault	`?`
vertica	`?`
voltdb	`?`
weblogic	`?`
windows_performance_counters	`?`
windows_service	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

github-actions · 2024-09-03T16:47:39Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2024-09-03T16:52:52Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2024-09-03T20:02:43Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2024-09-03T20:04:58Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

* Add support for pagination * update caddyfile and remove unneeded args * Apply suggestions

…nment, deployment, and release (#19192) * Add support for environment metrics * Add config for autodiscovery * Add support for environments via discovery * Add environment, release, and deployment tags * Add caching for environments, releases, and deployments * add to caddyfile * remove env fallback * change environments cache to dictionary * use tuple for deployment * Add pagination for environments * update caddyfile * update environments config * sync models * Filter by environment * only collect deploy tasks * update caddyfile

* Add support for machine metrics * add role tags * change to startswith * validate metadata * Address comments

* Add support for machine metrics * add role tags * change to startswith * validate metadata * Address comments * Add octopus server tag

michaelcretzman

Approved with some minor suggestions.
Typically, we avoid "will be" in favor of the present tense.

octopus_deploy/assets/configuration/spec.yaml

Stale Review dismissed by prbot

* Add scaffolding * add link to readme * clean up manifest * validate ci * validate models and config; * add labeler * remove dash * fix manifest * clean scaffolding and add base fixtures * add base code and test * fix changelog * update and validate config * add metric to check * Add mocks and make true unit tests * Add support for first level space autodiscovery * Add support fot project groups discovery * Add support for projects * remove spaces discovery and add it as configuration option * clean up code and tests * move initializations to check init * add support for task count metrics * refactor to reference project_group * submit project metrics in check method * Add handle_error wrapper and add more logging * bump python version * Add e2e test * lint * add http template to config spec * refactor test files and add caddy e2e * lint * fix tests * Add deployment duration metric * rename to seconds * Add queue time metric * Add deploy success metric * Add can rerun metric * add metric for has warnings or errors * sort readme * Sarah/add octopus server metrics (#18868) * Add support for server node metrics * add server node mocks * remove task id tag * update caddyfile * remove dead code * update codeowners * add e2e lab and update config * Address comments * Update projects logic and refactor (#19087) * Fix new deployment logic and support in progress and queued deployments * sync metadata * update caddyfile * fix * add to completed date * Refactor * fixed e2e tests * fixed instance fixture * fixed e2e test * added some e2e asserts * fixed lint error * all metrics asserted * Add test asserting metadata, add test and handle failure of tasks * store base tags * Don't report completed and executing metrics if no data * Add support for octopus server node metrics * remove unused constants * validate * lint * update e2e * update metadata * Use project name and project group name tags * Use space name instead of space id * Update log lines * update test instance * Update metric description --------- Co-authored-by: Jose Manuel Almaza <[email protected]> * Make assertions more specific * Add support for events (#19176) * [PLINT-484] Add support for deployment logs (#19152) * Add support for deployment logs * Add server node tag * add e2e_metrics * remove completed_time * Address comments * add extra assert * [PLINT-469] Add support for pagination in octopus integration (#19228) * Add support for pagination * update caddyfile and remove unneeded args * Apply suggestions * update config docs (#19243) * [PLINT-543] Add support for environment metrics and tagging by environment, deployment, and release (#19192) * Add support for environment metrics * Add config for autodiscovery * Add support for environments via discovery * Add environment, release, and deployment tags * Add caching for environments, releases, and deployments * add to caddyfile * remove env fallback * change environments cache to dictionary * use tuple for deployment * Add pagination for environments * update caddyfile * update environments config * sync models * Filter by environment * only collect deploy tasks * update caddyfile * Add support for waiting, queued, executing metrics (#19291) * support unified service tagging: (#19342) * fix headers for new year * [PLINT-542] Add machines metrics (#19285) * Add support for machine metrics * add role tags * change to startswith * validate metadata * Address comments * Add octopus server tag to all metrics, events, and logs (#19318) * Add support for machine metrics * add role tags * change to startswith * validate metadata * Address comments * Add octopus server tag * Add collect_events option * Update docs * dont use future tense in config --------- Co-authored-by: Jose Manuel Almaza <[email protected]> 5658647

This reverts commit 5658647.

sarah-witt added 3 commits August 21, 2024 13:58

Add scaffolding

26c34b0

add link to readme

8237b43

clean up manifest

87f6280

datadog-agent-integrations-bot bot added documentation release qa/skip-qa Automatically skip this PR for the next QA labels Sep 3, 2024

validate ci

152e2bd

datadog-agent-integrations-bot bot added dev/testing dev/tooling labels Sep 3, 2024

validate models and config;

fcf2fdc

add labeler

f77c3d7

datadog-agent-integrations-bot bot added the integration/octopus_deploy label Sep 3, 2024

sarah-witt added 4 commits September 3, 2024 13:23

remove dash

fc9e61c

fix manifest

23a6260

clean scaffolding and add base fixtures

f720cc9

add base code and test

c802b28

fix changelog

29c0191

update and validate config

a77d728

sarah-witt changed the title ~~Add Octopus Deploy integration~~ [PLINT-469] Add Octopus Deploy integration Sep 3, 2024

sarah-witt added 5 commits September 3, 2024 16:16

add metric to check

bbb52af

Add mocks and make true unit tests

c180bef

Add support for first level space autodiscovery

3c2c9fa

Add support fot project groups discovery

a7bf9b9

Add support for projects

1ba6632

sarah-witt added 11 commits December 9, 2024 13:32

[PLINT-469] Add support for pagination in octopus integration (#19228)

ea78cf3

* Add support for pagination * update caddyfile and remove unneeded args * Apply suggestions

update config docs (#19243)

e0312a0

Add support for waiting, queued, executing metrics (#19291)

7088354

support unified service tagging: (#19342)

0614959

fix headers for new year

b4ab224

[PLINT-542] Add machines metrics (#19285)

d215ee4

* Add support for machine metrics * add role tags * change to startswith * validate metadata * Address comments

Add octopus server tag to all metrics, events, and logs (#19318)

84fb139

* Add support for machine metrics * add role tags * change to startswith * validate metadata * Address comments * Add octopus server tag

Add collect_events option

7362e55

Merge branch 'master' into sarah/add-octopus-integration

c5edefa

Update docs

8a4a398

michaelcretzman previously approved these changes Jan 15, 2025

View reviewed changes

octopus_deploy/assets/configuration/spec.yaml Outdated Show resolved Hide resolved

octopus_deploy/assets/configuration/spec.yaml Outdated Show resolved Hide resolved

temporal-github-worker-1 bot added docs/approved and removed docs/review-requested labels Jan 15, 2025

dont use future tense in config

9797fc4

temporal-github-worker-1 bot added docs/review-requested and removed docs/approved labels Jan 16, 2025

Merge branch 'master' into sarah/add-octopus-integration

20be232

jose-manuel-almaza approved these changes Jan 16, 2025

View reviewed changes

Kyle-Neale approved these changes Jan 16, 2025

View reviewed changes

temporal-github-worker-1 bot added agent/approved and removed agent/review-requested labels Jan 16, 2025

sarah-witt added this pull request to the merge queue Jan 17, 2025

Merged via the queue into master with commit 5658647 Jan 17, 2025
42 of 43 checks passed

sarah-witt deleted the sarah/add-octopus-integration branch January 17, 2025 16:31

sabrina-datadog restored the sarah/add-octopus-integration branch January 17, 2025 19:13

sabrina-datadog added a commit that referenced this pull request Jan 17, 2025

Revert "[PLINT-469] Add Octopus Deploy integration (#18488)"

d291b28

This reverts commit 5658647.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PLINT-469] Add Octopus Deploy integration #18488

[PLINT-469] Add Octopus Deploy integration #18488

sarah-witt commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

codecov bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

michaelcretzman left a comment

[PLINT-469] Add Octopus Deploy integration #18488

[PLINT-469] Add Octopus Deploy integration #18488

Conversation

sarah-witt commented Sep 3, 2024

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

github-actions bot commented Sep 3, 2024

codecov bot commented Sep 3, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

github-actions bot commented Sep 3, 2024

michaelcretzman left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 3, 2024 •

edited

Loading