Skip to content

Commit

Permalink
feat(admission): add delete RBAC for datadog-webhook (#1651)
Browse files Browse the repository at this point in the history
Signed-off-by: Wassim DHIF <[email protected]>
  • Loading branch information
wdhif authored Dec 27, 2024
1 parent 2c09b7d commit 00764dc
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion charts/datadog/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Datadog changelog

## 3.86.0

* Add `delete` permission for `datadog-webhook` Admission Registration RBACs.

## 3.85.0

* Add `datadog.discovery.enabled` configuration to control service-discovery
* Add `datadog.discovery.enabled` configuration to control service-discovery.

## 3.84.4

Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: v1
name: datadog
version: 3.85.0
version: 3.86.0
appVersion: "7"
description: Datadog Agent
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Datadog

![Version: 3.85.0](https://img.shields.io/badge/Version-3.85.0-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)
![Version: 3.86.0](https://img.shields.io/badge/Version-3.86.0-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)

[Datadog](https://www.datadoghq.com/) is a hosted infrastructure monitoring platform. This chart adds the Datadog Agent to all nodes in your cluster via a DaemonSet. It also optionally depends on the [kube-state-metrics chart](https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics). For more information about monitoring Kubernetes with Datadog, please refer to the [Datadog documentation website](https://docs.datadoghq.com/agent/basic_agent_usage/kubernetes/).

Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/templates/cluster-agent-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ rules:
- mutatingwebhookconfigurations
resourceNames:
- {{ .Values.clusterAgent.admissionController.webhookName | quote }}
verbs: ["get", "list", "watch", "update"]
verbs: ["get", "list", "watch", "update", "delete"]
- apiGroups:
- admissionregistration.k8s.io
resources:
Expand Down

0 comments on commit 00764dc

Please sign in to comment.