Skip to content

[Debugger] Update Node.js docs #28626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

watson
Copy link
Contributor

@watson watson commented Apr 8, 2025

What does this PR do? What is the motivation?

The Node.js tracer now supports templates and conditions (from version 5.48.0), so these two items are now removed from the list of unsupported features

Merge instructions

Do not merge until version 5.48.0 have been released to npm: https://www.npmjs.com/package/dd-trace

I'll make sure to tick the "Ready for merge" check box below once it's ready.

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

The Node.js tracer now supports templates and conditions
@watson watson marked this pull request as ready for review April 8, 2025 12:19
@watson watson requested a review from a team as a code owner April 8, 2025 12:20
@watson watson requested review from sstonehill12 and a team and removed request for sstonehill12 April 8, 2025 12:22
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Preview links (active after the build_preview check completes)

Modified Files

@jhgilbert
Copy link
Contributor

Hi @watson, thanks for the update! The "ready for merge" checkbox isn't automated, so we won't be notified when you update that. Instead, you can merge the PR yourself anytime by commenting /merge (something only the docs team had permission to do before). Thanks again!

@watson
Copy link
Contributor Author

watson commented Apr 14, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 14, 2025

View all feedbacks in Devflow UI.

2025-04-14 12:59:12 UTC ℹ️ Start processing command /merge


2025-04-14 12:59:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 18m (p90).


2025-04-14 13:14:12 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 99cb43e into master Apr 14, 2025
20 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the watson/nodejs-docs-update branch April 14, 2025 13:14
estherk15 pushed a commit that referenced this pull request Apr 17, 2025
The Node.js tracer now supports templates and conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants