Skip to content

Update screenshots #28623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2025
Merged

Update screenshots #28623

merged 6 commits into from
Apr 16, 2025

Conversation

SimoneT-DD
Copy link
Contributor

What does this PR do? What is the motivation?

Updating screenshots

Merge instructions

Merge readiness:

  • Ready for merge

@SimoneT-DD SimoneT-DD requested a review from a team as a code owner April 8, 2025 07:36
@github-actions github-actions bot added the Images Images are added/removed with this PR label Apr 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Preview links (active after the build_preview check completes)

Modified Files

jhgilbert
jhgilbert reviewed Apr 8, 2025
View reviewed changes
static/images/monitors/notifications/notification_rules/settings_notification_rules.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SimoneT-DD, thanks for the update! This image should not be deleted, as translated versions of the docs tend to lag behind the English version, and will still need access to the file. Everything else looks good, so I can approve the PR once this image is restored. Thanks again!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would the same apply also for "notification_rules_config.png"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jhgilbert, I added back the two images I previously deleted

@SimoneT-DD SimoneT-DD requested a review from jhgilbert April 11, 2025 15:35
@estherk15
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 16, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-16 15:44:37 UTC ℹ️ Start processing command /merge

2025-04-16 15:44:46 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-16 16:05:21 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 18m (p90).

2025-04-16 16:22:19 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6804eb5 into master Apr 16, 2025
18 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the SimoneT-DD/update_notification_rule_screenshots branch April 16, 2025 16:22
estherk15 pushed a commit that referenced this pull request Apr 17, 2025
@SimoneT-DD @estherk15
Update screenshots (#28623)
98d5ddd 
* Update screenshots

* update image name

* Adding back the two images

* Crop out nav bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

@jhgilbert jhgilbert Awaiting requested review from jhgilbert

Assignees
No one assigned
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimoneT-DD @estherk15 @jhgilbert