Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fluent bit log collection to logs guide #26980

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Jan 6, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@estherk15 estherk15 requested a review from a team as a code owner January 6, 2025 15:55
@github-actions github-actions bot added the Guide Content impacting a guide label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

@estherk15 estherk15 force-pushed the esther/docs-9143-fluentbit-merge branch from 4cb2e41 to 9148d7f Compare January 6, 2025 16:28
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a suggestion to add an alias.

@@ -1,29 +1,19 @@
---
title: Fluent Bit
title: Send Fluent Bit Logs to Datadog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Send Fluent Bit Logs to Datadog
title: Send Fluent Bit Logs to Datadog
aliases:
- /integrations/fluentbit/

Seems like we should include an alias for user who might try to access the old location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integrations-extras doc will take this url. I wasn't sure there would be a way to alias this without changing the integration files, so I opted to reference out to the guide in the intro. Do you think it would be better to change it on the integration side?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha. I think it is fine the way you did it then!

@estherk15
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-06 18:29:15 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-06 18:35:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 04eec7e into master Jan 6, 2025
19 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the esther/docs-9143-fluentbit-merge branch January 6, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants