-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move fluent bit log collection to logs guide #26980
Conversation
Preview links (active after the
|
4cb2e41
to
9148d7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a suggestion to add an alias.
@@ -1,29 +1,19 @@ | |||
--- | |||
title: Fluent Bit | |||
title: Send Fluent Bit Logs to Datadog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Send Fluent Bit Logs to Datadog | |
title: Send Fluent Bit Logs to Datadog | |
aliases: | |
- /integrations/fluentbit/ |
Seems like we should include an alias for user who might try to access the old location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integrations-extras doc will take this url. I wasn't sure there would be a way to alias this without changing the integration files, so I opted to reference out to the guide in the intro. Do you think it would be better to change it on the integration side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha. I think it is fine the way you did it then!
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes