Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS] Better explain billing exclusions for CI Visiblity #26976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxch-
Copy link
Contributor

@alxch- alxch- commented Jan 6, 2025

What does this PR do? What is the motivation?

The documentation page is not clear about what CI Visibility excludes from billing: commits from bots and made from the GitHub UI are not billed, however if the noreply email is set as the author and committer of the user, the commit gets billed. This PR fixes that.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@alxch- alxch- requested a review from a team as a code owner January 6, 2025 08:52
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alxch- Thanks for editing this! Based on your description, I made some further edits to the section header and original content to be even more explicit. What do you think?

@@ -23,7 +23,7 @@ This guide provides a non-exhaustive list of billing considerations for [CI Visi

A committer is an active Git contributor, identified by their Git author email address. For billing purposes, a committer is included if they make at least three commits in a given month.

## Charges for bot or no-reply committers with GitHub.com email addresses
## Charges for bot or actions in the GitHub UI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Charges for bot or actions in the GitHub UI
## Charges for bot commits and GitHub UI actions

@@ -23,7 +23,7 @@ This guide provides a non-exhaustive list of billing considerations for [CI Visi

A committer is an active Git contributor, identified by their Git author email address. For billing purposes, a committer is included if they make at least three commits in a given month.

## Charges for bot or no-reply committers with GitHub.com email addresses
## Charges for bot or actions in the GitHub UI

Datadog does not charge for bot or actions made in the GitHub UI. These types of committers are excluded from billing calculations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Datadog does not charge for bot or actions made in the GitHub UI. These types of committers are excluded from billing calculations.
Datadog does not charge for commits made by bots or actions performed in the GitHub UI. These activities are excluded from billing calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants