Update custom-javascript-assertion.md #26973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered an issue with a JavaScript assertion where the logs were not printing as expected. After extensive debugging, I discovered that only 4 logs can be printed at a time. This realization came after a significant amount of time spent troubleshooting. Including this limitation as a note would be highly beneficial.
brett0000FF
added
the
under_review
|
@surajtikoo - Thank you for the contribution and suggestion! We are going to validate this change with Engineering. |
|
Thanks did you managed to check on this?
…On Mon, 6 Jan 2025, 17:45 Brett Blue ***@***.***> wrote:
@surajtikoo <https://github.com/surajtikoo> - Thank you for the
contribution and suggestion! We are going to validate this change with
Engineering.
—
Reply to this email directly, view it on GitHub
<#26973 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJRMGQZY5HQOSXCXDUKF5B32JKXMFAVCNFSM6AAAAABUTIJF2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTGQ4TIOBXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @surajtikoo I am looking into this for you with our engineering team, thank you! |
Our engineering team ran some tests with this and indeed this is a limitation to prevent the test result from getting too big. This is a great addition to the docs, thank you! |
aliciascott
approved these changes
Jan 22, 2025
aliciascott
removed
the
under_review
p-datadog
pushed a commit
that referenced
this pull request
Jan 22, 2025
* merge: (30 commits) Revert "Update minimum Ruby tracer version for dynamic instrumentation to 2.9.0 (#27233)" Update custom-javascript-assertion.md (#26973) [DOCS-9908] Update RUM react initialization parameter (#27231) Update minimum Ruby tracer version for dynamic instrumentation to 2.9.0 (#27233) (DOCS-9604) Update images and text to match new panel style (#27173) Bump otel-agent version to 7.61 (#27221) Add note about key validation delay to API and Application keys docum… (#27210) Add support for vulnerability management - GetSBOM new endpoint (#27128) [ACCESS-3116] Show display name of permissions on permissions page (#27218) [DOCS-9912] Remove SDS via agent (#27215) [SDCI-880] Add K8s explanation for infra correlation for Gitlab (#27061) [AWSX] Update AWS integration role documentation (#27205) Include Weaver as a supported framework in Test Optimization for Java (#27152) (DOCS-9872) Add docs for Form component (#27118) OTel Troubleshooting Update (#27010) DOCS-9641 Take 2 (#27213) init (#27212) Updates the language on the serverless init cloud run page to push customers to use the sidecar (#27101) add additional note to the getlog limitation (#27209) fix ref numbers (#27206) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue with a JavaScript assertion where the logs were not printing as expected. After extensive debugging, I discovered that only 4 logs can be printed at a time. This realization came after a significant amount of time spent troubleshooting. Including this limitation as a note would be highly beneficial.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes