Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the example to use the JSONTemplateLayout since JSONLayout is … #26959

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Jan 3, 2025

…deprecated

What does this PR do? What is the motivation?

  • Requested by Support, JSONLayout is deprecated but examples in docs still reference this.
  • General formatting updates, moved content to collapse-content
  • DOCS-8984
  • DOCS-9345

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@estherk15 estherk15 requested a review from a team as a code owner January 3, 2025 15:17
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestions, but they're not blocking. Happy to stamp this if you want to merge

{{% /collapse-content %}}

{{% collapse-content title="Console appender" level="h4" %}}
{{< code-block lang="xml" filename="log4j2.xml" collapsible="false" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like these collapse parameters are being respected. Maybe try fenced code blocks instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the collapsible parameter and it worked on my local. For some reason fenced code blocks mess up the collapse-content formatting.

@estherk15
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-06 18:05:53 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-06 18:11:55 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e4a241c into master Jan 6, 2025
19 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the esther/docs-8984-update-json-template-layout branch January 6, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants