-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the example to use the JSONTemplateLayout since JSONLayout is … #26959
Change the example to use the JSONTemplateLayout since JSONLayout is … #26959
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple suggestions, but they're not blocking. Happy to stamp this if you want to merge
{{% /collapse-content %}} | ||
|
||
{{% collapse-content title="Console appender" level="h4" %}} | ||
{{< code-block lang="xml" filename="log4j2.xml" collapsible="false" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like these collapse parameters are being respected. Maybe try fenced code blocks instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the collapsible parameter and it worked on my local. For some reason fenced code blocks mess up the collapse-content formatting.
/merge |
Devflow running:
|
…deprecated
What does this PR do? What is the motivation?
JSONLayout
is deprecated but examples in docs still reference this.Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes