Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite monitor use cases #26928

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Composite monitor use cases #26928

merged 3 commits into from
Jan 2, 2025

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Dec 30, 2024 •
edited by jira bot
Loading

What does this PR do? What is the motivation?

  • Add a guide for the most common composite monitor use cases
  • DOCS-9772

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@estherk15 estherk15 requested a review from a team as a code owner December 30, 2024 20:33
@github-actions github-actions bot added the Guide Content impacting a guide label Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

aliciascott
aliciascott approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

content/en/monitors/guide/composite_use_cases.md Show resolved Hide resolved
chinichilla
chinichilla approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@chinichilla chinichilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting this together

content/en/monitors/guide/composite_use_cases.md Outdated Show resolved Hide resolved
@estherk15
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 2, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-02 19:30:58 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-02 19:48:18 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-01-02 19:54:02 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 65fc4d1 into master Jan 2, 2025
15 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the esther/docs-9772-composite-use-cases branch January 2, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliciascott aliciascott aliciascott approved these changes

@chinichilla chinichilla chinichilla approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estherk15 @chinichilla @aliciascott