Revise guide and remove scoping information #26900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
estherk15
commented
Dec 24, 2024
estherk15
commented
Dec 24, 2024
estherk15
commented
Dec 24, 2024
buraizu
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Looks good overall, approving with some link updates and other minor suggestions. Additionally:
- All the
/account_management/rbac/permissions?tab=uilinks are out-of-date and are no longer able to link to the specific permission as intended. These should probably now point to the#log-managementheading on that page - I also updated permissions links to show the specific permission required
- Not sure why, but all links to API pages are returning
404errors in the preview, although I know you haven't changed them and they're working as expected on the live doc
|
|
||
| For example, in the context of Docker Log Collection, attach the `team:acme` tag to logs flowing from that container with [Docker labels as tags][2]. Refer to the [Tagging Section][3] for a more general overview. | ||
| {{< img src="logs/guide/rbac/team_tag.png" alt="Apply a team tag to your logs" style="width:80%;">}} |
There was a problem hiding this comment.
Just flagging that there are a couple of IP address in this screenshot
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes