Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Functions Redrive Tracing #26811

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Step Functions Redrive Tracing #26811

merged 8 commits into from
Jan 16, 2025

Conversation

avedmala
Copy link
Contributor

@avedmala avedmala commented Dec 17, 2024

Updates the redrive page to add details and limitations for redrive traces

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Updates the redrive page to add details and limitations for redrive traces
@avedmala avedmala requested review from a team as code owners December 17, 2024 16:55
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@avedmala avedmala marked this pull request as draft December 18, 2024 00:14
Copy link
Contributor

@kimi-p kimi-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avedmala avedmala marked this pull request as ready for review January 16, 2025 15:20
@avedmala avedmala requested a review from a team as a code owner January 16, 2025 15:20
@avedmala
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 16, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-16 15:34:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-16 15:38:41 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.


2025-01-16 15:45:27 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit dbe3e29 into master Jan 16, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the avedmala/patch branch January 16, 2025 15:45
domalessi pushed a commit that referenced this pull request Jan 20, 2025
* Step Functions Redrive Tracing

Updates the redrive page to add details and limitations for redrive traces

* rephrase

* vale fixes

* remove duplicate sentence

* Update content/en/serverless/step_functions/redrive.md

Co-authored-by: Jen Gilbert <[email protected]>

* bump node layer version

* add note on sampling

* remove trace merging section for now

---------

Co-authored-by: Jen Gilbert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants