Minor: Remove typo from advanced_configuration.md #20093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extra comma from end of line so the Swift code is valid
hestonhoffman
approved these changes
Oct 6, 2023
xgouchet
approved these changes
Oct 7, 2023
0xnm
approved these changes
Oct 9, 2023
|
Hi! My apologies, I'm going through old PRs that I reviewed and it looks like I never merged this one. Would you mind rebasing or recreating the PR? It looks like the issue still persists in the doc and I want to make sure you get credit for the fix :) |
|
Cherry-picked and opened #26981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed extra comma from end of line so the Swift code is valid
What does this PR do? What is the motivation?
A Swift code example includes an extra comma that will cause the code to fail to compile.
Merge instructions
Additional notes