[PROF-11524] Upgrade libdatadog dependency to 17.1 #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on every report Reusing an `encoded_profile` object will no longer be possible with libdatadog 17+. This does change what the benchmark was covering, so comparing with prior results is not particularly relevant. I did consider removing this benchmark (we haven't used it for a long time for anything in particular), but on the other hand these microbenchmarks that exercise libdatadog have been useful sometimes so why not.
This tag will be set automatically by libdatadog 17+ so we no longer need to set it. See DataDog/libdatadog#954 for the change on the libdatadog side.
Still missing: cancellation token changes.
The removed spec for the invalid sample no longer triggers on release builds of libdatadog (it's only for debug builds).
Still discussing with folks what the next steps are on this one.
With the move to handles, I'm unsure if our previous approach was correct, so I've tweaked our usage and added a bit more validation to catch any unexpected issues.
Datadog ReportBranch report: ✅ 0 Failed, 19991 Passed, 1953 Skipped, 3m 46.92s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the native bits in the gem (profiling, crashtracking) to be able to work with the latest libdatadog 17.
I'm opening it as a draft so we can use it to test the upcoming libdatadog 17.1 release. Once that release is out and on rubygems.org, I plan to:
Motivation:
There's a number of fixes and additions in libdatadog that we want to make use of.
Change log entry
Yes. Upgrade libdatadog dependency to 17.1
Additional Notes:
With this PR, I'm able to build both crashtracking AND profiling with libdatadog master as of 11th of April. I'm also able to get a green test suite for profiling, but not for crashtracking: I've reported the issue to the folks working on that, so they're aware.
How to test the change?
Once everything is in place, our existing test coverage will be enough to validate these changes. Until then it's expected that CI is going to be red.