-
Notifications
You must be signed in to change notification settings - Fork 385
DEBUG-3700 Remove duplicated classes from Telemetry transport #4575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-04-10 17:30:19 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20790 Passed, 1370 Skipped, 3m 37.67s Total Time |
BenchmarksBenchmark execution time: 2025-04-10 17:54:23 Comparing candidate commit b723f99 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - stack collector
|
f69c8e1
to
b723f99
Compare
@@ -25,11 +26,11 @@ def request(event) | |||
seq_id = self.class.sequence.next | |||
payload = Request.build_payload(event, seq_id) | |||
res = @http_transport.request(request_type: event.type, payload: payload.to_json) | |||
Datadog.logger.debug { "Telemetry sent for event `#{event.type}` (code: #{res.code.inspect})" } | |||
Datadog.logger.debug { "Telemetry sent for event `#{event.type}` (response: #{res})" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deleted telemetry code always returned nil
for code, and code
does not exist in the Core response class, therefore I changed reading of code
to stringifying the response.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4575 +/- ##
==========================================
- Coverage 97.76% 97.73% -0.03%
==========================================
Files 1405 1399 -6
Lines 86182 85903 -279
Branches 4357 4350 -7
==========================================
- Hits 84258 83961 -297
- Misses 1924 1942 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
datadog-ci-rb uses one of the removed clasess thusly:
LoadError is not derived from StandardError and will escape the rescue above. I will put back the file with a dummy class definition. |
What does this PR do?
Removes duplicated Core classes from Telemetry transport code.
Motivation:
As part of getting telemetry working for dynamic instrumentation, telemetry needs to work with UDS which is what shopist uses. Currently Telemetry only supports HTTP. Using the Core transport code will bring UDS transport to Telemetry.
Change log entry
None
Additional Notes:
This is the first PR of a series. the next one will add a Core-based transport. This PR should be quick to review and conceptually it is standalone.
How to test the change?
Existing unit tests