Skip to content

[APPSEC-57239] Extract derivative schema compression into a module #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Apr 10, 2025

What does this PR do?

Extract tag compression logic for WAF derivative schemas into a separate module

Motivation:

We want to compress that way only schemas and compression worth to be extracted

Change log entry

Yes. AppSec: Add temporary handling for UTF-8 unsafe payloads in InApp-WAF to prevent runtime exceptions.

Additional Notes:

It was hard to come up with a good name, did my best

How to test the change?

CI is enough

@github-actions github-actions bot added the appsec Application Security monitoring product label Apr 10, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Apr 10, 2025

Datadog Report

Branch report: appsec-57239-fix-derivatives-compression
Commit report: c6077a6
Test service: dd-trace-rb

✅ 0 Failed, 20832 Passed, 1370 Skipped, 3m 43.88s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Apr 10, 2025

Benchmarks

Benchmark execution time: 2025-04-14 14:19:19

Comparing candidate commit c6077a6 in PR branch appsec-57239-fix-derivatives-compression with baseline commit f6543eb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (f6543eb) to head (c6077a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/appsec/event.rb 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4573      +/-   ##
==========================================
+ Coverage   97.73%   97.76%   +0.02%     
==========================================
  Files        1405     1407       +2     
  Lines       86185    86216      +31     
  Branches     4358     4357       -1     
==========================================
+ Hits        84237    84290      +53     
+ Misses       1948     1926      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strech Strech force-pushed the appsec-57239-fix-derivatives-compression branch 5 times, most recently from 039fed2 to 4ae1ce7 Compare April 11, 2025 10:30
@Strech Strech force-pushed the appsec-57239-fix-derivatives-compression branch from 4ae1ce7 to bf508a6 Compare April 11, 2025 15:05
In response to dd-trace-rb <-> libddwaf communication bug we
are going to handle exceptions before fix arrives
@Strech Strech marked this pull request as ready for review April 14, 2025 13:42
@Strech Strech requested review from a team as code owners April 14, 2025 13:42
@Strech Strech merged commit afe0627 into master Apr 15, 2025
441 checks passed
@Strech Strech deleted the appsec-57239-fix-derivatives-compression branch April 15, 2025 08:17
@github-actions github-actions bot added this to the 2.15.0 milestone Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants