-
Notifications
You must be signed in to change notification settings - Fork 385
[APPSEC-57239] Extract derivative schema compression into a module #4573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 20832 Passed, 1370 Skipped, 3m 43.88s Total Time |
BenchmarksBenchmark execution time: 2025-04-14 14:19:19 Comparing candidate commit c6077a6 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4573 +/- ##
==========================================
+ Coverage 97.73% 97.76% +0.02%
==========================================
Files 1405 1407 +2
Lines 86185 86216 +31
Branches 4358 4357 -1
==========================================
+ Hits 84237 84290 +53
+ Misses 1948 1926 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
039fed2
to
4ae1ce7
Compare
* Exclude non-schema derivative keys from being compressed
4ae1ce7
to
bf508a6
Compare
In response to dd-trace-rb <-> libddwaf communication bug we are going to handle exceptions before fix arrives
What does this PR do?
Extract tag compression logic for WAF derivative schemas into a separate module
Motivation:
We want to compress that way only schemas and compression worth to be extracted
Change log entry
Yes. AppSec: Add temporary handling for UTF-8 unsafe payloads in InApp-WAF to prevent runtime exceptions.
Additional Notes:
It was hard to come up with a good name, did my best
How to test the change?
CI is enough