APM Disablement V2 #4498
Merged
APM Disablement V2 #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
BenchmarksBenchmark execution time: 2025-03-27 19:38:55 Comparing candidate commit 3e2d0d1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
vpellan
force-pushed
the
vpellan/apm-disablement-v2
branch
from
4108893 to
aad5858
Compare
vpellan
force-pushed
the
vpellan/fix-sca-standalone
branch
from
6dd3b95 to
149fbbb
Compare
vpellan
force-pushed
the
vpellan/apm-disablement-v2
branch
from
413eb56 to
7d805e9
Compare
vpellan
force-pushed
the
vpellan/fix-sca-standalone
branch
from
4544628 to
fea594d
Compare
vpellan
force-pushed
the
vpellan/apm-disablement-v2
branch
from
7d805e9 to
0fd3665
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
vpellan
force-pushed
the
vpellan/apm-disablement-v2
branch
from
0fd3665 to
f057d9f
Compare
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4498 +/- ##
==========================================
- Coverage 97.77% 97.75% -0.02%
==========================================
Files 1392 1392
Lines 84890 84924 +34
Branches 4277 4285 +8
==========================================
+ Hits 82997 83019 +22
- Misses 1893 1905 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20786 Passed, 1370 Skipped, 3m 10.37s Total Time |
7 tasks
marcotc
reviewed
Mar 26, 2025
marcotc
approved these changes
Mar 26, 2025
y9v
approved these changes
Mar 27, 2025
Strech
approved these changes
Mar 27, 2025
p-datadog
reviewed
Mar 27, 2025
p-datadog
approved these changes
Mar 27, 2025
janine-c
approved these changes
Mar 27, 2025
Co-authored-by: Janine Chan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e
What does this PR do?
This PR changes the experimental env var
DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLEDtoDD_APM_TRACING_ENABLEDand the propagated tag from _dd.p.appsec to _dd.p.ts (which stands from trace source and is a bitmask)Motivation:
Standalone Security features (which depends on APM Disablement) have been announced
(https://docs.datadoghq.com/security/application_security/guide/standalone_application_security/)
Change log entry
Yes. Tracing: Add setting to disable APM tracing while keeping other products traces.
Additionally, dd-trace-rb will now properly initialize in some situations when only partial code of it is loaded.
Additional Notes:
Please do not merge before this system-tests PR is merged
How to test the change?
System tests/Unit tests in CI