Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strscan specification in 3.4 gemfile #4250

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

sarahchen6
Copy link
Contributor

What does this PR do?
Remove pinned strscan version now that the gem has been updated to 3.1.2.

Motivation:
Keep our gemfiles updated.

Change log entry
No.

Additional Notes:
N/A

How to test the change?
Green CI.

@sarahchen6 sarahchen6 requested a review from a team as a code owner January 2, 2025 15:54
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 2, 2025

Datadog Report

Branch report: sarahchen6/update-ruby-3.4-gemfile
Commit report: bd77c35
Test service: dd-trace-rb

✅ 0 Failed, 22128 Passed, 1476 Skipped, 5m 21.05s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 2, 2025

Benchmarks

Benchmark execution time: 2025-01-03 10:31:12

Comparing candidate commit bd77c35 in PR branch sarahchen6/update-ruby-3.4-gemfile with baseline commit b1400d5 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-3972.382op/s; -3864.641op/s] or [-10.359%; -10.078%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+6265.767op/s; +6618.253op/s] or [+5.595%; +5.909%]

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I'm assuming that once we make master CI green this can be rebased and the job that adds the commit that updates the appraisals will kick in as usual.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (b1400d5) to head (bd77c35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4250      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1353     1353              
  Lines       82392    82392              
  Branches     4224     4224              
==========================================
- Hits        80550    80544       -6     
- Misses       1842     1848       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahchen6 sarahchen6 merged commit 5c948ba into master Jan 3, 2025
347 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/update-ruby-3.4-gemfile branch January 3, 2025 13:03
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants