Streamline CircleCI config #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4073 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 1338 1338
Lines 80248 80248
Branches 4016 4016
==========================================
+ Hits 78420 78433 +13
+ Misses 1828 1815 -13 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-11-05 19:17:57 Comparing candidate commit e7b129a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
marcotc
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our CircleCI configuration contains a lot of unnecessary indirections.
For instance, plenty of
&variable is only been used ONCE!This PR tries to streamline the process to make the configuration a bit more expressive