-
Notifications
You must be signed in to change notification settings - Fork 469
chore: treat PEP 765 warnings as errors #15325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 261 ± 6 ms. The average import time from base is: 271 ± 7 ms. The import time difference between this PR and base is: -9.3 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/pep765.error (0dac362) with baseline main (2cc3c8b) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.6% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.1% ✅ add_inplace_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.8% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 1.392µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +4.7% Memory: ✅ 39.754MB (SLO: <41.500MB -4.2%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.650µs (SLO: <10.000µs 📉 -83.5%) vs baseline: +7.8% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +3.9% ✅ bytearray_extend_noaspectTime: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.6% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 0.479µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.6% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ bytes_aspectTime: ✅ 1.318µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +2.4% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.7% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 1.296µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.7% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +4.5% ✅ bytesio_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.9% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: ~same Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 0.433µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.6% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: ~same Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +4.6% ✅ casefold_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.6% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.4% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.2% ✅ encode_aspectTime: ✅ 0.718µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.7% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 3.332µs (SLO: <10.000µs 📉 -66.7%) vs baseline: +0.4% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.2% ✅ format_map_aspectTime: ✅ 3.446µs (SLO: <10.000µs 📉 -65.5%) vs baseline: -0.9% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 0.768µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: ~same Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.9% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.398µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +0.7% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.7% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.8% ✅ ljust_aspectTime: ✅ 2.498µs (SLO: <20.000µs 📉 -87.5%) vs baseline: +0.9% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ lower_aspectTime: ✅ 2.197µs (SLO: <10.000µs 📉 -78.0%) vs baseline: -0.9% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.366µs (SLO: <20.000µs 📉 -88.2%) vs baseline: +6.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.5% ✅ modulo_aspectTime: ✅ 1.037µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.631µs (SLO: <10.000µs 📉 -83.7%) vs baseline: +5.5% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.976µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +3.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.262µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +1.5% Memory: ✅ 39.656MB (SLO: <41.500MB -4.4%) vs baseline: +5.4% ✅ modulo_noaspectTime: ✅ 0.627µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -1.0% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 5.420µs (SLO: <10.000µs 📉 -45.8%) vs baseline: 📈 +11.4% Memory: ✅ 39.636MB (SLO: <41.500MB -4.5%) vs baseline: +5.5% ✅ replace_noaspectTime: ✅ 0.466µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +0.4% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 0.905µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.2% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.2% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.2% ✅ rstrip_aspectTime: ✅ 1.896µs (SLO: <20.000µs 📉 -90.5%) vs baseline: +1.4% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.377µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +5.2% ✅ slice_aspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.2% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.8% Memory: ✅ 39.322MB (SLO: <41.500MB -5.2%) vs baseline: +4.5% ✅ stringio_aspectTime: ✅ 1.530µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.4% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +3.9% ✅ stringio_noaspectTime: ✅ 0.718µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.3% Memory: ✅ 39.636MB (SLO: <41.500MB -4.5%) vs baseline: +5.2% ✅ strip_aspectTime: ✅ 2.205µs (SLO: <20.000µs 📉 -89.0%) vs baseline: ~same Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ strip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.2% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 2.381µs (SLO: <10.000µs 📉 -76.2%) vs baseline: -1.1% Memory: ✅ 39.715MB (SLO: <41.500MB -4.3%) vs baseline: +5.6% ✅ swapcase_noaspectTime: ✅ 0.531µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -1.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.333µs (SLO: <10.000µs 📉 -76.7%) vs baseline: -0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.225µs (SLO: <10.000µs 📉 -67.8%) vs baseline: +0.3% Memory: ✅ 39.656MB (SLO: <41.500MB -4.4%) vs baseline: +5.2% ✅ translate_noaspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.6% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.199µs (SLO: <10.000µs 📉 -78.0%) vs baseline: -1.1% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7% Memory: ✅ 39.656MB (SLO: <41.500MB -4.4%) vs baseline: +5.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.969µs (SLO: <20.000µs 📉 -85.2%) vs baseline: +1.8% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 201.621µs (SLO: <220.000µs -8.4%) vs baseline: +1.7% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.675µs (SLO: <20.000µs 📉 -81.6%) vs baseline: 📈 +11.2% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 219.226µs (SLO: <220.000µs 🟡 -0.4%) vs baseline: +1.7% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.175µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.5% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.837µs (SLO: <150.000µs -8.8%) vs baseline: -0.3% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.199µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +3.9% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.845µs (SLO: <250.000µs 📉 -14.5%) vs baseline: +0.3% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.049ms (SLO: <22.000ms -8.9%) vs baseline: ~same Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.288ms (SLO: <2.300ms 🟡 -0.5%) vs baseline: +0.7% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.413ms (SLO: <1.550ms -8.9%) vs baseline: +0.4% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.187ms (SLO: <2.550ms 📉 -14.3%) vs baseline: -0.5% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.681µs (SLO: <20.000µs 📉 -76.6%) vs baseline: +1.4% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 175.367µs (SLO: <250.000µs 📉 -29.9%) vs baseline: -0.4% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.115ms (SLO: <2.500ms 📉 -15.4%) vs baseline: -0.3% Memory: ✅ 35.311MB (SLO: <36.500MB -3.3%) vs baseline: +5.0% 🟡 Near SLO Breach (1 suite)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.637ms (SLO: <47.150ms 📉 -18.1%) vs baseline: +0.5% Memory: ✅ 39.039MB (SLO: <47.000MB 📉 -16.9%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 258.159ms (SLO: <344.800ms 📉 -25.1%) vs baseline: +0.5% Memory: ✅ 43.294MB (SLO: <47.500MB -8.9%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 317.321ms (SLO: <321.000ms 🟡 -1.1%) vs baseline: +0.7% Memory: ✅ 43.273MB (SLO: <47.500MB -8.9%) vs baseline: +4.8% ✅ get-contextTime: ✅ 81.185ms (SLO: <92.350ms 📉 -12.1%) vs baseline: +3.4% Memory: ✅ 39.295MB (SLO: <46.500MB 📉 -15.5%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 36.064ms (SLO: <44.500ms 📉 -19.0%) vs baseline: -0.4% Memory: ✅ 38.710MB (SLO: <47.500MB 📉 -18.5%) vs baseline: +4.3% ✅ record-exceptionTime: ✅ 57.044ms (SLO: <67.650ms 📉 -15.7%) vs baseline: ~same Memory: ✅ 39.321MB (SLO: <47.000MB 📉 -16.3%) vs baseline: +4.5% ✅ set-statusTime: ✅ 42.619ms (SLO: <50.400ms 📉 -15.4%) vs baseline: +0.3% Memory: ✅ 38.775MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.9% ✅ startTime: ✅ 35.440ms (SLO: <43.450ms 📉 -18.4%) vs baseline: +0.6% Memory: ✅ 38.812MB (SLO: <47.000MB 📉 -17.4%) vs baseline: +4.9% ✅ start-finishTime: ✅ 81.858ms (SLO: <88.000ms -7.0%) vs baseline: +0.4% Memory: ✅ 36.569MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 83.368ms (SLO: <89.000ms -6.3%) vs baseline: +0.4% Memory: ✅ 36.549MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +4.7% ✅ update-nameTime: ✅ 37.167ms (SLO: <45.150ms 📉 -17.7%) vs baseline: +0.8% Memory: ✅ 38.980MB (SLO: <47.000MB 📉 -17.1%) vs baseline: +4.8%
|
## Description PEP 765 returns in finally statements is a SyntaxWarning in 3.14, and will turn into exceptions in 3.15 ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers -->
Description
PEP 765 returns in finally statements is a SyntaxWarning in 3.14, and will turn into exceptions in 3.15
Testing
Risks
Additional Notes