-
Notifications
You must be signed in to change notification settings - Fork 469
ci: increase llmobs parallelism to 5 #15317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 248 ± 3 ms. The average import time from base is: 255 ± 2 ms. The import time difference between this PR and base is: -7.0 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate brettlangdon/llmobs.parallel (2add381) with baseline main (2cc3c8b) 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.238ms (SLO: <22.300ms 📉 -13.7%) vs baseline: -0.4% Memory: ✅ 67.790MB (SLO: <70.500MB -3.8%) vs baseline: +4.6% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: +0.5% Memory: ✅ 66.119MB (SLO: <67.500MB -2.0%) vs baseline: +5.0% ✅ iastTime: ✅ 19.232ms (SLO: <22.250ms 📉 -13.6%) vs baseline: -0.1% Memory: ✅ 67.830MB (SLO: <70.000MB -3.1%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.562ms (SLO: <16.550ms -6.0%) vs baseline: ~same Memory: ✅ 56.094MB (SLO: <57.500MB -2.4%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 19.396ms (SLO: <21.750ms 📉 -10.8%) vs baseline: +0.4% Memory: ✅ 67.849MB (SLO: <70.500MB -3.8%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 22.792ms (SLO: <28.200ms 📉 -19.2%) vs baseline: -0.5% Memory: ✅ 69.949MB (SLO: <71.000MB 🟡 -1.5%) vs baseline: +4.3% ✅ tracerTime: ✅ 19.270ms (SLO: <21.750ms 📉 -11.4%) vs baseline: -0.3% Memory: ✅ 67.790MB (SLO: <70.000MB -3.2%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 21.375ms (SLO: <23.500ms -9.0%) vs baseline: -0.1% Memory: ✅ 69.060MB (SLO: <71.000MB -2.7%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.328ms (SLO: <21.500ms 📉 -10.1%) vs baseline: +0.6% Memory: ✅ 67.790MB (SLO: <70.000MB -3.2%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.595ms (SLO: <17.500ms -5.2%) vs baseline: +0.2% Memory: ✅ 67.830MB (SLO: <70.000MB -3.1%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 19.373ms (SLO: <21.750ms 📉 -10.9%) vs baseline: +0.6% Memory: ✅ 67.830MB (SLO: <72.500MB -6.4%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 17.241ms (SLO: <19.650ms 📉 -12.3%) vs baseline: -0.2% Memory: ✅ 67.849MB (SLO: <70.000MB -3.1%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.814ms (SLO: <20.100ms -6.4%) vs baseline: +0.5% Memory: ✅ 67.751MB (SLO: <70.000MB -3.2%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 18.983ms (SLO: <21.500ms 📉 -11.7%) vs baseline: ~same Memory: ✅ 67.731MB (SLO: <70.000MB -3.2%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 19.066ms (SLO: <22.000ms 📉 -13.3%) vs baseline: -0.1% Memory: ✅ 67.751MB (SLO: <70.500MB -3.9%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.361ms (SLO: <47.150ms 📉 -18.6%) vs baseline: -0.1% Memory: ✅ 39.012MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 256.536ms (SLO: <344.800ms 📉 -25.6%) vs baseline: +0.1% Memory: ✅ 43.352MB (SLO: <47.500MB -8.7%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 315.958ms (SLO: <321.000ms 🟡 -1.6%) vs baseline: +0.6% Memory: ✅ 43.372MB (SLO: <47.500MB -8.7%) vs baseline: +5.0% ✅ get-contextTime: ✅ 78.528ms (SLO: <92.350ms 📉 -15.0%) vs baseline: +0.6% Memory: ✅ 39.319MB (SLO: <46.500MB 📉 -15.4%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 36.049ms (SLO: <44.500ms 📉 -19.0%) vs baseline: +0.5% Memory: ✅ 38.747MB (SLO: <47.500MB 📉 -18.4%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 57.051ms (SLO: <67.650ms 📉 -15.7%) vs baseline: +0.1% Memory: ✅ 39.352MB (SLO: <47.000MB 📉 -16.3%) vs baseline: +4.7% ✅ set-statusTime: ✅ 42.314ms (SLO: <50.400ms 📉 -16.0%) vs baseline: +0.3% Memory: ✅ 38.881MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +5.0% ✅ startTime: ✅ 35.387ms (SLO: <43.450ms 📉 -18.6%) vs baseline: ~same Memory: ✅ 38.733MB (SLO: <47.000MB 📉 -17.6%) vs baseline: +4.6% ✅ start-finishTime: ✅ 81.960ms (SLO: <88.000ms -6.9%) vs baseline: +0.7% Memory: ✅ 36.569MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 83.313ms (SLO: <89.000ms -6.4%) vs baseline: +0.4% Memory: ✅ 36.549MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +4.6% ✅ update-nameTime: ✅ 36.801ms (SLO: <45.150ms 📉 -18.5%) vs baseline: ~same Memory: ✅ 38.889MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +4.7% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.915µs (SLO: <20.000µs 📉 -85.4%) vs baseline: -1.3% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 197.983µs (SLO: <220.000µs 📉 -10.0%) vs baseline: -0.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.395µs (SLO: <20.000µs 📉 -83.0%) vs baseline: +2.8% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.889µs (SLO: <220.000µs 🟡 -1.9%) vs baseline: -1.0% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.168µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.7% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.783µs (SLO: <150.000µs -8.8%) vs baseline: ~same Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.064µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.4% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 213.184µs (SLO: <250.000µs 📉 -14.7%) vs baseline: +0.5% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.055ms (SLO: <22.000ms -8.8%) vs baseline: -0.2% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.283ms (SLO: <2.300ms 🟡 -0.7%) vs baseline: +1.1% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: -0.3% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.178ms (SLO: <2.550ms 📉 -14.6%) vs baseline: -0.6% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.3% ✅ flush-1-metricTime: ✅ 4.655µs (SLO: <20.000µs 📉 -76.7%) vs baseline: +0.4% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 175.545µs (SLO: <250.000µs 📉 -29.8%) vs baseline: -0.8% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.126ms (SLO: <2.500ms 📉 -14.9%) vs baseline: -0.3% Memory: ✅ 35.330MB (SLO: <36.500MB -3.2%) vs baseline: +4.9%
|
Description
We are seeing some timeouts in CI, the timeouts don't seem related to number of venvs run per-job, but there are exactly 5 venvs so might as well do 1 per-job anyways.
Testing
Risks
Additional Notes