Skip to content

chore(debugging): remove EL support for CPython 3.8 #15316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 21, 2025
+2 −6
Merged

chore(debugging): remove EL support for CPython 3.8 #15316

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3013ad8
chore(debugging): remove EL support for CPython 3.8
P403n1x87 Nov 18, 2025
888ac28
Merge branch 'main' into chore/di-el-remove-38
P403n1x87 Nov 18, 2025
9076689
Merge branch 'main' into chore/di-el-remove-38
P403n1x87 Nov 19, 2025
ac84af7
Merge branch 'main' into chore/di-el-remove-38
P403n1x87 Nov 20, 2025
f9f5a09
Merge branch 'main' into chore/di-el-remove-38
P403n1x87 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ddtrace/debugging/_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ def _is_identifier(name: str) -> bool:
return isinstance(name, str) and name.isidentifier()


IN_OPERATOR_INSTR = Instr("COMPARE_OP", Compare.IN) if PY < (3, 9) else Instr("CONTAINS_OP", 0)
NOT_IN_OPERATOR_INSTR = Instr("COMPARE_OP", Compare.NOT_IN) if PY < (3, 9) else Instr("CONTAINS_OP", 1)


def short_circuit_instrs(op: str, label: Label) -> List[Instr]:
value = "FALSE" if op == "and" else "TRUE"
if PY >= (3, 13):
Expand Down Expand Up @@ -156,7 +152,7 @@ def _compile_direct_predicate(self, ast: DDASTType) -> Optional[List[Instr]]:

if _type == "isDefined":
value.append(Instr("LOAD_FAST", "_locals"))
value.append(IN_OPERATOR_INSTR)
value.append(Instr("CONTAINS_OP", 0))
else:
if PY >= (3, 13):
# UNARY_NOT requires a boolean value
Expand Down Expand Up @@ -201,7 +197,7 @@ def _compile_arg_predicate(self, ast: DDASTType) -> Optional[List[Instr]]:
raise ValueError("Invalid argument: %r" % a)
if cb is None:
raise ValueError("Invalid argument: %r" % b)
return cb + ca + [IN_OPERATOR_INSTR]
return cb + ca + [Instr("CONTAINS_OP", 0)]

if _type in {"any", "all"}:
a, b = args
Expand Down
Loading