-
Notifications
You must be signed in to change notification settings - Fork 469
chore: remove pathlib compatibility code #15315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We remove custom compatibility code for pathlib since it was only needed for CPython 3.8.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 254 ± 5 ms. The average import time from base is: 264 ± 5 ms. The import time difference between this PR and base is: -9.6 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate chore/remove-pathlib-compat (696a157) with baseline main (38155b3) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.7% Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.4% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 0.316µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.8% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +5.3% ✅ add_noaspectTime: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.9% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +3.8% ✅ bytearray_aspectTime: ✅ 1.349µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.640µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +6.7% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.8% ✅ bytearray_extend_noaspectTime: ✅ 0.612µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.3% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.5% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.286µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -0.5% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 1.317µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +1.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.506µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.738µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.2% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.430µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.8% Memory: ✅ 39.715MB (SLO: <41.500MB -4.3%) vs baseline: +5.3% ✅ casefold_aspectTime: ✅ 0.742µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.9% Memory: ✅ 39.322MB (SLO: <41.500MB -5.2%) vs baseline: +4.0% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.1% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.6% ✅ decode_aspectTime: ✅ 0.721µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.3% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +6.0% ✅ decode_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.4% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.7% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +5.8% ✅ encode_noaspectTime: ✅ 0.398µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.8% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ format_aspectTime: ✅ 3.361µs (SLO: <10.000µs 📉 -66.4%) vs baseline: +0.2% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.9% ✅ format_map_aspectTime: ✅ 3.907µs (SLO: <10.000µs 📉 -60.9%) vs baseline: 📈 +11.9% Memory: ✅ 39.675MB (SLO: <41.500MB -4.4%) vs baseline: +5.2% ✅ format_map_noaspectTime: ✅ 0.771µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.7% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.606µs (SLO: <10.000µs 📉 -93.9%) vs baseline: +1.4% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.377µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.8% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.4% ✅ ljust_aspectTime: ✅ 2.503µs (SLO: <20.000µs 📉 -87.5%) vs baseline: -0.2% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.205µs (SLO: <10.000µs 📉 -78.0%) vs baseline: +0.2% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.218µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.2% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +6.0% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.2% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 1.019µs (SLO: <10.000µs 📉 -89.8%) vs baseline: -1.6% Memory: ✅ 39.754MB (SLO: <41.500MB -4.2%) vs baseline: +5.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.550µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -1.1% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 0.981µs (SLO: <10.000µs 📉 -90.2%) vs baseline: ~same Memory: ✅ 39.675MB (SLO: <41.500MB -4.4%) vs baseline: +5.3% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.249µs (SLO: <10.000µs 📉 -87.5%) vs baseline: -0.6% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.1% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.881µs (SLO: <10.000µs 📉 -51.2%) vs baseline: -0.5% Memory: ✅ 39.675MB (SLO: <41.500MB -4.4%) vs baseline: +5.4% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.2% Memory: ✅ 39.361MB (SLO: <41.500MB -5.2%) vs baseline: +4.5% ✅ repr_aspectTime: ✅ 0.907µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.2% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 1.891µs (SLO: <20.000µs 📉 -90.5%) vs baseline: +1.1% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +5.8% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.2% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.7% Memory: ✅ 39.420MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.3% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 1.569µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +1.8% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +5.6% ✅ stringio_noaspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.4% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.207µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.2% Memory: ✅ 39.558MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ swapcase_aspectTime: ✅ 2.390µs (SLO: <10.000µs 📉 -76.1%) vs baseline: -0.4% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +5.1% ✅ swapcase_noaspectTime: ✅ 0.534µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +0.8% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 2.375µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +1.8% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.4% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.218µs (SLO: <10.000µs 📉 -67.8%) vs baseline: -0.2% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 2.196µs (SLO: <10.000µs 📉 -78.0%) vs baseline: -1.6% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -2.0% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +5.0% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.287ms (SLO: <22.300ms 📉 -13.5%) vs baseline: -0.2% Memory: ✅ 67.830MB (SLO: <70.500MB -3.8%) vs baseline: +4.4% ✅ exception-replay-enabledTime: ✅ 1.342ms (SLO: <1.450ms -7.5%) vs baseline: ~same Memory: ✅ 66.041MB (SLO: <67.500MB -2.2%) vs baseline: +4.8% ✅ iastTime: ✅ 19.286ms (SLO: <22.250ms 📉 -13.3%) vs baseline: +0.1% Memory: ✅ 67.928MB (SLO: <70.000MB -3.0%) vs baseline: +4.6% ✅ profilerTime: ✅ 15.737ms (SLO: <16.550ms -4.9%) vs baseline: +1.0% Memory: ✅ 55.916MB (SLO: <57.500MB -2.8%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 19.359ms (SLO: <21.750ms 📉 -11.0%) vs baseline: ~same Memory: ✅ 67.849MB (SLO: <70.500MB -3.8%) vs baseline: +4.4% ✅ span-code-originTime: ✅ 22.870ms (SLO: <28.200ms 📉 -18.9%) vs baseline: +0.3% Memory: ✅ 70.145MB (SLO: <71.000MB 🟡 -1.2%) vs baseline: +4.6% ✅ tracerTime: ✅ 19.332ms (SLO: <21.750ms 📉 -11.1%) vs baseline: ~same Memory: ✅ 67.948MB (SLO: <70.000MB -2.9%) vs baseline: +4.6% ✅ tracer-and-profilerTime: ✅ 21.392ms (SLO: <23.500ms -9.0%) vs baseline: -0.2% Memory: ✅ 69.147MB (SLO: <71.000MB -2.6%) vs baseline: +5.2% ✅ tracer-dont-create-db-spansTime: ✅ 19.333ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 67.948MB (SLO: <70.000MB -2.9%) vs baseline: +4.5% ✅ tracer-minimalTime: ✅ 16.609ms (SLO: <17.500ms -5.1%) vs baseline: -0.2% Memory: ✅ 67.742MB (SLO: <70.000MB -3.2%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 19.244ms (SLO: <21.750ms 📉 -11.5%) vs baseline: -0.1% Memory: ✅ 67.948MB (SLO: <72.500MB -6.3%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 17.278ms (SLO: <19.650ms 📉 -12.1%) vs baseline: -0.2% Memory: ✅ 67.771MB (SLO: <70.000MB -3.2%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.802ms (SLO: <20.100ms -6.5%) vs baseline: +0.7% Memory: ✅ 67.849MB (SLO: <70.000MB -3.1%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 19.014ms (SLO: <21.500ms 📉 -11.6%) vs baseline: ~same Memory: ✅ 67.770MB (SLO: <70.000MB -3.2%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 19.142ms (SLO: <22.000ms 📉 -13.0%) vs baseline: ~same Memory: ✅ 67.751MB (SLO: <70.500MB -3.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 64.025MB (SLO: <66.500MB -3.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.615ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: -0.3% Memory: ✅ 64.420MB (SLO: <66.500MB -3.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: -0.3% Memory: ✅ 64.106MB (SLO: <66.500MB -3.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: +0.3% Memory: ✅ 47.838MB (SLO: <49.500MB -3.4%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: +0.4% Memory: ✅ 44.738MB (SLO: <49.000MB -8.7%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.925ms (SLO: <2.100ms -8.3%) vs baseline: +0.1% Memory: ✅ 48.398MB (SLO: <50.000MB -3.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.373ms (SLO: <3.650ms -7.6%) vs baseline: +0.1% Memory: ✅ 54.597MB (SLO: <56.000MB -2.5%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: -0.2% Memory: ✅ 54.681MB (SLO: <56.500MB -3.2%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 54.752MB (SLO: <60.000MB -8.7%) vs baseline: +5.2% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.952µs (SLO: <20.000µs 📉 -85.2%) vs baseline: +1.1% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 201.084µs (SLO: <220.000µs -8.6%) vs baseline: +1.8% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.347µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +1.3% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.968µs (SLO: <230.000µs -5.2%) vs baseline: +0.8% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.177µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +1.1% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.872µs (SLO: <150.000µs -8.8%) vs baseline: -0.2% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.120µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +2.0% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 214.487µs (SLO: <250.000µs 📉 -14.2%) vs baseline: +1.0% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 19.934ms (SLO: <22.000ms -9.4%) vs baseline: -0.5% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +5.3% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.266ms (SLO: <2.300ms 🟡 -1.5%) vs baseline: -1.6% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.3% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: -0.2% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.206ms (SLO: <2.550ms 📉 -13.5%) vs baseline: +1.4% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.638µs (SLO: <20.000µs 📉 -76.8%) vs baseline: +0.2% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.308µs (SLO: <250.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ flush-1000-metricsTime: ✅ 2.122ms (SLO: <2.500ms 📉 -15.1%) vs baseline: +0.1% Memory: ✅ 35.389MB (SLO: <36.500MB -3.0%) vs baseline: +5.0%
|
emmettbutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
Description
We remove custom compatibility code for pathlib since it was only needed for CPython 3.8.