Skip to content

chore(utils): stop threads in dummy writer #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

chore(utils): stop threads in dummy writer #15307

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
756bab1
chore(utils): stop threads in dummy writer
VianneyRuhlmann Nov 17, 2025
22c28b1
remove tracer fixture from fastapi interface
christophe-papazian Nov 18, 2025
3dc79df
Merge branch 'main' into vianney/stop-threads-in-dummy
christophe-papazian Nov 18, 2025
a9f63d0
chore(tests): move comment to right line
VianneyRuhlmann Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/appsec/contrib_appsec/test_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class Test_FastAPI(utils.Contrib_TestClass_For_Threats):
@pytest.fixture
def interface(self, tracer, printer):
def interface(self, printer):
from fastapi.testclient import TestClient

# for fastapi, test tracer needs to be set before the app is created
Expand Down
4 changes: 4 additions & 0 deletions tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ def pop(self):
spans = DummyWriterMixin.pop(self)
if self._trace_flush_enabled:
flush_test_tracer_spans(self)
self._inner_writer.before_fork()
return spans

def recreate(self, appsec_enabled: Optional[bool] = None) -> "DummyWriter":
Expand Down Expand Up @@ -745,6 +746,9 @@ def get_spans(self):
def pop(self):
# type: () -> List[Span]
spans = self._span_aggregator.writer.pop()
# Stop the writer threads in case the writer is no longer used.
# Otherwise we risk accumulating threads and file descriptors causing crashes
# In case the writer is used again it will be restarted by native side.
return spans

def pop_traces(self):
Expand Down
Loading