Skip to content

chore(crashtracking): fix flaky test around receiving crash messages #14654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

chore(crashtracking): fix flaky test around receiving crash messages #14654

merged 1 commit into from
Sep 22, 2025

Conversation

gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Sep 19, 2025 •
edited
Loading

Description

Ticket

This PR renames the function wait_for_crash_reports to wait_for_crash_messages and other uses of reports to messages where necessary. This is because the crashtracker emits two types of messages, crash reports and crash pings, so it is misleading to call both as crash reports.

This PR also does a bit of updating of logic around how we set up our mock client to handle crash messages. Now, the crash tracker sends two messages, crash_ping and crash_report. The wait_for_crash_reports used to work by spinning for N cycles and each time, calling TestAgentClient.crash_reports(), which was a function that returned all the requests originated from crashtracker within that test session. The previous logic would then accumulate all the requests returned by the TestAgentClient. However, this logic was flawed. Consider this case

---------- Cycle 1 ----------
crash_ping arrives to client
TestAgentClient.crash_reports() -> [crash_ping]
accumulated requests = [crash_ping]
---------- Cycle 2 ----------
crash_report arrives to client
TestAgentClient.crash_reports() -> [crash_ping, crash_report]
accumulated requests = [crash_ping, crash_ping, crash_report]

We just duplicated crash_ping! This is not a problem if both crash_ping and crash_report arrive in the same cycle of waiting for crash reports, as then, we would have >=2 messages and exit early. However, if we receive crash_ping and crash_report in different cycles, we end up duplicating one of them.

This issue was identified by noticing many failures of the crashtracking tests, because we got 3 messages instead of 2.
Screenshot 2025-09-19 at 3 04 58 PM

Testing

Risks

Additional Notes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

CODEOWNERS have been resolved as:

tests/internal/crashtracker/test_crashtracker.py                        @DataDog/apm-core-python
tests/internal/crashtracker/utils.py                                    @DataDog/apm-core-python
tests/utils.py                                                          @DataDog/python-guild

@gyuheon0h gyuheon0h added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 19, 2025
@gyuheon0h gyuheon0h changed the title fix(Crashtracking): fix flaky test around receiving crash messages. fix(crashtracking): fix flaky test around receiving crash messages. Sep 19, 2025
@gyuheon0h gyuheon0h changed the title fix(crashtracking): fix flaky test around receiving crash messages. fix(crashtracking): fix flaky test around receiving crash messages Sep 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 266 ± 3 ms.

The average import time from base is: 269 ± 2 ms.

The import time difference between this PR and base is: -2.4 ± 0.1 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 0.017 ms (0.01%)
ddtrace.bootstrap.sitecustomize 0.017 ms (0.01%)
ddtrace.bootstrap.preload 0.017 ms (0.01%)
ddtrace.internal.remoteconfig._pubsub 0.017 ms (0.01%)
ddtrace.internal.remoteconfig._subscribers 0.017 ms (0.01%)

The following import paths have shrunk:

ddtrace.auto 2.057 ms (0.77%)
ddtrace.bootstrap.sitecustomize 1.352 ms (0.51%)
ddtrace.bootstrap.preload 1.352 ms (0.51%)
ddtrace.internal.remoteconfig.client 0.647 ms (0.24%)
ddtrace 0.705 ms (0.27%)
ddtrace.internal._unpatched 0.060 ms (0.02%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)
subprocess 0.030 ms (0.01%)
contextlib 0.030 ms (0.01%)

@gyuheon0h gyuheon0h changed the title fix(crashtracking): fix flaky test around receiving crash messages chore(crashtracking): fix flaky test around receiving crash messages Sep 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2025 •
edited
Loading

Performance SLOs

Comparing candidate gyuheon0h/fix-flaky-test (f6ae194) with baseline main (8fbf836)

📈 Performance Regressions (2 suites)
📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.5%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ add_inplace_aspect

Time: ✅ 0.416µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ add_inplace_noaspect

Time: ✅ 0.319µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.7%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8%

✅ add_noaspect

Time: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytearray_aspect

Time: ✅ 1.320µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -0.8%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ bytearray_extend_aspect

Time: ✅ 1.484µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +1.2%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ bytearray_extend_noaspect

Time: ✅ 0.615µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +1.1%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytearray_noaspect

Time: ✅ 0.481µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.7%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ bytes_aspect

Time: ✅ 1.519µs (SLO: <10.000µs 📉 -84.8%) vs baseline: 📈 +15.3%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ bytes_noaspect

Time: ✅ 0.489µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ bytesio_aspect

Time: ✅ 1.346µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -1.3%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ bytesio_noaspect

Time: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ capitalize_aspect

Time: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ capitalize_noaspect

Time: ✅ 0.433µs (SLO: <10.000µs 📉 -95.7%) vs baseline: ~same

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ casefold_aspect

Time: ✅ 0.735µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ casefold_noaspect

Time: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.5%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ decode_aspect

Time: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.5%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ decode_noaspect

Time: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.6%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ encode_aspect

Time: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ encode_noaspect

Time: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +1.2%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ format_aspect

Time: ✅ 3.571µs (SLO: <10.000µs 📉 -64.3%) vs baseline: +3.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ format_map_aspect

Time: ✅ 4.214µs (SLO: <10.000µs 📉 -57.9%) vs baseline: 📈 +14.6%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +5.0%

✅ format_map_noaspect

Time: ✅ 0.772µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.1%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ format_noaspect

Time: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.9%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ index_aspect

Time: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.7%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ index_noaspect

Time: ✅ 0.276µs (SLO: <10.000µs 📉 -97.2%) vs baseline: ~same

Memory: ✅ 37.749MB (SLO: <39.000MB -3.2%) vs baseline: +5.1%

✅ join_aspect

Time: ✅ 1.388µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +1.9%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ join_noaspect

Time: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ ljust_aspect

Time: ✅ 2.623µs (SLO: <20.000µs 📉 -86.9%) vs baseline: ~same

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ ljust_noaspect

Time: ✅ 0.410µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.3%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ lower_aspect

Time: ✅ 2.247µs (SLO: <10.000µs 📉 -77.5%) vs baseline: +1.4%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.9%

✅ lower_noaspect

Time: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.8%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ lstrip_aspect

Time: ✅ 2.313µs (SLO: <20.000µs 📉 -88.4%) vs baseline: +2.0%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ lstrip_noaspect

Time: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ modulo_aspect

Time: ✅ 0.993µs (SLO: <10.000µs 📉 -90.1%) vs baseline: ~same

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 1.550µs (SLO: <10.000µs 📉 -84.5%) vs baseline: ~same

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ modulo_aspect_for_bytes

Time: ✅ 0.979µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -1.5%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 1.231µs (SLO: <10.000µs 📉 -87.7%) vs baseline: -1.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ modulo_noaspect

Time: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ replace_aspect

Time: ✅ 4.976µs (SLO: <10.000µs 📉 -50.2%) vs baseline: +0.9%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ replace_noaspect

Time: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.8%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ repr_aspect

Time: ✅ 0.907µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.5%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ repr_noaspect

Time: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.7%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ rstrip_aspect

Time: ✅ 1.988µs (SLO: <20.000µs 📉 -90.1%) vs baseline: +2.0%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ rstrip_noaspect

Time: ✅ 0.375µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.6%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ slice_aspect

Time: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ slice_noaspect

Time: ✅ 0.450µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.8%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ stringio_aspect

Time: ✅ 1.548µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.9%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ stringio_noaspect

Time: ✅ 0.723µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ strip_aspect

Time: ✅ 2.281µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +0.5%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2%

✅ strip_noaspect

Time: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ swapcase_aspect

Time: ✅ 2.459µs (SLO: <10.000µs 📉 -75.4%) vs baseline: +0.9%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ swapcase_noaspect

Time: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.3%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ title_aspect

Time: ✅ 2.476µs (SLO: <10.000µs 📉 -75.2%) vs baseline: +6.0%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ title_noaspect

Time: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ translate_aspect

Time: ✅ 3.481µs (SLO: <10.000µs 📉 -65.2%) vs baseline: +6.2%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ translate_noaspect

Time: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ upper_aspect

Time: ✅ 2.253µs (SLO: <10.000µs 📉 -77.5%) vs baseline: ~same

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ upper_noaspect

Time: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

📈 telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 3.139µs (SLO: <20.000µs 📉 -84.3%) vs baseline: -1.5%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0%

✅ 1-count-metrics-100-times

Time: ✅ 212.479µs (SLO: <250.000µs 📉 -15.0%) vs baseline: -1.2%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 1-distribution-metric-1-times

Time: ✅ 2.940µs (SLO: <20.000µs 📉 -85.3%) vs baseline: -0.7%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.1%

✅ 1-distribution-metrics-100-times

Time: ✅ 191.848µs (SLO: <220.000µs 📉 -12.8%) vs baseline: -0.3%

Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.5%

✅ 1-gauge-metric-1-times

Time: ✅ 2.368µs (SLO: <20.000µs 📉 -88.2%) vs baseline: 📈 +12.2%

Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1%

✅ 1-gauge-metrics-100-times

Time: ✅ 126.734µs (SLO: <150.000µs 📉 -15.5%) vs baseline: +0.7%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.8%

✅ 1-rate-metric-1-times

Time: ✅ 3.171µs (SLO: <20.000µs 📉 -84.1%) vs baseline: -1.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.0%

✅ 1-rate-metrics-100-times

Time: ✅ 214.399µs (SLO: <250.000µs 📉 -14.2%) vs baseline: -0.7%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6%

✅ 100-count-metrics-100-times

Time: ✅ 21.307ms (SLO: <23.500ms -9.3%) vs baseline: -0.6%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9%

✅ 100-distribution-metrics-100-times

Time: ✅ 2.028ms (SLO: <2.250ms -9.9%) vs baseline: +3.2%

Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6%

✅ 100-gauge-metrics-100-times

Time: ✅ 1.297ms (SLO: <1.550ms 📉 -16.3%) vs baseline: +1.4%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ 100-rate-metrics-100-times

Time: ✅ 2.189ms (SLO: <2.550ms 📉 -14.1%) vs baseline: -0.3%

Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.3%

✅ flush-1-metric

Time: ✅ 4.096µs (SLO: <20.000µs 📉 -79.5%) vs baseline: -1.7%

Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.5%

✅ flush-100-metrics

Time: ✅ 180.429µs (SLO: <250.000µs 📉 -27.8%) vs baseline: -1.9%

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ flush-1000-metrics

Time: ✅ 2.206ms (SLO: <2.500ms 📉 -11.8%) vs baseline: +1.2%

Memory: ✅ 32.893MB (SLO: <34.500MB -4.7%) vs baseline: +4.7%

🟡 Near SLO Breach (2 suites)
🟡 djangosimple - 28/28

✅ appsec

Time: ✅ 20.516ms (SLO: <22.300ms -8.0%) vs baseline: -0.1%

Memory: ✅ 65.252MB (SLO: <67.000MB -2.6%) vs baseline: +5.0%

✅ exception-replay-enabled

Time: ✅ 1.350ms (SLO: <1.450ms -6.9%) vs baseline: +0.6%

Memory: ✅ 64.065MB (SLO: <67.000MB -4.4%) vs baseline: +4.8%

✅ iast

Time: ✅ 20.501ms (SLO: <22.250ms -7.9%) vs baseline: +0.4%

Memory: ✅ 65.223MB (SLO: <67.000MB -2.7%) vs baseline: +4.8%

✅ profiler

Time: ✅ 15.336ms (SLO: <16.550ms -7.3%) vs baseline: +0.2%

Memory: ✅ 53.300MB (SLO: <54.500MB -2.2%) vs baseline: +4.5%

✅ span-code-origin

Time: ✅ 26.167ms (SLO: <28.200ms -7.2%) vs baseline: ~same

Memory: ✅ 67.441MB (SLO: <69.500MB -3.0%) vs baseline: +5.2%

✅ tracer

Time: ✅ 20.568ms (SLO: <21.750ms -5.4%) vs baseline: +0.3%

Memory: ✅ 65.245MB (SLO: <67.000MB -2.6%) vs baseline: +4.7%

✅ tracer-and-profiler

Time: ✅ 22.123ms (SLO: <23.500ms -5.9%) vs baseline: ~same

Memory: ✅ 66.367MB (SLO: <67.500MB 🟡 -1.7%) vs baseline: +5.0%

✅ tracer-dont-create-db-spans

Time: ✅ 19.346ms (SLO: <21.500ms 📉 -10.0%) vs baseline: -0.2%

Memory: ✅ 65.223MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8%

✅ tracer-minimal

Time: ✅ 16.601ms (SLO: <17.500ms -5.1%) vs baseline: -0.5%

Memory: ✅ 65.064MB (SLO: <66.000MB 🟡 -1.4%) vs baseline: +5.1%

✅ tracer-native

Time: ✅ 20.462ms (SLO: <21.750ms -5.9%) vs baseline: -0.2%

Memory: ✅ 71.093MB (SLO: <72.500MB 🟡 -1.9%) vs baseline: +4.8%

✅ tracer-no-caches

Time: ✅ 18.420ms (SLO: <19.650ms -6.3%) vs baseline: -0.2%

Memory: ✅ 65.284MB (SLO: <67.000MB -2.6%) vs baseline: +4.8%

✅ tracer-no-databases

Time: ✅ 18.765ms (SLO: <20.100ms -6.6%) vs baseline: -0.2%

Memory: ✅ 64.845MB (SLO: <67.000MB -3.2%) vs baseline: +4.7%

✅ tracer-no-middleware

Time: ✅ 20.204ms (SLO: <21.500ms -6.0%) vs baseline: +0.3%

Memory: ✅ 65.160MB (SLO: <67.000MB -2.7%) vs baseline: +4.6%

✅ tracer-no-templates

Time: ✅ 20.322ms (SLO: <22.000ms -7.6%) vs baseline: +0.2%

Memory: ✅ 65.280MB (SLO: <67.000MB -2.6%) vs baseline: +4.9%

🟡 otelspan - 22/22

✅ add-event

Time: ✅ 46.050ms (SLO: <47.150ms -2.3%) vs baseline: +2.0%

Memory: ✅ 45.004MB (SLO: <47.000MB -4.2%) vs baseline: +4.7%

✅ add-metrics

Time: ✅ 322.862ms (SLO: <344.800ms -6.4%) vs baseline: -0.2%

Memory: ✅ 553.128MB (SLO: <562.000MB 🟡 -1.6%) vs baseline: +4.6%

✅ add-tags

Time: ✅ 292.903ms (SLO: <314.000ms -6.7%) vs baseline: +0.4%

Memory: ✅ 554.668MB (SLO: <563.500MB 🟡 -1.6%) vs baseline: +4.6%

✅ get-context

Time: ✅ 82.800ms (SLO: <92.350ms 📉 -10.3%) vs baseline: +0.3%

Memory: ✅ 40.176MB (SLO: <46.500MB 📉 -13.6%) vs baseline: +4.9%

✅ is-recording

Time: ✅ 42.878ms (SLO: <44.500ms -3.6%) vs baseline: +0.1%

Memory: ✅ 44.407MB (SLO: <47.500MB -6.5%) vs baseline: +4.7%

✅ record-exception

Time: ✅ 61.649ms (SLO: <67.650ms -8.9%) vs baseline: +0.3%

Memory: ✅ 40.424MB (SLO: <47.000MB 📉 -14.0%) vs baseline: +4.7%

✅ set-status

Time: ✅ 49.573ms (SLO: <50.400ms 🟡 -1.6%) vs baseline: +1.9%

Memory: ✅ 44.416MB (SLO: <47.000MB -5.5%) vs baseline: +4.7%

✅ start

Time: ✅ 42.138ms (SLO: <43.450ms -3.0%) vs baseline: ~same

Memory: ✅ 44.397MB (SLO: <47.000MB -5.5%) vs baseline: +4.7%

✅ start-finish

Time: ✅ 84.537ms (SLO: <88.000ms -3.9%) vs baseline: +2.2%

Memory: ✅ 34.583MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +5.0%

✅ start-finish-telemetry

Time: ✅ 86.050ms (SLO: <89.000ms -3.3%) vs baseline: +2.1%

Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9%

✅ update-name

Time: ✅ 44.843ms (SLO: <45.150ms 🟡 -0.7%) vs baseline: +1.5%

Memory: ✅ 44.683MB (SLO: <47.000MB -4.9%) vs baseline: +4.8%

⚠️ Unstable Tests (1 suite)
⚠️ coreapiscenario - 12/12 (2 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.395µs (SLO: <20.000µs 📉 -33.0%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.9%

✅ context_with_data_no_listeners

Time: ✅ 3.380µs (SLO: <10.000µs 📉 -66.2%) vs baseline: -0.8%

Memory: ✅ 32.106MB (SLO: <33.500MB -4.2%) vs baseline: +4.7%

⚠️ context_with_data_only_all_listeners

Time: ⚠️ 13.419µs (SLO: <20.000µs 📉 -32.9%) vs baseline: +0.2%

Memory: ✅ 32.145MB (SLO: <33.500MB -4.0%) vs baseline: +4.9%

✅ get_item_exists

Time: ✅ 0.585µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -2.5%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ get_item_missing

Time: ✅ 0.639µs (SLO: <10.000µs 📉 -93.6%) vs baseline: -0.5%

Memory: ✅ 32.126MB (SLO: <33.500MB -4.1%) vs baseline: +4.7%

✅ set_item

Time: ✅ 24.338µs (SLO: <30.000µs 📉 -18.9%) vs baseline: +0.7%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +5.1%

✅ All Tests Passing (19 suites)
✅ errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 18.175ms (SLO: <19.850ms -8.4%) vs baseline: +0.8%

Memory: ✅ 64.951MB (SLO: <66.500MB -2.3%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 18.082ms (SLO: <19.400ms -6.8%) vs baseline: ~same

Memory: ✅ 65.015MB (SLO: <66.500MB -2.2%) vs baseline: +4.9%

✅ tracer-enabled

Time: ✅ 18.106ms (SLO: <19.450ms -6.9%) vs baseline: +0.2%

Memory: ✅ 64.861MB (SLO: <66.500MB -2.5%) vs baseline: +4.8%

✅ errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.090ms (SLO: <2.300ms -9.1%) vs baseline: +0.2%

Memory: ✅ 51.787MB (SLO: <53.500MB -3.2%) vs baseline: +4.8%

✅ errortracking-enabled-user

Time: ✅ 2.096ms (SLO: <2.250ms -6.8%) vs baseline: +0.3%

Memory: ✅ 51.846MB (SLO: <53.500MB -3.1%) vs baseline: +5.0%

✅ tracer-enabled

Time: ✅ 2.093ms (SLO: <2.300ms -9.0%) vs baseline: +0.3%

Memory: ✅ 51.728MB (SLO: <53.500MB -3.3%) vs baseline: +4.7%

✅ flasksimple - 16/16

✅ appsec-get

Time: ✅ 4.580ms (SLO: <4.750ms -3.6%) vs baseline: +0.2%

Memory: ✅ 62.738MB (SLO: <65.000MB -3.5%) vs baseline: +5.0%

✅ appsec-post

Time: ✅ 6.574ms (SLO: <6.750ms -2.6%) vs baseline: ~same

Memory: ✅ 63.033MB (SLO: <65.000MB -3.0%) vs baseline: +4.6%

✅ appsec-telemetry

Time: ✅ 4.584ms (SLO: <4.750ms -3.5%) vs baseline: -0.3%

Memory: ✅ 62.696MB (SLO: <65.000MB -3.5%) vs baseline: +4.8%

✅ debugger

Time: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same

Memory: ✅ 45.378MB (SLO: <47.000MB -3.5%) vs baseline: +4.9%

✅ iast-get

Time: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.4%

Memory: ✅ 41.909MB (SLO: <49.000MB 📉 -14.5%) vs baseline: +4.7%

✅ profiler

Time: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: ~same

Memory: ✅ 45.138MB (SLO: <47.000MB -4.0%) vs baseline: +4.9%

✅ tracer

Time: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: +0.2%

Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +5.0%

✅ tracer-native

Time: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: +0.2%

Memory: ✅ 57.960MB (SLO: <60.000MB -3.4%) vs baseline: +4.9%

✅ flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 3.945ms (SLO: <4.200ms -6.1%) vs baseline: -0.2%

Memory: ✅ 63.131MB (SLO: <66.000MB -4.3%) vs baseline: +4.9%

✅ iast-enabled

Time: ✅ 2.454ms (SLO: <2.800ms 📉 -12.4%) vs baseline: ~same

Memory: ✅ 58.589MB (SLO: <60.000MB -2.4%) vs baseline: +4.8%

✅ tracer-enabled

Time: ✅ 2.079ms (SLO: <2.250ms -7.6%) vs baseline: +0.4%

Memory: ✅ 51.846MB (SLO: <54.500MB -4.9%) vs baseline: +4.8%

✅ httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 81.715µs (SLO: <100.000µs 📉 -18.3%) vs baseline: +1.8%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ b3_headers

Time: ✅ 14.333µs (SLO: <20.000µs 📉 -28.3%) vs baseline: +1.1%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ b3_single_headers

Time: ✅ 13.559µs (SLO: <20.000µs 📉 -32.2%) vs baseline: +1.6%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 64.037µs (SLO: <80.000µs 📉 -20.0%) vs baseline: +1.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 65.977µs (SLO: <80.000µs 📉 -17.5%) vs baseline: ~same

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ empty_headers

Time: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.4%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.8%

✅ full_t_id_datadog_headers

Time: ✅ 22.709µs (SLO: <30.000µs 📉 -24.3%) vs baseline: -0.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_priority_header

Time: ✅ 6.606µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +1.2%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ invalid_span_id_header

Time: ✅ 6.544µs (SLO: <10.000µs 📉 -34.6%) vs baseline: -0.1%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ invalid_tags_header

Time: ✅ 6.513µs (SLO: <10.000µs 📉 -34.9%) vs baseline: +0.1%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ invalid_trace_id_header

Time: ✅ 6.608µs (SLO: <10.000µs 📉 -33.9%) vs baseline: +1.0%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ large_header_no_matches

Time: ✅ 27.639µs (SLO: <30.000µs -7.9%) vs baseline: +0.3%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ large_valid_headers_all

Time: ✅ 28.698µs (SLO: <40.000µs 📉 -28.3%) vs baseline: ~same

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ medium_header_no_matches

Time: ✅ 9.856µs (SLO: <20.000µs 📉 -50.7%) vs baseline: ~same

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ medium_valid_headers_all

Time: ✅ 11.244µs (SLO: <20.000µs 📉 -43.8%) vs baseline: +0.2%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ none_propagation_style

Time: ✅ 1.706µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +0.1%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ tracecontext_headers

Time: ✅ 34.496µs (SLO: <40.000µs 📉 -13.8%) vs baseline: +0.5%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ valid_headers_all

Time: ✅ 6.514µs (SLO: <10.000µs 📉 -34.9%) vs baseline: +0.2%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ valid_headers_basic

Time: ✅ 6.122µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.4%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.1%

✅ wsgi_empty_headers

Time: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_invalid_priority_header

Time: ✅ 6.644µs (SLO: <10.000µs 📉 -33.6%) vs baseline: +1.9%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_invalid_span_id_header

Time: ✅ 1.579µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -1.7%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_invalid_tags_header

Time: ✅ 6.551µs (SLO: <10.000µs 📉 -34.5%) vs baseline: -0.1%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ wsgi_invalid_trace_id_header

Time: ✅ 6.647µs (SLO: <10.000µs 📉 -33.5%) vs baseline: +0.4%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.8%

✅ wsgi_large_header_no_matches

Time: ✅ 28.802µs (SLO: <40.000µs 📉 -28.0%) vs baseline: +0.4%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_large_valid_headers_all

Time: ✅ 29.749µs (SLO: <40.000µs 📉 -25.6%) vs baseline: ~same

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ wsgi_medium_header_no_matches

Time: ✅ 10.118µs (SLO: <20.000µs 📉 -49.4%) vs baseline: +0.2%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ wsgi_medium_valid_headers_all

Time: ✅ 11.571µs (SLO: <20.000µs 📉 -42.1%) vs baseline: +0.8%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ wsgi_valid_headers_all

Time: ✅ 6.564µs (SLO: <10.000µs 📉 -34.4%) vs baseline: -0.1%

Memory: ✅ 32.204MB (SLO: <33.500MB -3.9%) vs baseline: +4.9%

✅ wsgi_valid_headers_basic

Time: ✅ 6.098µs (SLO: <10.000µs 📉 -39.0%) vs baseline: -0.4%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ httppropagationinject - 16/16

✅ ids_only

Time: ✅ 21.749µs (SLO: <30.000µs 📉 -27.5%) vs baseline: -0.4%

Memory: ✅ 32.185MB (SLO: <33.500MB -3.9%) vs baseline: +4.7%

✅ with_all

Time: ✅ 29.060µs (SLO: <40.000µs 📉 -27.4%) vs baseline: +0.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_dd_origin

Time: ✅ 25.492µs (SLO: <30.000µs 📉 -15.0%) vs baseline: +0.3%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_priority_and_origin

Time: ✅ 24.802µs (SLO: <40.000µs 📉 -38.0%) vs baseline: -0.2%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +5.0%

✅ with_sampling_priority

Time: ✅ 21.840µs (SLO: <30.000µs 📉 -27.2%) vs baseline: +0.9%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_tags

Time: ✅ 27.215µs (SLO: <40.000µs 📉 -32.0%) vs baseline: -0.5%

Memory: ✅ 32.165MB (SLO: <33.500MB -4.0%) vs baseline: +4.7%

✅ with_tags_invalid

Time: ✅ 29.628µs (SLO: <40.000µs 📉 -25.9%) vs baseline: +3.4%

Memory: ✅ 32.224MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ with_tags_max_size

Time: ✅ 29.029µs (SLO: <40.000µs 📉 -27.4%) vs baseline: +5.0%

Memory: ✅ 32.244MB (SLO: <33.500MB -3.8%) vs baseline: +4.9%

✅ iast_aspects - 40/40

✅ re_expand_aspect

Time: ✅ 31.973µs (SLO: <40.000µs 📉 -20.1%) vs baseline: +0.7%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_expand_noaspect

Time: ✅ 28.553µs (SLO: <40.000µs 📉 -28.6%) vs baseline: -0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_findall_aspect

Time: ✅ 2.907µs (SLO: <10.000µs 📉 -70.9%) vs baseline: +0.6%

Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +4.5%

✅ re_findall_noaspect

Time: ✅ 1.424µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +0.6%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_finditer_aspect

Time: ✅ 4.532µs (SLO: <10.000µs 📉 -54.7%) vs baseline: +0.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ re_finditer_noaspect

Time: ✅ 1.405µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +0.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_fullmatch_aspect

Time: ✅ 2.799µs (SLO: <10.000µs 📉 -72.0%) vs baseline: -0.2%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ re_fullmatch_noaspect

Time: ✅ 1.286µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +0.1%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_group_aspect

Time: ✅ 3.140µs (SLO: <10.000µs 📉 -68.6%) vs baseline: +4.4%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_group_noaspect

Time: ✅ 1.602µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.5%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_groups_aspect

Time: ✅ 3.133µs (SLO: <10.000µs 📉 -68.7%) vs baseline: -0.7%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.1%

✅ re_groups_noaspect

Time: ✅ 1.695µs (SLO: <10.000µs 📉 -83.1%) vs baseline: ~same

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ re_match_aspect

Time: ✅ 2.856µs (SLO: <10.000µs 📉 -71.4%) vs baseline: -0.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ re_match_noaspect

Time: ✅ 1.303µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +1.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ re_search_aspect

Time: ✅ 2.731µs (SLO: <10.000µs 📉 -72.7%) vs baseline: +3.1%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ re_search_noaspect

Time: ✅ 1.203µs (SLO: <10.000µs 📉 -88.0%) vs baseline: ~same

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ re_sub_aspect

Time: ✅ 3.495µs (SLO: <10.000µs 📉 -65.1%) vs baseline: +0.2%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ re_sub_noaspect

Time: ✅ 1.538µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.7%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ re_subn_aspect

Time: ✅ 3.672µs (SLO: <10.000µs 📉 -63.3%) vs baseline: -1.2%

Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ re_subn_noaspect

Time: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -1.2%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 4.333µs (SLO: <10.000µs 📉 -56.7%) vs baseline: -0.6%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ ospathbasename_noaspect

Time: ✅ 1.081µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.3%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ ospathjoin_aspect

Time: ✅ 6.080µs (SLO: <10.000µs 📉 -39.2%) vs baseline: +0.2%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ ospathjoin_noaspect

Time: ✅ 2.299µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.4%

Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.6%

✅ ospathnormcase_aspect

Time: ✅ 3.504µs (SLO: <10.000µs 📉 -65.0%) vs baseline: +0.7%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0%

✅ ospathnormcase_noaspect

Time: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +1.0%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ ospathsplit_aspect

Time: ✅ 4.967µs (SLO: <10.000µs 📉 -50.3%) vs baseline: +0.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ ospathsplit_noaspect

Time: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.5%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1%

✅ ospathsplitdrive_aspect

Time: ✅ 3.711µs (SLO: <10.000µs 📉 -62.9%) vs baseline: -0.5%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.6%

✅ ospathsplitdrive_noaspect

Time: ✅ 0.694µs (SLO: <10.000µs 📉 -93.1%) vs baseline: +0.1%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ ospathsplitext_aspect

Time: ✅ 4.591µs (SLO: <10.000µs 📉 -54.1%) vs baseline: -0.3%

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ ospathsplitext_noaspect

Time: ✅ 1.374µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.2%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 1.466µs (SLO: <10.000µs 📉 -85.3%) vs baseline: +0.6%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ rsplit_noaspect

Time: ✅ 0.584µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +1.2%

Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.9%

✅ split_aspect

Time: ✅ 1.453µs (SLO: <10.000µs 📉 -85.5%) vs baseline: +1.0%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9%

✅ split_noaspect

Time: ✅ 0.573µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.7%

Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7%

✅ splitlines_aspect

Time: ✅ 1.548µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +7.2%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.2%

✅ splitlines_noaspect

Time: ✅ 0.581µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -0.4%

Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7%

✅ iastpropagation - 8/8

✅ no-propagation

Time: ✅ 48.743µs (SLO: <60.000µs 📉 -18.8%) vs baseline: ~same

Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8%

✅ propagation_enabled

Time: ✅ 172.012µs (SLO: <190.000µs -9.5%) vs baseline: -0.3%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.0%

✅ propagation_enabled_100

Time: ✅ 1.948ms (SLO: <2.300ms 📉 -15.3%) vs baseline: +1.8%

Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +4.9%

✅ propagation_enabled_1000

Time: ✅ 32.611ms (SLO: <34.550ms -5.6%) vs baseline: +0.4%

Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8%

✅ otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.677ms (SLO: <42.000ms -3.1%) vs baseline: +0.6%

Memory: ✅ 34.406MB (SLO: <39.000MB 📉 -11.8%) vs baseline: +4.5%

✅ add-link

Time: ✅ 36.230ms (SLO: <38.550ms -6.0%) vs baseline: -0.6%

Memory: ✅ 34.564MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 218.104ms (SLO: <232.000ms -6.0%) vs baseline: -0.2%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.8%

✅ add-tags

Time: ✅ 209.503ms (SLO: <221.600ms -5.5%) vs baseline: -2.3%

Memory: ✅ 34.505MB (SLO: <39.000MB 📉 -11.5%) vs baseline: +4.9%

✅ get-context

Time: ✅ 29.238ms (SLO: <31.300ms -6.6%) vs baseline: -0.1%

Memory: ✅ 34.564MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.2%

✅ is-recording

Time: ✅ 29.209ms (SLO: <31.000ms -5.8%) vs baseline: -0.2%

Memory: ✅ 34.564MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.2%

✅ record-exception

Time: ✅ 63.068ms (SLO: <65.850ms -4.2%) vs baseline: -0.3%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.1%

✅ set-status

Time: ✅ 32.198ms (SLO: <34.150ms -5.7%) vs baseline: +1.0%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ start

Time: ✅ 28.956ms (SLO: <30.150ms -4.0%) vs baseline: +0.2%

Memory: ✅ 34.544MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ start-finish

Time: ✅ 33.863ms (SLO: <35.350ms -4.2%) vs baseline: -0.7%

Memory: ✅ 34.564MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +5.1%

✅ start-finish-telemetry

Time: ✅ 33.886ms (SLO: <35.450ms -4.4%) vs baseline: +0.1%

Memory: ✅ 34.583MB (SLO: <39.000MB 📉 -11.3%) vs baseline: +5.1%

✅ update-name

Time: ✅ 31.057ms (SLO: <33.400ms -7.0%) vs baseline: -0.7%

Memory: ✅ 34.564MB (SLO: <39.000MB 📉 -11.4%) vs baseline: +4.9%

✅ packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 341.215ms (SLO: <354.300ms -3.7%) vs baseline: ~same

Memory: ✅ 38.086MB (SLO: <40.000MB -4.8%) vs baseline: +5.8%

✅ cache_on

Time: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.4%

Memory: ✅ 35.556MB (SLO: <39.000MB -8.8%) vs baseline: +4.6%

✅ packagesupdateimporteddependencies - 24/24

✅ import_many

Time: ✅ 155.349µs (SLO: <170.000µs -8.6%) vs baseline: +0.6%

Memory: ✅ 36.676MB (SLO: <38.500MB -4.7%) vs baseline: +4.8%

✅ import_many_cached

Time: ✅ 121.375µs (SLO: <130.000µs -6.6%) vs baseline: +0.6%

Memory: ✅ 36.445MB (SLO: <38.500MB -5.3%) vs baseline: +4.5%

✅ import_many_stdlib

Time: ✅ 1.603ms (SLO: <1.750ms -8.4%) vs baseline: +0.1%

Memory: ✅ 36.669MB (SLO: <38.500MB -4.8%) vs baseline: +4.4%

✅ import_many_stdlib_cached

Time: ✅ 0.968ms (SLO: <1.100ms 📉 -12.0%) vs baseline: +0.5%

Memory: ✅ 36.488MB (SLO: <38.500MB -5.2%) vs baseline: +4.3%

✅ import_many_unknown

Time: ✅ 835.449µs (SLO: <890.000µs -6.1%) vs baseline: +0.6%

Memory: ✅ 36.665MB (SLO: <38.500MB -4.8%) vs baseline: +4.6%

✅ import_many_unknown_cached

Time: ✅ 794.933µs (SLO: <870.000µs -8.6%) vs baseline: ~same

Memory: ✅ 36.754MB (SLO: <38.500MB -4.5%) vs baseline: +4.9%

✅ import_one

Time: ✅ 19.729µs (SLO: <30.000µs 📉 -34.2%) vs baseline: ~same

Memory: ✅ 36.554MB (SLO: <39.000MB -6.3%) vs baseline: +4.6%

✅ import_one_cache

Time: ✅ 6.278µs (SLO: <10.000µs 📉 -37.2%) vs baseline: +0.2%

Memory: ✅ 36.592MB (SLO: <38.500MB -5.0%) vs baseline: +5.0%

✅ import_one_stdlib

Time: ✅ 18.647µs (SLO: <20.000µs -6.8%) vs baseline: +0.1%

Memory: ✅ 36.621MB (SLO: <38.500MB -4.9%) vs baseline: +4.8%

✅ import_one_stdlib_cache

Time: ✅ 6.297µs (SLO: <10.000µs 📉 -37.0%) vs baseline: +0.3%

Memory: ✅ 36.564MB (SLO: <38.500MB -5.0%) vs baseline: +4.5%

✅ import_one_unknown

Time: ✅ 45.298µs (SLO: <50.000µs -9.4%) vs baseline: -0.5%

Memory: ✅ 36.598MB (SLO: <38.500MB -4.9%) vs baseline: +4.9%

✅ import_one_unknown_cache

Time: ✅ 6.273µs (SLO: <10.000µs 📉 -37.3%) vs baseline: -0.2%

Memory: ✅ 36.588MB (SLO: <38.500MB -5.0%) vs baseline: +4.8%

✅ ratelimiter - 12/12

✅ defaults

Time: ✅ 2.352µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.8%

Memory: ✅ 31.359MB (SLO: <34.000MB -7.8%) vs baseline: +3.5%

✅ high_rate_limit

Time: ✅ 2.407µs (SLO: <10.000µs 📉 -75.9%) vs baseline: -0.3%

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +4.8%

✅ long_window

Time: ✅ 2.354µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.7%

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +4.9%

✅ low_rate_limit

Time: ✅ 2.374µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +0.2%

Memory: ✅ 31.693MB (SLO: <34.000MB -6.8%) vs baseline: +4.6%

✅ no_rate_limit

Time: ✅ 0.829µs (SLO: <10.000µs 📉 -91.7%) vs baseline: -0.6%

Memory: ✅ 31.772MB (SLO: <34.000MB -6.6%) vs baseline: +5.0%

✅ short_window

Time: ✅ 2.504µs (SLO: <10.000µs 📉 -75.0%) vs baseline: +0.6%

Memory: ✅ 31.379MB (SLO: <34.000MB -7.7%) vs baseline: +3.9%

✅ recursivecomputation - 8/8

✅ deep

Time: ✅ 308.532ms (SLO: <320.950ms -3.9%) vs baseline: -0.1%

Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +4.7%

✅ deep-profiled

Time: ✅ 326.377ms (SLO: <359.150ms -9.1%) vs baseline: ~same

Memory: ✅ 36.038MB (SLO: <39.000MB -7.6%) vs baseline: +4.8%

✅ medium

Time: ✅ 7.069ms (SLO: <7.400ms -4.5%) vs baseline: ~same

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7%

✅ shallow

Time: ✅ 0.953ms (SLO: <1.050ms -9.3%) vs baseline: -0.2%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.0%

✅ samplingrules - 8/8

✅ average_match

Time: ✅ 149.091µs (SLO: <290.000µs 📉 -48.6%) vs baseline: +0.2%

Memory: ✅ 31.733MB (SLO: <34.000MB -6.7%) vs baseline: +4.8%

✅ high_match

Time: ✅ 196.827µs (SLO: <480.000µs 📉 -59.0%) vs baseline: ~same

Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +5.1%

✅ low_match

Time: ✅ 100.178µs (SLO: <120.000µs 📉 -16.5%) vs baseline: +0.7%

Memory: ✅ 632.392MB (SLO: <700.000MB -9.7%) vs baseline: +4.9%

✅ very_low_match

Time: ✅ 2.908ms (SLO: <8.500ms 📉 -65.8%) vs baseline: +0.4%

Memory: ✅ 70.092MB (SLO: <75.000MB -6.5%) vs baseline: +4.8%

✅ sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.605µs (SLO: <20.000µs 📉 -47.0%) vs baseline: -0.6%

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.7%

✅ all-enabled

Time: ✅ 39.917µs (SLO: <50.000µs 📉 -20.2%) vs baseline: -0.5%

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.7%

✅ collectipvariant_exists

Time: ✅ 40.657µs (SLO: <50.000µs 📉 -18.7%) vs baseline: -0.7%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.8%

✅ no-collectipvariant

Time: ✅ 39.785µs (SLO: <50.000µs 📉 -20.4%) vs baseline: -0.5%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ no-useragentvariant

Time: ✅ 38.880µs (SLO: <50.000µs 📉 -22.2%) vs baseline: +0.6%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.8%

✅ obfuscation-no-query

Time: ✅ 40.489µs (SLO: <50.000µs 📉 -19.0%) vs baseline: ~same

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.7%

✅ obfuscation-regular-case-explicit-query

Time: ✅ 75.602µs (SLO: <90.000µs 📉 -16.0%) vs baseline: ~same

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.9%

✅ obfuscation-regular-case-implicit-query

Time: ✅ 75.976µs (SLO: <90.000µs 📉 -15.6%) vs baseline: ~same

Memory: ✅ 32.499MB (SLO: <34.000MB -4.4%) vs baseline: +4.8%

✅ obfuscation-send-querystring-disabled

Time: ✅ 153.773µs (SLO: <170.000µs -9.5%) vs baseline: +0.2%

Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%) vs baseline: +5.0%

✅ obfuscation-worst-case-explicit-query

Time: ✅ 147.813µs (SLO: <160.000µs -7.6%) vs baseline: ~same

Memory: ✅ 32.558MB (SLO: <34.500MB -5.6%) vs baseline: +3.6%

✅ obfuscation-worst-case-implicit-query

Time: ✅ 154.228µs (SLO: <170.000µs -9.3%) vs baseline: ~same

Memory: ✅ 32.558MB (SLO: <34.500MB -5.6%) vs baseline: +4.7%

✅ useragentvariant_exists_1

Time: ✅ 39.489µs (SLO: <50.000µs 📉 -21.0%) vs baseline: +0.3%

Memory: ✅ 32.637MB (SLO: <34.000MB -4.0%) vs baseline: +5.0%

✅ useragentvariant_exists_2

Time: ✅ 40.304µs (SLO: <50.000µs 📉 -19.4%) vs baseline: -1.0%

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ useragentvariant_exists_3

Time: ✅ 39.983µs (SLO: <50.000µs 📉 -20.0%) vs baseline: ~same

Memory: ✅ 32.578MB (SLO: <34.000MB -4.2%) vs baseline: +4.9%

✅ useragentvariant_not_exists_1

Time: ✅ 39.237µs (SLO: <50.000µs 📉 -21.5%) vs baseline: -0.6%

Memory: ✅ 32.539MB (SLO: <34.000MB -4.3%) vs baseline: +4.8%

✅ useragentvariant_not_exists_2

Time: ✅ 39.162µs (SLO: <50.000µs 📉 -21.7%) vs baseline: -0.7%

Memory: ✅ 32.558MB (SLO: <34.000MB -4.2%) vs baseline: +4.7%

✅ span - 26/26

✅ add-event

Time: ✅ 24.266ms (SLO: <26.200ms -7.4%) vs baseline: +0.3%

Memory: ✅ 51.582MB (SLO: <53.000MB -2.7%) vs baseline: +4.9%

✅ add-metrics

Time: ✅ 91.376ms (SLO: <98.350ms -7.1%) vs baseline: -0.8%

Memory: ✅ 607.439MB (SLO: <961.000MB 📉 -36.8%) vs baseline: +4.9%

✅ add-tags

Time: ✅ 150.246ms (SLO: <168.550ms 📉 -10.9%) vs baseline: ~same

Memory: ✅ 606.853MB (SLO: <962.500MB 📉 -37.0%) vs baseline: +4.9%

✅ get-context

Time: ✅ 22.188ms (SLO: <23.700ms -6.4%) vs baseline: -0.4%

Memory: ✅ 50.447MB (SLO: <53.000MB -4.8%) vs baseline: +5.1%

✅ is-recording

Time: ✅ 22.752ms (SLO: <23.900ms -4.8%) vs baseline: +0.5%

Memory: ✅ 50.323MB (SLO: <53.000MB -5.1%) vs baseline: +4.8%

✅ record-exception

Time: ✅ 43.140ms (SLO: <44.500ms -3.1%) vs baseline: +1.6%

Memory: ✅ 43.370MB (SLO: <53.000MB 📉 -18.2%) vs baseline: +5.0%

✅ set-status

Time: ✅ 24.362ms (SLO: <26.000ms -6.3%) vs baseline: +0.9%

Memory: ✅ 50.260MB (SLO: <53.000MB -5.2%) vs baseline: +4.6%

✅ start

Time: ✅ 22.119ms (SLO: <23.500ms -5.9%) vs baseline: +0.1%

Memory: ✅ 50.389MB (SLO: <53.000MB -4.9%) vs baseline: +5.0%

✅ start-finish

Time: ✅ 52.098ms (SLO: <55.500ms -6.1%) vs baseline: +0.1%

Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9%

✅ start-finish-telemetry

Time: ✅ 53.664ms (SLO: <58.300ms -8.0%) vs baseline: +0.3%

Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.2%

✅ start-finish-traceid128

Time: ✅ 56.112ms (SLO: <60.050ms -6.6%) vs baseline: +1.4%

Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8%

✅ start-traceid128

Time: ✅ 22.698ms (SLO: <24.600ms -7.7%) vs baseline: +0.8%

Memory: ✅ 50.357MB (SLO: <53.000MB -5.0%) vs baseline: +4.8%

✅ update-name

Time: ✅ 23.107ms (SLO: <24.100ms -4.1%) vs baseline: +1.0%

Memory: ✅ 51.044MB (SLO: <53.000MB -3.7%) vs baseline: +4.9%

✅ tracer - 6/6

✅ large

Time: ✅ 30.489ms (SLO: <32.950ms -7.5%) vs baseline: -0.5%

Memory: ✅ 33.286MB (SLO: <34.500MB -3.5%) vs baseline: +4.7%

✅ medium

Time: ✅ 3.015ms (SLO: <3.200ms -5.8%) vs baseline: +1.7%

Memory: ✅ 31.752MB (SLO: <34.000MB -6.6%) vs baseline: +4.8%

✅ small

Time: ✅ 340.785µs (SLO: <370.000µs -7.9%) vs baseline: +0.7%

Memory: ✅ 31.674MB (SLO: <34.000MB -6.8%) vs baseline: +4.6%

ℹ️ Scenarios Missing SLO Configuration (14 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-context_with_data_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_only_all_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_listeners_and_all_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • coreapiscenario-core_dispatch_with_results_only_all_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline

@gyuheon0h gyuheon0h marked this pull request as ready for review September 19, 2025 19:12
@gyuheon0h gyuheon0h requested review from a team as code owners September 19, 2025 19:12
@gyuheon0h gyuheon0h requested a review from juanjux September 19, 2025 19:12
taegyunkim
taegyunkim reviewed Sep 19, 2025
View reviewed changes
@taegyunkim
Copy link
Contributor

Needs formatting to trigger tests https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1139163210

Style
00:28
Creating environment: lint
Checking dependencies
Syncing dependencies
cmd [1] | black --check .
would reformat /go/src/github.com/DataDog/apm-reliability/dd-trace-py/tests/internal/crashtracker/utils.py
Oh no! 💥 💔 💥
1 file would be reformatted, 2216 files would be left unchanged.

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/fix-flaky-test branch from 77f4d62 to f6ae194 Compare September 21, 2025 19:58
@gyuheon0h gyuheon0h merged commit f98e713 into main Sep 22, 2025
902 checks passed
@gyuheon0h gyuheon0h deleted the gyuheon0h/fix-flaky-test branch September 22, 2025 17:26
vlad-scherbich pushed a commit that referenced this pull request Sep 22, 2025
@gyuheon0h @vlad-scherbich
chore(crashtracking): fix flaky test around receiving crash messages (#…
6dfc363 
…14654)

## Description


[Ticket](https://datadoghq.atlassian.net/jira/software/c/projects/PROF/boards/11?selectedIssue=PROF-12582)

This PR renames the function `wait_for_crash_reports` to
`wait_for_crash_messages` and other uses of `reports` to `messages`
where necessary. This is because the crashtracker emits two types of
messages, crash reports and crash pings, so it is misleading to call
both as crash reports.

This PR also does a bit of updating of logic around how we set up our
mock client to handle crash messages. Now, the crash tracker sends two
messages, `crash_ping` and `crash_report`. The `wait_for_crash_reports`
used to work by spinning for `N` cycles and each time, calling
`TestAgentClient.crash_reports()`, which was a function that returned
all the requests originated from crashtracker within that test session.
The previous logic would then accumulate all the requests returned by
the `TestAgentClient`. However, this logic was flawed. Consider this
case


---------- Cycle 1 ---------- 
`crash_ping` arrives to client
TestAgentClient.crash_reports() -> [`crash_ping`]
accumulated requests = [`crash_ping`]
---------- Cycle 2 ---------- 
`crash_report` arrives to client
TestAgentClient.crash_reports() -> [`crash_ping`, `crash_report`]
accumulated requests = [`crash_ping`, `crash_ping`, `crash_report`]

We just duplicated `crash_ping`! This is not a problem if both
`crash_ping` and `crash_report` arrive in the same cycle of waiting for
crash reports, as then, we would have >=2 messages and exit early.
However, if we receive `crash_ping` and `crash_report` in different
cycles, we end up duplicating one of them.


This issue was identified by noticing many failures of the crashtracking
tests, [because we got 3 messages instead of
2.](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1137159305)
<img width="760" height="209" alt="Screenshot 2025-09-19 at 3 04 58 PM"
src="https://github.com/user-attachments/assets/b7678023-0219-412b-ada9-33e708d10159"
/>




## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->
@gyuheon0h gyuheon0h mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmettbutler emmettbutler emmettbutler approved these changes

@juanjux juanjux Awaiting requested review from juanjux juanjux is a code owner automatically assigned from DataDog/apm-core-python

@taegyunkim taegyunkim Awaiting requested review from taegyunkim

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gyuheon0h @taegyunkim @emmettbutler