-
Notifications
You must be signed in to change notification settings - Fork 457
ci: update testagent version and use vcr ci mode #14651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 283 ± 4 ms. The average import time from base is: 286 ± 6 ms. The import time difference between this PR and base is: -3.2 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate sabrenner/testagent-update-vcr-ci (f66c469) with baseline main (e806495) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.231µs (SLO: <20.000µs 📉 -83.8%) vs baseline: +3.0% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 215.308µs (SLO: <250.000µs 📉 -13.9%) vs baseline: +1.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.072µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +4.9% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 192.106µs (SLO: <220.000µs 📉 -12.7%) vs baseline: +0.6% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.397µs (SLO: <20.000µs 📉 -88.0%) vs baseline: 📈 +15.9% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 126.329µs (SLO: <150.000µs 📉 -15.8%) vs baseline: +1.5% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.258µs (SLO: <20.000µs 📉 -83.7%) vs baseline: +4.5% Memory: ✅ 32.067MB (SLO: <34.000MB -5.7%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 212.453µs (SLO: <250.000µs 📉 -15.0%) vs baseline: -0.2% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 21.498ms (SLO: <23.500ms -8.5%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.015ms (SLO: <2.250ms 📉 -10.4%) vs baseline: +2.6% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.298ms (SLO: <1.550ms 📉 -16.3%) vs baseline: +1.3% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.202ms (SLO: <2.550ms 📉 -13.7%) vs baseline: +1.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +5.2% ✅ flush-1-metricTime: ✅ 4.120µs (SLO: <20.000µs 📉 -79.4%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 181.200µs (SLO: <250.000µs 📉 -27.5%) vs baseline: +0.4% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.189ms (SLO: <2.500ms 📉 -12.4%) vs baseline: -0.1% Memory: ✅ 32.873MB (SLO: <34.500MB -4.7%) vs baseline: +5.0% 🟡 Near SLO Breach (2 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 20.541ms (SLO: <22.300ms -7.9%) vs baseline: +0.1% Memory: ✅ 65.222MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.349ms (SLO: <1.450ms -6.9%) vs baseline: ~same Memory: ✅ 64.117MB (SLO: <67.000MB -4.3%) vs baseline: +4.9% ✅ iastTime: ✅ 20.534ms (SLO: <22.250ms -7.7%) vs baseline: +0.5% Memory: ✅ 65.280MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.282ms (SLO: <16.550ms -7.7%) vs baseline: ~same Memory: ✅ 53.364MB (SLO: <54.500MB -2.1%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 26.119ms (SLO: <28.200ms -7.4%) vs baseline: -0.2% Memory: ✅ 67.454MB (SLO: <69.500MB -2.9%) vs baseline: +3.5% ✅ tracerTime: ✅ 20.532ms (SLO: <21.750ms -5.6%) vs baseline: +0.1% Memory: ✅ 65.183MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.072ms (SLO: <23.500ms -6.1%) vs baseline: ~same Memory: ✅ 66.454MB (SLO: <67.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.284ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.5% Memory: ✅ 65.180MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.661ms (SLO: <17.500ms -4.8%) vs baseline: -0.2% Memory: ✅ 64.839MB (SLO: <66.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.421ms (SLO: <21.750ms -6.1%) vs baseline: -0.5% Memory: ✅ 70.936MB (SLO: <72.500MB -2.2%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.501ms (SLO: <19.650ms -5.8%) vs baseline: ~same Memory: ✅ 65.227MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.774ms (SLO: <20.100ms -6.6%) vs baseline: ~same Memory: ✅ 64.805MB (SLO: <67.000MB -3.3%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.181ms (SLO: <21.500ms -6.1%) vs baseline: ~same Memory: ✅ 65.238MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.335ms (SLO: <22.000ms -7.6%) vs baseline: +0.5% Memory: ✅ 65.225MB (SLO: <67.000MB -2.6%) vs baseline: +5.0% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.077ms (SLO: <47.150ms -4.4%) vs baseline: -0.5% Memory: ✅ 45.087MB (SLO: <47.000MB -4.1%) vs baseline: +4.8% ✅ add-metricsTime: ✅ 322.616ms (SLO: <344.800ms -6.4%) vs baseline: -0.4% Memory: ✅ 552.714MB (SLO: <562.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 291.423ms (SLO: <314.000ms -7.2%) vs baseline: -1.0% Memory: ✅ 553.607MB (SLO: <563.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ get-contextTime: ✅ 82.785ms (SLO: <92.350ms 📉 -10.4%) vs baseline: ~same Memory: ✅ 40.114MB (SLO: <46.500MB 📉 -13.7%) vs baseline: +4.6% ✅ is-recordingTime: ✅ 43.090ms (SLO: <44.500ms -3.2%) vs baseline: ~same Memory: ✅ 44.433MB (SLO: <47.500MB -6.5%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 61.678ms (SLO: <67.650ms -8.8%) vs baseline: -0.3% Memory: ✅ 40.476MB (SLO: <47.000MB 📉 -13.9%) vs baseline: +5.0% ✅ set-statusTime: ✅ 48.893ms (SLO: <50.400ms -3.0%) vs baseline: +0.4% Memory: ✅ 44.437MB (SLO: <47.000MB -5.5%) vs baseline: +4.7% ✅ startTime: ✅ 42.192ms (SLO: <43.450ms -2.9%) vs baseline: -0.1% Memory: ✅ 44.463MB (SLO: <47.000MB -5.4%) vs baseline: +4.8% ✅ start-finishTime: ✅ 83.215ms (SLO: <88.000ms -5.4%) vs baseline: +0.2% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.941ms (SLO: <89.000ms -4.6%) vs baseline: +0.4% Memory: ✅ 34.544MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.8% ✅ update-nameTime: ✅ 44.127ms (SLO: <45.150ms -2.3%) vs baseline: +0.4% Memory: ✅ 44.682MB (SLO: <47.000MB -4.9%) vs baseline: +5.0%
|
Description
Updates the testagent version to 1.34.0, which added a CI mode for the VCR proxy feature, which throws if a cassette is missing for a given proxied request.
Testing
I will include a commit that removes a cassette for one of our (LLM Observability) tests, and will attach the output from CI here. Then, the commit will be reverted.
Additionally, I verified that running the container locally did just end up re-generating the cassette.
Risks
None