ci: remove PR checklist requirement [backport 3.14] #14648
Conversation
![dd-octo-sts[bot]](https://avatars.githubusercontent.com/in/1157446?s=60&v=4){kind=small}
dd-octo-sts
bot
added
the
changelog/no-changelog
dd-octo-sts
bot
added
the
changelog/no-changelog
|
|
## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 3dcf919)
brettlangdon
force-pushed
the
backport-14628-to-3.14
branch
from
2e06859 to
041c9f4
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 3 ms. The average import time from base is: 277 ± 4 ms. The import time difference between this PR and base is: -4.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-14628-to-3.14 (041c9f4) with baseline 3.14 (69c197c) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.155µs (SLO: <10.000µs 📉 -58.4%) vs baseline: +0.2% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.077µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.7% Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.044µs (SLO: <10.000µs 📉 -39.6%) vs baseline: +1.2% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 2.280µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.5% Memory: ✅ 37.513MB (SLO: <39.000MB -3.8%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.409µs (SLO: <10.000µs 📉 -65.9%) vs baseline: +0.3% Memory: ✅ 37.395MB (SLO: <39.000MB -4.1%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same Memory: ✅ 37.415MB (SLO: <39.000MB -4.1%) vs baseline: +4.5% ✅ ospathsplit_aspectTime: ✅ 5.944µs (SLO: <10.000µs 📉 -40.6%) vs baseline: 📈 +25.1% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.600µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +1.2% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.591µs (SLO: <10.000µs 📉 -64.1%) vs baseline: +0.2% Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +2.4% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 5.381µs (SLO: <10.000µs 📉 -46.2%) vs baseline: 📈 +20.2% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.7% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.234µs (SLO: <20.000µs 📉 -83.8%) vs baseline: +1.5% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 224.074µs (SLO: <250.000µs 📉 -10.4%) vs baseline: +3.5% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 2.976µs (SLO: <20.000µs 📉 -85.1%) vs baseline: -0.9% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 197.963µs (SLO: <220.000µs 📉 -10.0%) vs baseline: +1.4% Memory: ✅ 31.477MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.467µs (SLO: <20.000µs 📉 -87.7%) vs baseline: 📈 +17.9% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 124.848µs (SLO: <150.000µs 📉 -16.8%) vs baseline: ~same Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.199µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +0.4% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 221.277µs (SLO: <250.000µs 📉 -11.5%) vs baseline: +1.5% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 21.938ms (SLO: <23.500ms -6.6%) vs baseline: +1.2% Memory: ✅ 31.457MB (SLO: <34.000MB -7.5%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.138ms (SLO: <2.250ms -5.0%) vs baseline: +5.1% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.287ms (SLO: <1.550ms 📉 -17.0%) vs baseline: +0.7% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.259ms (SLO: <2.550ms 📉 -11.4%) vs baseline: +2.0% Memory: ✅ 31.497MB (SLO: <34.000MB -7.4%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.261µs (SLO: <20.000µs 📉 -78.7%) vs baseline: -0.7% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 181.483µs (SLO: <250.000µs 📉 -27.4%) vs baseline: -0.3% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.227ms (SLO: <2.500ms 📉 -10.9%) vs baseline: -1.7% Memory: ✅ 32.676MB (SLO: <34.500MB -5.3%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 26/26✅ appsecTime: ✅ 20.483ms (SLO: <22.300ms -8.1%) vs baseline: -0.5% Memory: ✅ 64.369MB (SLO: <66.000MB -2.5%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.360ms (SLO: <1.450ms -6.2%) vs baseline: -0.6% Memory: ✅ 63.257MB (SLO: <66.000MB -4.2%) vs baseline: +4.8% ✅ iastTime: ✅ 20.500ms (SLO: <22.250ms -7.9%) vs baseline: -0.3% Memory: ✅ 64.428MB (SLO: <66.000MB -2.4%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.273ms (SLO: <16.550ms -7.7%) vs baseline: +0.4% Memory: ✅ 52.947MB (SLO: <53.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.983ms (SLO: <28.200ms -7.9%) vs baseline: -0.7% Memory: ✅ 66.339MB (SLO: <68.500MB -3.2%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.492ms (SLO: <21.750ms -5.8%) vs baseline: -0.2% Memory: ✅ 64.468MB (SLO: <66.000MB -2.3%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.118ms (SLO: <23.500ms -5.9%) vs baseline: -0.5% Memory: ✅ 65.637MB (SLO: <67.000MB -2.0%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.277ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.5% Memory: ✅ 64.310MB (SLO: <66.000MB -2.6%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.535ms (SLO: <21.750ms -5.6%) vs baseline: +0.3% Memory: ✅ 65.687MB (SLO: <66.000MB 🟡 -0.5%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.487ms (SLO: <19.650ms -5.9%) vs baseline: +0.3% Memory: ✅ 64.369MB (SLO: <66.000MB -2.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.877ms (SLO: <20.100ms -6.1%) vs baseline: +0.2% Memory: ✅ 64.193MB (SLO: <66.000MB -2.7%) vs baseline: +5.0% ✅ tracer-no-middlewareTime: ✅ 20.186ms (SLO: <21.500ms -6.1%) vs baseline: -0.3% Memory: ✅ 64.369MB (SLO: <66.000MB -2.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.375ms (SLO: <22.000ms -7.4%) vs baseline: +0.3% Memory: ✅ 64.230MB (SLO: <66.000MB -2.7%) vs baseline: +4.5% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.064ms (SLO: <19.850ms -9.0%) vs baseline: -0.2% Memory: ✅ 64.348MB (SLO: <65.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.057ms (SLO: <19.400ms -6.9%) vs baseline: -0.3% Memory: ✅ 64.332MB (SLO: <65.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.050ms (SLO: <19.450ms -7.2%) vs baseline: -0.5% Memory: ✅ 64.301MB (SLO: <65.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 17/17✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: +0.5% Memory: ✅ 61.991MB (SLO: <64.500MB -3.9%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.574ms (SLO: <6.750ms -2.6%) vs baseline: ~same Memory: ✅ 62.148MB (SLO: <64.500MB -3.6%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: +0.3% Memory: ✅ 62.108MB (SLO: <64.500MB -3.7%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.863ms (SLO: <2.000ms -6.9%) vs baseline: +0.1% Memory: ✅ 44.689MB (SLO: <45.000MB 🟡 -0.7%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.864ms (SLO: <2.000ms -6.8%) vs baseline: +0.1% Memory: ✅ 41.701MB (SLO: <49.000MB 📉 -14.9%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.919ms (SLO: <2.100ms -8.6%) vs baseline: -0.2% Memory: ✅ 44.433MB (SLO: <46.500MB -4.4%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.376ms (SLO: <3.650ms -7.5%) vs baseline: +0.2% Memory: ✅ 51.374MB (SLO: <53.500MB -4.0%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 52.711MB (SLO: <53.500MB 🟡 -1.5%) vs baseline: +5.1% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.952ms (SLO: <4.200ms -5.9%) vs baseline: ~same Memory: ✅ 62.490MB (SLO: <66.000MB -5.3%) vs baseline: +4.9% ✅ iast-enabledTime: ✅ 2.508ms (SLO: <2.800ms 📉 -10.4%) vs baseline: -1.4% Memory: ✅ 58.062MB (SLO: <59.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.080ms (SLO: <2.250ms -7.6%) vs baseline: -0.1% Memory: ✅ 51.127MB (SLO: <53.500MB -4.4%) vs baseline: +4.8% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 46.153ms (SLO: <47.150ms -2.1%) vs baseline: +2.1% Memory: ✅ 44.555MB (SLO: <46.500MB -4.2%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 323.960ms (SLO: <344.800ms -6.0%) vs baseline: +1.9% Memory: ✅ 553.243MB (SLO: <562.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 292.556ms (SLO: <314.000ms -6.8%) vs baseline: ~same Memory: ✅ 554.115MB (SLO: <563.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ get-contextTime: ✅ 82.510ms (SLO: <92.350ms 📉 -10.7%) vs baseline: +0.3% Memory: ✅ 39.815MB (SLO: <46.500MB 📉 -14.4%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 43.074ms (SLO: <44.500ms -3.2%) vs baseline: +0.6% Memory: ✅ 44.055MB (SLO: <46.500MB -5.3%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 62.804ms (SLO: <67.650ms -7.2%) vs baseline: +2.0% Memory: ✅ 40.066MB (SLO: <46.500MB 📉 -13.8%) vs baseline: +4.6% ✅ set-statusTime: ✅ 49.002ms (SLO: <50.400ms -2.8%) vs baseline: ~same Memory: ✅ 44.089MB (SLO: <46.500MB -5.2%) vs baseline: +4.9% ✅ startTime: ✅ 43.155ms (SLO: <43.450ms 🟡 -0.7%) vs baseline: +2.0% Memory: ✅ 44.093MB (SLO: <46.500MB -5.2%) vs baseline: +4.8% ✅ start-finishTime: ✅ 82.853ms (SLO: <88.000ms -5.8%) vs baseline: +0.3% Memory: ✅ 33.915MB (SLO: <46.500MB 📉 -27.1%) vs baseline: +4.6% ✅ start-finish-telemetryTime: ✅ 85.929ms (SLO: <89.000ms -3.5%) vs baseline: +1.9% Memory: ✅ 33.994MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.9% ✅ update-nameTime: ✅ 45.117ms (SLO: <45.150ms 🟡 ~same) vs baseline: +2.2% Memory: ✅ 44.359MB (SLO: <46.500MB -4.6%) vs baseline: +4.9%
|
Backport 3dcf919 from #14628 to 3.14.
Checklist
Reviewer Checklist