-
Notifications
You must be signed in to change notification settings - Fork 457
chore(telemetry): replace add_error
by add_error_log
#14641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dubloom/improve-telemetry-logs-redaction
Are you sure you want to change the base?
chore(telemetry): replace add_error
by add_error_log
#14641
Conversation
|
d062836
to
52131a9
Compare
add_error
by add_error_log
add_error
by add_error_log
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 269 ± 5 ms. The average import time from base is: 269 ± 4 ms. The import time difference between this PR and base is: -0.2 ± 0.2 ms. The difference is not statistically significant (z = -1.02). Import time breakdownThe following import paths have appeared:
|
Performance SLOsComparing candidate dubloom/remove-add-error (52131a9) with baseline main (e2bc7d1) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 20.534ms (SLO: <22.300ms -7.9%) vs baseline: ~same Memory: ✅ 64.674MB (SLO: <66.000MB -2.0%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.354ms (SLO: <1.450ms -6.7%) vs baseline: +0.5% Memory: ✅ 63.760MB (SLO: <66.000MB -3.4%) vs baseline: +5.3% ✅ iastTime: ✅ 20.516ms (SLO: <22.250ms -7.8%) vs baseline: +0.3% Memory: ✅ 64.737MB (SLO: <66.000MB 🟡 -1.9%) vs baseline: +5.3% ✅ profilerTime: ✅ 15.196ms (SLO: <16.550ms -8.2%) vs baseline: -0.2% Memory: ✅ 53.071MB (SLO: <53.500MB 🟡 -0.8%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 26.146ms (SLO: <28.200ms -7.3%) vs baseline: ~same Memory: ✅ 66.745MB (SLO: <68.500MB -2.6%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.575ms (SLO: <21.750ms -5.4%) vs baseline: +0.2% Memory: ✅ 64.769MB (SLO: <66.000MB 🟡 -1.9%) vs baseline: +5.3% ✅ tracer-and-profilerTime: ✅ 22.102ms (SLO: <23.500ms -6.0%) vs baseline: +0.2% Memory: ✅ 65.742MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-dont-create-db-spansTime: ✅ 19.432ms (SLO: <21.500ms -9.6%) vs baseline: +0.3% Memory: ✅ 64.706MB (SLO: <66.000MB 🟡 -2.0%) vs baseline: +5.1% ✅ tracer-minimalTime: ✅ 16.691ms (SLO: <17.500ms -4.6%) vs baseline: +0.3% Memory: ✅ 64.378MB (SLO: <66.000MB -2.5%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.511ms (SLO: <21.750ms -5.7%) vs baseline: +0.1% Memory: ✅ 66.057MB (SLO: <66.000MB ~same) vs baseline: +5.4% ✅ tracer-no-cachesTime: ✅ 18.450ms (SLO: <19.650ms -6.1%) vs baseline: +0.2% Memory: ✅ 64.462MB (SLO: <66.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.810ms (SLO: <20.100ms -6.4%) vs baseline: -0.2% Memory: ✅ 64.361MB (SLO: <66.000MB -2.5%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.222ms (SLO: <21.500ms -5.9%) vs baseline: +0.2% Memory: ✅ 64.515MB (SLO: <66.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.402ms (SLO: <22.000ms -7.3%) vs baseline: +0.2% Memory: ✅ 64.700MB (SLO: <66.000MB 🟡 -2.0%) vs baseline: +5.2% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.119ms (SLO: <19.850ms -8.7%) vs baseline: +0.8% Memory: ✅ 64.437MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.092ms (SLO: <19.400ms -6.7%) vs baseline: +0.2% Memory: ✅ 64.372MB (SLO: <65.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 18.060ms (SLO: <19.450ms -7.1%) vs baseline: ~same Memory: ✅ 64.468MB (SLO: <65.500MB 🟡 -1.6%) vs baseline: +4.9% 🟡 flasksimple - 17/17✅ appsec-getTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.3% Memory: ✅ 62.339MB (SLO: <64.500MB -3.3%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.586ms (SLO: <6.750ms -2.4%) vs baseline: -0.1% Memory: ✅ 62.752MB (SLO: <64.500MB -2.7%) vs baseline: +5.4% ✅ appsec-telemetryTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: ~same Memory: ✅ 62.348MB (SLO: <64.500MB -3.3%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 44.739MB (SLO: <45.000MB 🟡 -0.6%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: +0.1% Memory: ✅ 41.688MB (SLO: <49.000MB 📉 -14.9%) vs baseline: +4.3% ✅ profilerTime: ✅ 1.920ms (SLO: <2.100ms -8.6%) vs baseline: ~same Memory: ✅ 44.400MB (SLO: <46.500MB -4.5%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: +0.1% Memory: ✅ 51.365MB (SLO: <53.500MB -4.0%) vs baseline: +4.6% ✅ tracer-nativeTime: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: +0.3% Memory: ✅ 52.634MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.951ms (SLO: <4.200ms -5.9%) vs baseline: +0.3% Memory: ✅ 62.620MB (SLO: <66.000MB -5.1%) vs baseline: +5.0% ✅ iast-enabledTime: ✅ 2.457ms (SLO: <2.800ms 📉 -12.3%) vs baseline: ~same Memory: ✅ 58.235MB (SLO: <59.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 2.078ms (SLO: <2.250ms -7.6%) vs baseline: +0.2% Memory: ✅ 51.236MB (SLO: <53.500MB -4.2%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.309ms (SLO: <47.150ms -3.9%) vs baseline: +0.2% Memory: ✅ 44.671MB (SLO: <46.500MB -3.9%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 323.438ms (SLO: <344.800ms -6.2%) vs baseline: +1.5% Memory: ✅ 553.538MB (SLO: <562.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 293.494ms (SLO: <314.000ms -6.5%) vs baseline: +1.1% Memory: ✅ 554.553MB (SLO: <563.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ get-contextTime: ✅ 83.693ms (SLO: <92.350ms -9.4%) vs baseline: +1.4% Memory: ✅ 39.883MB (SLO: <46.500MB 📉 -14.2%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 42.730ms (SLO: <44.500ms -4.0%) vs baseline: -0.6% Memory: ✅ 44.225MB (SLO: <46.500MB -4.9%) vs baseline: +5.1% ✅ record-exceptionTime: ✅ 62.055ms (SLO: <67.650ms -8.3%) vs baseline: +0.6% Memory: ✅ 40.213MB (SLO: <46.500MB 📉 -13.5%) vs baseline: +5.2% ✅ set-statusTime: ✅ 48.840ms (SLO: <50.400ms -3.1%) vs baseline: -0.2% Memory: ✅ 44.170MB (SLO: <46.500MB -5.0%) vs baseline: +5.2% ✅ startTime: ✅ 43.183ms (SLO: <43.450ms 🟡 -0.6%) vs baseline: +2.1% Memory: ✅ 44.131MB (SLO: <46.500MB -5.1%) vs baseline: +4.8% ✅ start-finishTime: ✅ 85.078ms (SLO: <88.000ms -3.3%) vs baseline: +2.3% Memory: ✅ 33.974MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 86.651ms (SLO: <89.000ms -2.6%) vs baseline: +2.2% Memory: ✅ 33.974MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.6% ✅ update-nameTime: ✅ 44.125ms (SLO: <45.150ms -2.3%) vs baseline: -0.5% Memory: ✅ 44.404MB (SLO: <46.500MB -4.5%) vs baseline: +4.9%
|
Second PR in a list of 3 PRs to achieved requirements listed here.
See: #14639.
Changes
add_error
was allowing only one error to be reported by telemetry payload. In addition, it exposed potential PII by not redacting the filename. This PR replacesadd_error
byadd_error_log
which will allow multiple errors reporting and also to report the (redacted) stack trace.Checklist
Reviewer Checklist