-
Notifications
You must be signed in to change notification settings - Fork 457
chore(di): improve flush logging #14612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We improve the flush logging by correctly reporting the payload cardinality. We also fix a few typos.
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 277 ± 6 ms. The average import time from base is: 278 ± 6 ms. The import time difference between this PR and base is: -1.4 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate chore/debugger-improve-flush-logging (a4dfeb1) with baseline main (2c76e72) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.364µs (SLO: <10.000µs 📉 -56.4%) vs baseline: +0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 1.069µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -0.8% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.993µs (SLO: <10.000µs 📉 -30.1%) vs baseline: 📈 +15.1% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.3% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.551µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +1.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.565µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.941µs (SLO: <10.000µs 📉 -50.6%) vs baseline: ~same Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +1.2% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.758µs (SLO: <10.000µs 📉 -62.4%) vs baseline: +0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.689µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.2% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.611µs (SLO: <10.000µs 📉 -53.9%) vs baseline: +0.4% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.391µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +5.0% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 20.537ms (SLO: <22.300ms -7.9%) vs baseline: ~same Memory: ✅ 65.270MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.344ms (SLO: <1.450ms -7.3%) vs baseline: -0.9% Memory: ✅ 64.208MB (SLO: <67.000MB -4.2%) vs baseline: +5.0% ✅ iastTime: ✅ 20.461ms (SLO: <22.250ms -8.0%) vs baseline: -0.3% Memory: ✅ 65.313MB (SLO: <67.000MB -2.5%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.336ms (SLO: <16.550ms -7.3%) vs baseline: +0.8% Memory: ✅ 53.575MB (SLO: <54.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 26.122ms (SLO: <28.200ms -7.4%) vs baseline: -0.2% Memory: ✅ 67.230MB (SLO: <69.500MB -3.3%) vs baseline: +4.6% ✅ tracerTime: ✅ 20.538ms (SLO: <21.750ms -5.6%) vs baseline: +0.1% Memory: ✅ 65.309MB (SLO: <67.000MB -2.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.186ms (SLO: <23.500ms -5.6%) vs baseline: ~same Memory: ✅ 66.315MB (SLO: <67.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.362ms (SLO: <21.500ms -9.9%) vs baseline: +0.3% Memory: ✅ 65.310MB (SLO: <66.000MB 🟡 -1.0%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.703ms (SLO: <17.500ms -4.6%) vs baseline: +0.1% Memory: ✅ 64.878MB (SLO: <66.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.497ms (SLO: <21.750ms -5.8%) vs baseline: ~same Memory: ✅ 71.054MB (SLO: <72.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.501ms (SLO: <19.650ms -5.8%) vs baseline: +0.3% Memory: ✅ 65.191MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.882ms (SLO: <20.100ms -6.1%) vs baseline: +0.8% Memory: ✅ 64.880MB (SLO: <67.000MB -3.2%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.212ms (SLO: <21.500ms -6.0%) vs baseline: ~same Memory: ✅ 65.351MB (SLO: <67.000MB -2.5%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.355ms (SLO: <22.000ms -7.5%) vs baseline: +0.2% Memory: ✅ 65.332MB (SLO: <67.000MB -2.5%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.069ms (SLO: <19.850ms -9.0%) vs baseline: +0.4% Memory: ✅ 65.229MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.104ms (SLO: <19.400ms -6.7%) vs baseline: +0.8% Memory: ✅ 65.231MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.047ms (SLO: <19.450ms -7.2%) vs baseline: +0.2% Memory: ✅ 65.177MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.950ms (SLO: <4.200ms -5.9%) vs baseline: -0.4% Memory: ✅ 63.334MB (SLO: <66.000MB -4.0%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.452ms (SLO: <2.800ms 📉 -12.4%) vs baseline: -0.7% Memory: ✅ 58.860MB (SLO: <60.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.079ms (SLO: <2.250ms -7.6%) vs baseline: ~same Memory: ✅ 52.081MB (SLO: <54.500MB -4.4%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 45.313ms (SLO: <47.150ms -3.9%) vs baseline: +0.7% Memory: ✅ 45.136MB (SLO: <47.000MB -4.0%) vs baseline: +5.0% ✅ add-metricsTime: ✅ 321.401ms (SLO: <344.800ms -6.8%) vs baseline: +0.9% Memory: ✅ 553.005MB (SLO: <562.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ add-tagsTime: ✅ 292.975ms (SLO: <314.000ms -6.7%) vs baseline: +0.1% Memory: ✅ 553.775MB (SLO: <563.500MB 🟡 -1.7%) vs baseline: +4.2% ✅ get-contextTime: ✅ 82.816ms (SLO: <92.350ms 📉 -10.3%) vs baseline: +0.3% Memory: ✅ 40.106MB (SLO: <46.500MB 📉 -13.8%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 42.861ms (SLO: <44.500ms -3.7%) vs baseline: -0.3% Memory: ✅ 44.464MB (SLO: <47.500MB -6.4%) vs baseline: +4.7% ✅ record-exceptionTime: ✅ 61.739ms (SLO: <67.650ms -8.7%) vs baseline: -0.1% Memory: ✅ 40.512MB (SLO: <47.000MB 📉 -13.8%) vs baseline: +4.9% ✅ set-statusTime: ✅ 49.029ms (SLO: <50.400ms -2.7%) vs baseline: ~same Memory: ✅ 44.461MB (SLO: <47.000MB -5.4%) vs baseline: +4.7% ✅ startTime: ✅ 42.199ms (SLO: <43.450ms -2.9%) vs baseline: -0.1% Memory: ✅ 44.546MB (SLO: <47.000MB -5.2%) vs baseline: +5.0% ✅ start-finishTime: ✅ 82.945ms (SLO: <88.000ms -5.7%) vs baseline: +0.2% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.611ms (SLO: <89.000ms -4.9%) vs baseline: +0.5% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ update-nameTime: ✅ 44.165ms (SLO: <45.150ms -2.2%) vs baseline: -0.5% Memory: ✅ 44.771MB (SLO: <47.000MB -4.7%) vs baseline: +4.8%
|
This one needs to be rebased |
12aad77
to
a4dfeb1
Compare
We improve the flush logging by correctly reporting the payload cardinality. We also fix a few typos.
Checklist
Reviewer Checklist