-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): remove beta auto span linking flag, decorator linking #13077
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 5 ms. The average import time from base is: 238 ± 4 ms. The import time difference between this PR and base is: -0.4 ± 0.2 ms. The difference is not statistically significant (z = -1.89). Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-07 18:54:39 Comparing candidate commit 291112d in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 495 metrics, 2 unstable metrics. scenario:iast_aspects-ospathsplit_aspect
|
Approved, but some llmobs snapshot tests are failing, (maybe?) due to the |
This PR removes the
_DD_LLMOBS_AUTO_SPAN_LINKING_ENABLED
configuration flag. This is a beta feature that was previously private, but no longer disabled by default. However removing this flag is not a breaking change, as this will simply add functionality (add span linking in our integrations and decorators).This PR also removes the auto span linking feature for decorator spans. This was an experimental feature that we started when we first introduced span linking, but we've decided to remove this for now and keep span linking limited to our integrations.
In hindsight it should be noted that adding this option to the
config.py
file was probably a mistake, since it was a private feature flag that was destined to be removed fairly soon. We should have just read it directly as an environment variable, but wanted to reiterate that removing this from theconfig.py
file is not a breaking change (although it would be normally) since this is a private feature flag for experimental users.Checklist
Reviewer Checklist