Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): remove pytest v1 plugin #13074

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

vitor-de-araujo
Copy link
Contributor

@vitor-de-araujo vitor-de-araujo commented Apr 4, 2025

The pytest v2 plugin became the default in 3.0.0 and the option to switch between the old and new one was removed from the public interface, so the old plugin was not available for use anymore. This PR fully removes the old plugin.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 4, 2025

CODEOWNERS have been resolved as:

.riot/requirements/10b8fc3.txt                                          @DataDog/apm-python
.riot/requirements/1163993.txt                                          @DataDog/apm-python
.riot/requirements/1252d0f.txt                                          @DataDog/apm-python
.riot/requirements/144615f.txt                                          @DataDog/apm-python
.riot/requirements/14ca37f.txt                                          @DataDog/apm-python
.riot/requirements/166af91.txt                                          @DataDog/apm-python
.riot/requirements/17cf97e.txt                                          @DataDog/apm-python
.riot/requirements/18147c2.txt                                          @DataDog/apm-python
.riot/requirements/1b09cab.txt                                          @DataDog/apm-python
.riot/requirements/1becf29.txt                                          @DataDog/apm-python
.riot/requirements/1cc7f49.txt                                          @DataDog/apm-python
.riot/requirements/1ce9a95.txt                                          @DataDog/apm-python
.riot/requirements/1d44438.txt                                          @DataDog/apm-python
.riot/requirements/1f42cb3.txt                                          @DataDog/apm-python
.riot/requirements/2b9f1e7.txt                                          @DataDog/apm-python
.riot/requirements/3af9e27.txt                                          @DataDog/apm-python
.riot/requirements/48eb599.txt                                          @DataDog/apm-python
.riot/requirements/498209d.txt                                          @DataDog/apm-python
.riot/requirements/7e7551c.txt                                          @DataDog/apm-python
.riot/requirements/8fd4efc.txt                                          @DataDog/apm-python
.riot/requirements/91bec06.txt                                          @DataDog/apm-python
.riot/requirements/9b8c47e.txt                                          @DataDog/apm-python
.riot/requirements/d03449e.txt                                          @DataDog/apm-python
.riot/requirements/db02b05.txt                                          @DataDog/apm-python
.riot/requirements/e5cd460.txt                                          @DataDog/apm-python
.riot/requirements/fb47988.txt                                          @DataDog/apm-python
.riot/requirements/ff88ab0.txt                                          @DataDog/apm-python
ddtrace/contrib/internal/pytest/_plugin_v2.py                           @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/_utils.py                               @DataDog/ci-app-libraries
ddtrace/contrib/internal/pytest/plugin.py                               @DataDog/ci-app-libraries
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/ci_visibility/test_cli.py                                         @DataDog/ci-app-libraries
tests/contrib/flask/test_appsec_flask_pytest_iast_no_snapshot.py        @DataDog/asm-python
tests/contrib/pytest/test_coverage_per_suite.py                         @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest.py                                     @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_atr.py                                 @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_attempt_to_fix.py                      @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_disabling.py                           @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_efd.py                                 @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_quarantine.py                          @DataDog/ci-app-libraries
tests/contrib/pytest/test_pytest_snapshot_v2.py                         @DataDog/ci-app-libraries
tests/contrib/selenium/test_selenium_chrome.py                          @DataDog/ci-app-libraries

Copy link
Contributor

github-actions bot commented Apr 4, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 232 ± 3 ms.

The average import time from base is: 239 ± 7 ms.

The import time difference between this PR and base is: -7.2 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.352 ms (1.01%)
ddtrace.bootstrap.sitecustomize 1.676 ms (0.72%)
ddtrace.bootstrap.preload 1.676 ms (0.72%)
ddtrace.internal.products 1.676 ms (0.72%)
ddtrace.internal.remoteconfig.client 0.755 ms (0.33%)
ddtrace 0.676 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 4, 2025

Benchmarks

Benchmark execution time: 2025-04-09 16:27:15

Comparing candidate commit 6b367be in PR branch vitor-de-araujo/remove-pytest-v1 with baseline commit db0ce35 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant