refactor(tracing): break span-sampling cycle#13061
Closed
Conversation
Contributor
|
|
Contributor
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 237 ± 6 ms. The average import time from base is: 235 ± 4 ms. The import time difference between this PR and base is: 1.9 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
c43a555 to
5249449
Compare
We break the cycle between the span object and the sampling logic by moving some methods and functions around
5249449 to
46cd1c9
Compare
c727d5f to
bb2ad1c
Compare
bb2ad1c to
58a9859
Compare
Contributor
|
This pull request has been automatically closed after a period of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We break the cycle between the span object and the sampling logic by moving some methods and functions around
Checklist
Reviewer Checklist