Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported versions workflow #13059

Merged
merged 10 commits into from
Apr 9, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Apr 3, 2025

Update workflow + table for generating supported integrations and tested versions.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Apr 3, 2025

CODEOWNERS have been resolved as:

scripts/freshvenvs.py                                                   @DataDog/apm-core-python
supported_versions_output.json                                          @DataDog/apm-core-python
supported_versions_table.csv                                            @DataDog/apm-core-python

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 230 ± 2 ms.

The average import time from base is: 232 ± 2 ms.

The import time difference between this PR and base is: -2.29 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.965 ms (0.86%)
ddtrace.bootstrap.sitecustomize 1.305 ms (0.57%)
ddtrace.bootstrap.preload 1.305 ms (0.57%)
ddtrace.internal.products 1.305 ms (0.57%)
ddtrace.internal.remoteconfig.client 0.638 ms (0.28%)
ddtrace 0.660 ms (0.29%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 3, 2025

Benchmarks

Benchmark execution time: 2025-04-09 15:21:01

Comparing candidate commit 522a06e in PR branch quinna/update-supported-versions with baseline commit 712dfc2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

@quinna-h quinna-h changed the title update supported versions workflow chore(ci): update supported versions workflow Apr 4, 2025
@quinna-h quinna-h changed the title chore(ci): update supported versions workflow chore: update supported versions workflow Apr 4, 2025
@quinna-h quinna-h marked this pull request as ready for review April 7, 2025 17:42
@quinna-h quinna-h requested a review from a team as a code owner April 7, 2025 17:42
@quinna-h quinna-h requested a review from emmettbutler April 7, 2025 17:42
@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 7, 2025
@quinna-h quinna-h requested a review from wconti27 April 8, 2025 13:57
Copy link
Contributor

@wconti27 wconti27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@quinna-h quinna-h enabled auto-merge (squash) April 8, 2025 17:27
@quinna-h quinna-h merged commit db0ce35 into main Apr 9, 2025
328 of 330 checks passed
@quinna-h quinna-h deleted the quinna/update-supported-versions branch April 9, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants