Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix CircleCI dynamic job selection #11873

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Jan 8, 2025

We fix a residual issue in #11668 whereby no suites where actually dynamically selected for CircleCI.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We fix a residual issue in #11668 whereby no suites where actually
dynamically selected for CircleCI.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 8, 2025
@P403n1x87 P403n1x87 self-assigned this Jan 8, 2025
@P403n1x87 P403n1x87 requested a review from a team as a code owner January 8, 2025 10:54
@P403n1x87 P403n1x87 requested a review from emmettbutler January 8, 2025 10:54
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CODEOWNERS have been resolved as:

scripts/gen_circleci_config.py                                          @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: ci/fix-circleci-job-selection
Commit report: 0e31457
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 4m 10.31s Total duration (35m 20.51s time saved)

@P403n1x87 P403n1x87 merged commit 41fce6d into main Jan 9, 2025
238 of 239 checks passed
@P403n1x87 P403n1x87 deleted the ci/fix-circleci-job-selection branch January 9, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants