test(er): fix broken exception ID asserts #11869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in #11772 broke ER tests that were relying on the old exception ID tag. The rerun mechanism made the test pass on re-run so the failure was not caught and the change was merged. Only the tests were impacted, there was no impact on user-facing functionalities.
P403n1x87
added
changelog/no-changelog
|
|
Datadog ReportBranch report: ✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 59.97s Total duration (35m 22.06s time saved) |
BenchmarksBenchmark execution time: 2025-01-07 16:17:55 Comparing candidate commit ca1e34d in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics. scenario:iast_aspects-ospathjoin_aspect
|
shatzi
approved these changes
Jan 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
The changes in #11772 broke ER tests that were relying on the old exception ID tag. The rerun mechanism made the test pass on re-run so the failure was not caught and the change was merged. Only the tests were impacted, there was no impact on user-facing functionalities. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit a225334)
2 tasks
erikayasuda
pushed a commit
that referenced
this pull request
Jan 14, 2025
Backport a225334 from #11869 to 2.19. The changes in #11772 broke ER tests that were relying on the old exception ID tag. The rerun mechanism made the test pass on re-run so the failure was not caught and the change was merged. Only the tests were impacted, there was no impact on user-facing functionalities. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Gabriele N. Tornetta <[email protected]> Co-authored-by: Taegyun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #11772 broke ER tests that were relying on the old exception ID tag. The rerun mechanism made the test pass on re-run so the failure was not caught and the change was merged. Only the tests were impacted, there was no impact on user-facing functionalities.
Checklist
Reviewer Checklist