Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib-injection): remove python-json-logger from library compatibility check #11817

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Dec 20, 2024

This library is only used in our testing, we do not have an integration for it, so the version used by any customer should not matter when evaluating library compatibility.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/fix-lib-injection-python-json-logger-5248a251acb1adf4.yaml  @DataDog/apm-python
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
scripts/min_compatible_versions.py                                      @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 20, 2024

Benchmarks

Benchmark execution time: 2025-01-07 19:59:13

Comparing candidate commit 0e1d0ec in PR branch brettlangdon/fix.json.logger with baseline commit 2a6774e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@brettlangdon brettlangdon enabled auto-merge (squash) January 7, 2025 19:19
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: brettlangdon/fix.json.logger
Commit report: 0e1d0ec
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 51.41s Total duration (35m 25.12s time saved)

@brettlangdon brettlangdon merged commit 4970e6d into main Jan 7, 2025
235 checks passed
@brettlangdon brettlangdon deleted the brettlangdon/fix.json.logger branch January 7, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants