Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(botocore): enable 3.13 tests #11803

Merged
merged 100 commits into from
Jan 13, 2025
Merged

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Dec 19, 2024

This change enables tests under Python 3.13 for the integrations related to botocore.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Dec 19, 2024

CODEOWNERS have been resolved as:

.riot/requirements/127eabf.txt                                          @DataDog/apm-python
.riot/requirements/1522dd0.txt                                          @DataDog/apm-python
.riot/requirements/5ccc957.txt                                          @DataDog/apm-python
releasenotes/notes/threethirteen-botocore-ee2431d065f99d7b.yaml         @DataDog/apm-python
riotfile.py                                                             @DataDog/apm-python
tests/contrib/botocore/test.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/fastapi/test_fastapi_appsec_iast.py                       @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2024

Benchmarks

Benchmark execution time: 2025-01-13 20:48:55

Comparing candidate commit d2ef784 in PR branch emmett.butler/integrations-313-2 with baseline commit 358a167 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Dec 20, 2024

Datadog Report

Branch report: emmett.butler/integrations-313-2
Commit report: d2ef784
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 37.57s Total duration (27m 58.89s time saved)

Base automatically changed from emmett.butler/integrations-313 to main January 6, 2025 17:27
@emmettbutler emmettbutler changed the title enable 3.13 tests for botocore ci(botocore): enable 3.13 tests Jan 6, 2025
@emmettbutler emmettbutler marked this pull request as ready for review January 6, 2025 18:09
@emmettbutler emmettbutler requested review from a team as code owners January 6, 2025 18:09
@emmettbutler emmettbutler enabled auto-merge (squash) January 7, 2025 14:24
@emmettbutler emmettbutler merged commit b13bcb0 into main Jan 13, 2025
607 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/integrations-313-2 branch January 13, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants